From 0fe8c0492c6dfa7acd9e42be3050f3456acd01c2 Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Mon, 19 Jan 2026 10:18:59 +0000 Subject: [PATCH] lib/qemu.c: Turn debug messages which are really errors into error() Commit 669eda1e24 ("lib/launch-direct.c: Simplify test for KVM, remove qemu caching") made it so that failure of generic_qmp_test() will cause launch to fail. However we still used debug messages to print the error, so unless you have debugging enabled you wouldn't see any error message if this function fails. Updates: commit 669eda1e245a7e7d0f1577b4d48447495333faf8 --- lib/qemu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/qemu.c b/lib/qemu.c index b8cc9c5a1..6dab0eb32 100644 --- a/lib/qemu.c +++ b/lib/qemu.c @@ -109,7 +109,7 @@ generic_qmp_test (guestfs_h *g, const char *qmp_command, char **outp) len = getline (&line, &allocsize, fp); /* line 1 */ if (len == -1 || strstr (line, "\"QMP\"") == NULL) { parse_failure: - debug (g, "did not understand QMP monitor output from %s", g->hv); + error (g, "did not understand QMP monitor output from %s", g->hv); return -1; } len = getline (&line, &allocsize, fp); /* line 2 */ @@ -126,7 +126,7 @@ generic_qmp_test (guestfs_h *g, const char *qmp_command, char **outp) r = guestfs_int_cmd_pipe_wait (cmd); /* QMP tests are optional, don't fail if the tests fail. */ if (r == -1 || !WIFEXITED (r) || WEXITSTATUS (r) != 0) { - debug (g, "%s wait failed or unexpected exit status", g->hv); + error (g, "%s wait failed or unexpected exit status", g->hv); return -1; }