From 12da1de0a83eb072fd3c41e33abeb238f21a1da2 Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Wed, 22 May 2024 11:22:31 +0100 Subject: [PATCH] lib: libvirt: Stop recommending LIBGUESTFS_BACKEND=direct After many, many years, although libvirt does still often fail to work, it's generally more secure to stick with libvirt than to try running qemu directly. The main issue here is that people have cargo-culted LIBGUESTFS_BACKEND=direct everywhere (even when it's not necessary). --- lib/launch-libvirt.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/lib/launch-libvirt.c b/lib/launch-libvirt.c index 872bc2a05..04ac53672 100644 --- a/lib/launch-libvirt.c +++ b/lib/launch-libvirt.c @@ -625,12 +625,8 @@ launch_libvirt (guestfs_h *g, void *datav, const char *libvirt_uri) dom = virDomainCreateXML (conn, (char *) xml, VIR_DOMAIN_START_AUTODESTROY); if (!dom) { libvirt_error (g, _( - "could not create appliance through libvirt.\n" - "\n" - "Try running qemu directly without libvirt using this environment variable:\n" - "export LIBGUESTFS_BACKEND=direct\n" - "\n" - "Original error from libvirt")); + "could not create appliance through libvirt. " + "Original error from libvirt")); goto cleanup; }