From 4349548c837811fd939ccea5b7032d68605e634d Mon Sep 17 00:00:00 2001 From: Susant Sahani Date: Wed, 26 Nov 2025 18:24:57 +0530 Subject: [PATCH] lib/create: explicitly close fd and report close(2) errors Signed-off-by: Susant Sahani --- lib/create.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/create.c b/lib/create.c index f1a16a19e..1a1719330 100644 --- a/lib/create.c +++ b/lib/create.c @@ -104,9 +104,7 @@ guestfs_impl_disk_create (guestfs_h *g, const char *filename, static int disk_create_raw_block (guestfs_h *g, const char *filename) { - int fd; - - fd = open (filename, O_WRONLY|O_NOCTTY|O_CLOEXEC, 0666); + int fd = open(filename, O_WRONLY|O_NOCTTY|O_CLOEXEC, 0666); if (fd == -1) { perrorf (g, _("cannot open block device: %s"), filename); return -1; @@ -125,7 +123,10 @@ disk_create_raw_block (guestfs_h *g, const char *filename) } #endif - close (fd); + if (close (fd) == -1) { + perrorf (g, _("%s: close"), filename); + return -1; + } return 0; }