From 6cdc5abd38c8caa1ff1e1c45c4a976899d384f01 Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Thu, 8 Mar 2012 14:30:10 +0000 Subject: [PATCH] daemon: glob: Initialize glob buffer (quiet Coverity warning). Error: UNINIT: /builddir/build/BUILD/libguestfs-1.16.5/daemon/glob.c:32: var_decl: Declaring variable "buf" without initializer. /builddir/build/BUILD/libguestfs-1.16.5/daemon/glob.c:36: uninit_use_in_call: Using uninitialized value "buf.gl_offs" when calling "rpl_glob". /builddir/build/BUILD/libguestfs-1.16.5/gnulib/lib/glob.c:557: read_parm_fld: Reading a parameter field. /builddir/build/BUILD/libguestfs-1.16.5/daemon/glob.c:36: uninit_use_in_call: Using uninitialized value "buf.gl_pathc" when calling "rpl_glob". /builddir/build/BUILD/libguestfs-1.16.5/gnulib/lib/glob.c:557: read_parm_fld: Reading a parameter field. (cherry picked from commit b2c1d8be39d4689267ef7e4188e2cf936b30628f) --- daemon/glob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/glob.c b/daemon/glob.c index ad8aa5441..45fb30f19 100644 --- a/daemon/glob.c +++ b/daemon/glob.c @@ -29,7 +29,7 @@ char ** do_glob_expand (const char *pattern) { int r; - glob_t buf; + glob_t buf = { .gl_pathc = 0, .gl_pathv = NULL, .gl_offs = 0 }; /* glob(3) in glibc never calls chdir, so this seems to be safe: */ CHROOT_IN;