From 7941f6785e409ad283b654ca26db9f919bf5f7c7 Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Sat, 8 Dec 2012 13:30:14 +0000 Subject: [PATCH] fish: copy-out: Fail on some errors when creating output directory (found by Coverity). However it's not an error if the output directory already exists. --- fish/copy.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fish/copy.c b/fish/copy.c index 5b1bf4c1c..50f741042 100644 --- a/fish/copy.c +++ b/fish/copy.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include #include @@ -378,7 +379,10 @@ make_tar_output (const char *local, const char *basename) _exit (EXIT_FAILURE); } - mkdir (basename, 0777); + if (mkdir (basename, 0777) == -1 && errno != EEXIST) { + perror (basename); + _exit (EXIT_FAILURE); + } if (chdir (basename) == -1) { perror (basename);