mirrors/libguestfs
1
0
Fork 0
mirror of https://github.com/libguestfs/libguestfs.git synced 2026-03-21 22:53:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

daemon: fix fd leak in do_inotify_files on error paths (#319)

Browse Source 
When popen or do_inotify_read fails, the file descriptor created by
mkstemp is never closed before returning. Add close(fd) to both
error paths to prevent file descriptor leaks.

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
shivanayak
2026-03-09 23:45:38 +05:30
committed by GitHub
parent ff4467a1a4
commit 91578639c6
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
daemon/inotify.c
View File

@@ -331,6 +331,7 @@ do_inotify_files (void)
pp = popen (cmd, "w"); pp = popen (cmd, "w");
if (pp == NULL) { if (pp == NULL) {
reply_with_perror ("sort"); reply_with_perror ("sort");
close (fd);
unlink (tempfile); unlink (tempfile);
return NULL; return NULL;
} }
@@ -339,6 +340,7 @@ do_inotify_files (void)
events = do_inotify_read (); events = do_inotify_read ();
if (events == NULL) { if (events == NULL) {
pclose (pp); pclose (pp);
close (fd);
unlink (tempfile); unlink (tempfile);
return NULL; return NULL;
} }