From 9974c42a29d60e6d1364c7d39f8c952604d41012 Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Wed, 14 Mar 2012 12:53:37 +0000 Subject: [PATCH] todo: Document ongoing code cleanups. --- TODO | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/TODO b/TODO index 499c3454a..72a00b7d1 100644 --- a/TODO +++ b/TODO @@ -595,3 +595,19 @@ to do a kind of migration of guests by simply recreating the guest from the description on the target machine. It would be ideal to integrate this and/or use inspection to do this. + +Ongoing code cleanups +--------------------- + +Examine every use of 'int' in C code for signed overflow problems. + +All file descriptors in the library and daemon should normally be +opened with O_CLOEXEC. Therefore we need to examine every call to: + + - open, openat + - creat + - pipe (see also: pipe2) + - dup, dup2 (see also: dup3) + - socket, socketpair + - accept + - signalfd, timerfd, epoll_create