mirror of
https://github.com/libguestfs/libguestfs.git
synced 2026-03-21 22:53:37 +00:00
New API: ntfs_chmod
Add an API to do the equivalent of `chmod [-r] MODE PATH` for NTFS filesystems. Files created on a linux ntfs-3g mount can not change permissions directly. New files and directories are created with rough windows equivalent of `chmod 777`. These wide open permissions can generate security warnings on windows after virt-v2v installs bits into `Program Files\Guestfs`. Behind the scenes we use `ntfssecaudit(8)` from `ntfsprogs` which is already part of the appliance. We only expose the chmod-style feature; the rest of `ntfssecaudit` is concerned reporting and managing fine grained windows security info which is way more than we need. Also note, `ntfssecaudit` needs to run on an unmounted partition so using this is more complicated than a traditional `chmod` call. Related: https://issues.redhat.com/browse/RHEL-104352 Signed-off-by: Cole Robinson <crobinso@redhat.com>
This commit is contained in:
@@ -329,3 +329,34 @@ do_ntfscat_i (const mountable_t *mountable, int64_t inode)
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
/* Takes optional arguments, consult optargs_bitmask. */
|
||||
int
|
||||
do_ntfs_chmod (const char *device, int mode, const char *path, int recursive)
|
||||
{
|
||||
const char *argv[MAX_ARGS];
|
||||
size_t i = 0;
|
||||
int r;
|
||||
CLEANUP_FREE char *err = NULL;
|
||||
char mode_str[16];
|
||||
|
||||
snprintf (mode_str, sizeof mode_str, "%o", mode);
|
||||
|
||||
ADD_ARG (argv, i, "ntfssecaudit");
|
||||
|
||||
if ((optargs_bitmask & GUESTFS_NTFS_CHMOD_RECURSIVE_BITMASK) && recursive)
|
||||
ADD_ARG (argv, i, "-r");
|
||||
|
||||
ADD_ARG (argv, i, device);
|
||||
ADD_ARG (argv, i, mode_str);
|
||||
ADD_ARG (argv, i, path);
|
||||
ADD_ARG (argv, i, NULL);
|
||||
|
||||
r = commandvf (NULL, &err, COMMAND_FLAG_FOLD_STDOUT_ON_STDERR, argv);
|
||||
if (r == -1) {
|
||||
reply_with_error ("ntfssecaudit %s %s %s: %s", device, mode_str, path, err);
|
||||
return -1;
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user