From a57f6b8e2c3c9a3fe4aa0ac80f50652f5d350bcb Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Tue, 10 Jun 2025 11:52:30 +0100 Subject: [PATCH] gobject: Mark the gobject bindings as deprecated They will be removed in libguestfs 1.58 (the next but one version). Currently they don't actually compile. The larger problem is that they don't handle 64 bit quantities properly (using floats instead), meaning that any disk size or offset above a certain size will be improperly passed through the API, usually rounded to the nearest 53 bits. --- docs/guestfs-recipes.pod | 1 - docs/guestfs-release-notes-1.56.pod | 3 +++ erlang/examples/guestfs-erlang.pod | 1 - gobject/guestfs-gobject.pod | 4 ++++ golang/examples/guestfs-golang.pod | 1 - java/examples/guestfs-java.pod | 1 - lib/guestfs.pod | 8 -------- lua/examples/guestfs-lua.pod | 1 - ocaml/examples/guestfs-ocaml.pod | 1 - perl/examples/guestfs-perl.pod | 1 - python/examples/guestfs-python.pod | 1 - ruby/examples/guestfs-ruby.pod | 1 - 12 files changed, 7 insertions(+), 17 deletions(-) diff --git a/docs/guestfs-recipes.pod b/docs/guestfs-recipes.pod index 6381ab39b..305bd92f6 100644 --- a/docs/guestfs-recipes.pod +++ b/docs/guestfs-recipes.pod @@ -722,7 +722,6 @@ L, L, L, L, -L, L, L, L, diff --git a/docs/guestfs-release-notes-1.56.pod b/docs/guestfs-release-notes-1.56.pod index 357ba6ea3..71af70a2e 100644 --- a/docs/guestfs-release-notes-1.56.pod +++ b/docs/guestfs-release-notes-1.56.pod @@ -47,6 +47,9 @@ the command line I<-n> flag. Previously C<-L../lib/.libs> got embedded in the distributed OCaml bindings. This has been fixed. +GObject bindings have been deprecated and will be removed in +S. + =head2 Build changes json-c is now required. This replaces Jansson which was previously diff --git a/erlang/examples/guestfs-erlang.pod b/erlang/examples/guestfs-erlang.pod index c947c9761..da8f18f09 100644 --- a/erlang/examples/guestfs-erlang.pod +++ b/erlang/examples/guestfs-erlang.pod @@ -96,7 +96,6 @@ C is the name of the unknown argument. L, L, -L, L, L, L, diff --git a/gobject/guestfs-gobject.pod b/gobject/guestfs-gobject.pod index 63817e126..f4e13a976 100644 --- a/gobject/guestfs-gobject.pod +++ b/gobject/guestfs-gobject.pod @@ -2,6 +2,10 @@ guestfs-gobject - How to use libguestfs with the GObject bindings +=head1 DEPRECATED + +These bindings are deprecated and will be removed in libguestfs 1.58. + =head1 SYNOPSIS From Javascript using gjs: diff --git a/golang/examples/guestfs-golang.pod b/golang/examples/guestfs-golang.pod index 7b9c80ab4..c2de45ece 100644 --- a/golang/examples/guestfs-golang.pod +++ b/golang/examples/guestfs-golang.pod @@ -78,7 +78,6 @@ UUIDs are not returned in structures. L, L, L, -L, L, L, L, diff --git a/java/examples/guestfs-java.pod b/java/examples/guestfs-java.pod index e8e98396d..dfe09a1c9 100644 --- a/java/examples/guestfs-java.pod +++ b/java/examples/guestfs-java.pod @@ -161,7 +161,6 @@ on the class path, as well as the path of your program. For example: L, L, L, -L, L, L, L, diff --git a/lib/guestfs.pod b/lib/guestfs.pod index d2c90418e..f69d5a070 100644 --- a/lib/guestfs.pod +++ b/lib/guestfs.pod @@ -1105,13 +1105,6 @@ at the top of F. See L. -=item B - -Experimental GObject bindings (with GObject Introspection support) are -available. - -See L. - =item B See L. @@ -3202,7 +3195,6 @@ L. Language bindings: L, -L, L, L, L, diff --git a/lua/examples/guestfs-lua.pod b/lua/examples/guestfs-lua.pod index 09de8d4a8..36ea297ba 100644 --- a/lua/examples/guestfs-lua.pod +++ b/lua/examples/guestfs-lua.pod @@ -138,7 +138,6 @@ returned when you registered the callback: L, L, L, -L, L, L, L, diff --git a/ocaml/examples/guestfs-ocaml.pod b/ocaml/examples/guestfs-ocaml.pod index 2bbe1fdb0..a7a810c44 100644 --- a/ocaml/examples/guestfs-ocaml.pod +++ b/ocaml/examples/guestfs-ocaml.pod @@ -82,7 +82,6 @@ function that you called. L, L, L, -L, L, L, L, diff --git a/perl/examples/guestfs-perl.pod b/perl/examples/guestfs-perl.pod index 9d9f264c8..293988d37 100644 --- a/perl/examples/guestfs-perl.pod +++ b/perl/examples/guestfs-perl.pod @@ -41,7 +41,6 @@ L, L, L, L, -L, L, L, L, diff --git a/python/examples/guestfs-python.pod b/python/examples/guestfs-python.pod index 93de5c903..57c7c1c80 100644 --- a/python/examples/guestfs-python.pod +++ b/python/examples/guestfs-python.pod @@ -65,7 +65,6 @@ You can use it like this: L, L, L, -L, L, L, L, diff --git a/ruby/examples/guestfs-ruby.pod b/ruby/examples/guestfs-ruby.pod index b6e0efc38..6154608d1 100644 --- a/ruby/examples/guestfs-ruby.pod +++ b/ruby/examples/guestfs-ruby.pod @@ -36,7 +36,6 @@ string). L, L, L, -L, L, L, L,