From acefa2375868f56fa95e45ddda2df9139cda02d3 Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Mon, 22 Feb 2021 10:08:47 +0000 Subject: [PATCH] diff: Don't try to call unlink(NULL) on certain error paths. Actual bug found by GCC analyzer. --- diff/diff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/diff/diff.c b/diff/diff.c index d5e541151..e440d1a1f 100644 --- a/diff/diff.c +++ b/diff/diff.c @@ -773,8 +773,8 @@ diff (struct file *file1, guestfs_h *g1, struct file *file2, guestfs_h *g2) printf ("@@ %s @@\n", _("End of diff")); out: - unlink (tmpda); - unlink (tmpdb); + if (tmpda) unlink (tmpda); + if (tmpdb) unlink (tmpdb); rmdir (tmpd); }