mirrors/libguestfs
1
0
Fork 0
mirror of https://github.com/libguestfs/libguestfs.git synced 2026-03-21 22:53:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

valgrind: Don't use "nested" run scripts.

Browse Source 
When TESTS_ENVIRONMENT already uses 'run', the VG variable
doesn't also need to use 'run'.

The specific problem is that if the command contains newlines
then double invocations of the 'run' script fails (in libtool).
ie the following command failed causing errors in check-valgrind:

  $VG virt-builder phony-fedora \
      -v --no-cache --no-check-signature $no_network \
  ...
      --write '/etc/append4:line1
  ' \
  ...
This commit is contained in:
Richard W.M. Jones
2016-10-11 18:02:16 +01:00
parent 9bcdffc2bb
commit d6c42a6c58
20 changed files with 20 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
rescue/Makefile.am
View File

@@ -93,4 +93,4 @@ TESTS += \
endif ENABLE_APPLIANCE
check-valgrind:
$(MAKE) TESTS="test-virt-rescue-suggest.sh" VG="$(top_builddir)/run @VG@" check
$(MAKE) TESTS="test-virt-rescue-suggest.sh" VG="@VG@" check