mirrors/libguestfs
1
0
Fork 0
mirror of https://github.com/libguestfs/libguestfs.git synced 2026-03-21 22:53:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

ocaml/guestfs-c.c: Avoid bogus -fanalyzer warning

Browse Source 
This warning is bogus, caused by the analyzer cannot track that len ==
0 if roots == NULL.  I just changed the code to make it easier to
analyze, this doesn't fix any real bug.

guestfs-c.c: In function 'guestfs_finalize':
guestfs-c.c:85:9: error: dereference of NULL '0B' [CWE-476] [-Werror=analyzer-null-dereference]
   85 |         caml_remove_generational_global_root (roots[i]);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This commit is contained in:
Richard W.M. Jones
2021-09-07 16:44:14 +01:00
parent a7245fba7a
commit ea04d6b878
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ocaml/guestfs-c.c
View File

@@ -79,7 +79,7 @@ guestfs_finalize (value gv)
guestfs_close (g);
/* Now unregister the global roots. */
if (len > 0) {
if (roots && len > 0) {
size_t i;
for (i = 0; i < len; ++i) {
caml_remove_generational_global_root (roots[i]);