From effcb99f838da1c4830b4a6b0cc4394b904376f2 Mon Sep 17 00:00:00 2001 From: Olaf Hering Date: Fri, 28 Mar 2014 10:44:16 +0100 Subject: [PATCH] builder: Link virt-index-validate with gnulib. [Gnulib tries to replace getopt because of the bug shown below. However because -lgnu was not used in the Makefile, the replacement failed. -- RWMJ] from config.log: /* This code dumps core on glibc 2.14. */ { static char program[] = "program"; static char w[] = "-W"; static char dummy[] = "dummy"; char *argv[] = { program, w, dummy, NULL }; optind = opterr = 1; if (getopt (3, argv, "W;") != 'W') result |= 64; } gdb --quiet --readnow ./conftest -ex r -ex bt -ex detach -ex q Reading symbols from /usr/src/packages/BUILD/libguestfs-1.26.0/conftest...expanding to full symbols...done. Starting program: /usr/src/packages/BUILD/libguestfs-1.26.0/conftest Missing separate debuginfo for /lib64/ld-linux-x86-64.so.2 Try: zypper install -C "debuginfo(build-id)=5d1a12e6f0e95331cc4e39df74ecbd5adb76a1f7" Missing separate debuginfo for /lib64/libc.so.6 Try: zypper install -C "debuginfo(build-id)=a06caa12df8f953a453befa827c3145adaf6269a" main(323) result 0 main(344) result 0 main(357) result 0 main(370) result 0 Program received signal SIGSEGV, Segmentation fault. 0x00007ffff7b2dbf8 in _getopt_internal_r () from /lib64/libc.so.6 Detaching from program: /usr/src/packages/BUILD/libguestfs-1.26.0/conftest, process 31042 This change actually fixes build for me on sles11sp3 and 11.4. --- builder/Makefile.am | 3 +++ 1 file changed, 3 insertions(+) diff --git a/builder/Makefile.am b/builder/Makefile.am index 471a53a01..cf6b13417 100644 --- a/builder/Makefile.am +++ b/builder/Makefile.am @@ -278,6 +278,9 @@ virt_index_validate_SOURCES = \ virt_index_validate_CPPFLAGS = \ -DLOCALEBASEDIR=\""$(datadir)/locale"\" +virt_index_validate_LDADD = \ + -L../gnulib/lib/.libs -lgnu + man_MANS += virt-index-validate.1 noinst_DATA += $(top_builddir)/html/virt-index-validate.1.html