From fbf10d7f682178a6a71cfa8dbac2acd23f869597 Mon Sep 17 00:00:00 2001
From: "Richard W.M. Jones" <rjones@redhat.com>
Date: Thu, 8 Mar 2012 11:41:13 +0000
Subject: [PATCH] daemon: upload: Close fd along error path (found by
 Coverity).

Error: RESOURCE_LEAK:
/builddir/build/BUILD/libguestfs-1.16.5/daemon/upload.c:225: open_fn: Calling opening function "open".
/builddir/build/BUILD/libguestfs-1.16.5/daemon/upload.c:225: var_assign: Assigning: "fd" =  handle returned from "open(filename, 0)".
/builddir/build/BUILD/libguestfs-1.16.5/daemon/upload.c:233: noescape: Variable "fd" is not closed or saved in function "lseek".
/builddir/build/BUILD/libguestfs-1.16.5/daemon/upload.c:235: leaked_handle: Handle variable "fd" going out of scope leaks the handle.
---
 daemon/upload.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/daemon/upload.c b/daemon/upload.c
index dffe41190..2f3e5b5b7 100644
--- a/daemon/upload.c
+++ b/daemon/upload.c
@@ -232,6 +232,7 @@ do_download_offset (const char *filename, int64_t offset, int64_t size)
   if (offset) {
     if (lseek (fd, offset, SEEK_SET) == -1) {
       reply_with_perror ("lseek: %s", filename);
+      close (fd);
       return -1;
     }
   }