Commit Graph

29 Commits

Author SHA1 Message Date
Richard W.M. Jones
ededdce3c1 autogen: Fix detection of gnulib submodule status.
Don't require a rebuild every time the common module changes status.
2019-11-13 12:49:54 +00:00
Richard W.M. Jones
f161c9ea57 Rename src/ to lib/ 2017-01-26 15:05:46 +00:00
Richard W.M. Jones
dc1d0880b0 tests: Move the tests/data and tests/guests directories to test-data.
Create a new top-level directory called test-data, which will carry
all the test data which is large and/or shared between multiple tests.

There are actually several new subdirectories created:

test-data/binaries: The pre-built binary and library files for random
architectures that we use to test various architecture detection
features (was part of tests/data).

test-data/blank-disks: The blank disks which are used for disk format
detection (was part of tests/data).

test-data/files: Other miscellaneous test files from tests/data that
are not included in the above.

test-data/phony-guests: The phony guests (was tests/guests).

test-data: The top-level directory builds the 'test.iso' image file
that is used for testing the C API and in miscellaneous other tests.
2015-10-30 16:07:32 +00:00
Richard W.M. Jones
77d08060b4 syntax-check: Ignore more syntax-check problems.
For some reason maint.mk doesn't process all of these regexps,
or perhaps the regexps are not well-formed.
2013-05-24 14:20:45 +01:00
Jim Meyering
176bd182d3 maint: remove a subsumed syntax-check rule
* cfg.mk (sc_prohibit_trailing_blank_lines): Remove rule.  It is now
subsumed by the much more efficient sc_prohibit_empty_lines_at_EOF
rule in gnulib's maint.mk.
2012-09-17 11:05:34 +01:00
Richard W.M. Jones
3988dec9b7 syntax: Exclude examples and test program from <config.h> requirement
(thanks Jim Meyering).
2012-09-17 10:15:43 +01:00
Richard W.M. Jones
72ab351ace syntax: Allow strncpy in launch-*.c files (thanks Jim Meyering).
We use strncpy, justifiably, to copy the socket name into
the fixed length Unix domain sun_path buffer.
2012-09-17 10:13:16 +01:00
Richard W.M. Jones
369709177e syntax: Exclude examples from strcmp and strncmp checks (thanks Jim Meyering). 2012-09-17 10:11:13 +01:00
Richard W.M. Jones
552576c7f9 syntax: Ignore documentation when testing for magic number exit() calls (thanks Jim Meyering). 2012-09-17 10:07:32 +01:00
Richard W.M. Jones
2100ba14fb syntax: Exclude PO files from doubled words test (thanks Jim Meyering). 2012-09-17 10:07:31 +01:00
Richard W.M. Jones
cb13ffe190 syntax: Remove definitions of O_CLOEXEC, except in examples (thanks Jim Meyering).
The gnulib <fcntl.h> replacement header will now define this symbol if
it's not defined already.
2012-09-17 10:07:31 +01:00
Richard W.M. Jones
2337b9ccd7 syntax: Exclude period in error message checks from PHP programs (thanks: Jim Meyering). 2012-09-17 10:07:31 +01:00
Richard W.M. Jones
fbdcfe2b77 syntax: Disable cast arg to free test (thanks Jim Meyering). 2012-09-17 10:07:31 +01:00
Richard W.M. Jones
b95fff1357 syntax: Exclude certain files from bindtextdomain test (thanks Jim Meyering). 2012-09-17 10:07:31 +01:00
Richard W.M. Jones
ae137124ca syntax: Remove test for TAB indentation.
Nothing particularly wrong with using TABs for indentation,
and this test also has a lot of false positives.
2012-09-15 11:54:17 +01:00
Richard Jones
3d994f3d8e syntax: Replace _prohibit_regexp with _sc_search_regexp. 2010-09-10 22:51:39 +01:00
Jim Meyering
9e5fabbe01 accommodate leading "+" in git submodule output
* cfg.mk (_submodule_hash): Also filter out "+".
* autogen.sh: Likewise.
2009-12-07 11:13:12 +00:00
Jim Meyering
e1b48287eb build: correct sed transformation to work also on .git-module-status
My patch was wrong.
I kept the sed transformation the same in the two places,
but it wasn't strict enough to also work on the file contents.
Sorry about that.  This fixes it.

>From 93927cc7b9f63c414e5bfeb7eba393fde3295601 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Fri, 20 Nov 2009 16:23:17 +0100
Subject: [PATCH libguestfs] build: correct sed transformation to work also on .git-module-status

* autogen.sh: Use a more strict sed transformation so it works also
on the contents of .git-module-status, which has no prefix.
* cfg.mk (_submodule_hash): Use a stricter sed regexp.
2009-11-20 15:40:19 +00:00
Jim Meyering
0e1e0f10df tests: enable strcmp-related syntax-check tests
* cfg.mk (local-checks-to-skip): Don't skip these checks:
sc_prohibit_strcmp_and_strncmp, sc_prohibit_strcmp.
2009-11-09 22:42:02 +01:00
Jim Meyering
6a14f1c250 avoid use of all ctype macros
* cfg.mk (disable_temporarily): Don't disable sc_avoid_ctype_macros.
* fish/tilde.c: Remove unnecessary inclusion of ctype.h.
* bootstrap: Add gnulib's c-ctype module to the list.
* daemon/m4/gnulib-cache.m4: Likewise.
* daemon/ext2.c: Include "c-ctype.h", not <ctype.h>.
Use c_isspace, etc, rather than isspace.
* daemon/guestfsd.c: Likewise.
* daemon/lvm.c: Likewise.
* daemon/proto.c: Likewise.
* fish/fish.c: Likewise.
* fish/tilde.c: Likewise.
* src/generator.ml: Likewise.
* src/guestfs.c: Likewise.
* examples/to-xml.c: Likewise.
* examples/Makefile.am (to_xml_CPPFLAGS): Add -I$(top_srcdir)/gnulib/lib
so inclusion of "c-ctype.h" works.
(to_xml_CPPFLAGS): Rename from to_xml_CFLAGS.
2009-09-24 11:00:44 +02:00
Jim Meyering
0ca36888c6 maint: prune dead wood from list of skipped syntax-check rules
* cfg.mk (local-checks-to-skip): Remove now-passing and
no-longer-relevant rule names.
2009-09-24 11:00:44 +02:00
Jim Meyering
0c463dd0aa build: remove trailing blank lines; enable the syntax-check rule
* cfg.mk (disable_temporarily): Remove sc_prohibit_trailing_blank_lines.
* appliance/Makefile.am: Remove trailing blank line(s).
* appliance/debian/modules/y0_install-guestfsd: Likewise.
* appliance/make.sh.in: Likewise.
* appliance/packagelist.in: Likewise.
* appliance/update.sh.in: Likewise.
* haskell/run-bindtests: Likewise.
* ocaml/run-bindtests: Likewise.
* python/run-python-tests: Likewise.
* recipes/squashfs.example: Likewise.
* ruby/run-ruby-tests: Likewise.
2009-08-04 14:47:09 +02:00
Jim Meyering
3625b0198c build: exempt symlinks from trailing-blank-line prohibition
* cfg.mk (sc_prohibit_trailing_blank_lines): Exempt symlinks.
2009-08-04 14:47:09 +02:00
Jim Meyering
a4c544ef12 build: enable syntax-check: TAB-only indentation in Makefiles
* cfg.mk (disable_temporarily): Remove sc_makefile_TAB_only_indentation.
2009-08-04 14:47:09 +02:00
Jim Meyering
8ae7e1057f build: remove trailing blanks, enable syntax-check
* regressions/test-cancellation-download-librarycancels.sh:
* src/generator.ml:
* cfg.mk (disable_temporarily): Remove sc_trailing_blank.
* .x-sc_trailing_blank: New file.
2009-08-04 14:47:09 +02:00
Jim Meyering
4c2c2793ba Document and enforce the new spaces-only indentation policy.
* cfg.mk (disable_temporarily): Remove sc_TAB_in_indentation,
to enable the "make syntax-check" that enforces this.
* .x-sc_TAB_in_indentation: New file.  Exceptions.
* HACKING: Document the policy, with tips on how to conform.
2009-08-03 18:05:17 +02:00
Jim Meyering
58e7e42033 build: reenable "syntax-check" rule: sc_const_long_option
* cfg.mk (disable_temporarily): Remove sc_const_long_option.
* daemon/guestfsd.c (main): Declare long_options to be "const".
* fish/fish.c (main): Likewise.
* test-tool/test-tool.c (main): Likewise.
2009-08-03 15:14:31 +02:00
Jim Meyering
a3cceb6f1c build: temporarily disable failing "syntax-check" rules
* cfg.mk (disable_temporarily): Define.
2009-08-03 15:14:31 +02:00
Jim Meyering
480a489ee4 maint: use a git submodule for gnulib
* .gitmodules: New file, to track gnulib.
* .gnulib: Submodule directory.
* Makefile.am (EXTRA_DIST): Don't list config.rpath or
gitlog-to-changelog.
* autogen.sh: Adapt to use the new submodule.
* cfg.mk: New file.
(SUBDIRS): Add gnulib/lib and gnulib/tests.
(dist-hook): Reflect new location of getlog-to-changelog.
* configure.ac: Set build-aux/ as AUX_DIR.
Invoke gl_EARLY and gl_INIT.
(AC_CONFIG_FILES): Add gnulib/lib/Makefile and gnulib/tests/Makefile.
2009-08-03 15:14:30 +02:00