mirrors/libguestfs
1
0
Fork 0
mirror of https://github.com/libguestfs/libguestfs.git synced 2026-03-22 07:03:38 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,636 Commits 79 Branches 1,138 Tags
de7ef2a0fdcbcddfd35ecb8ee2804e1ca0968454
Commit Graph

30 Commits

Author SHA1 Message Date
Jim Meyering
c372c7c23a maint: use EXIT_SUCCESS and EXIT_FAILURE, not 0 and 1 to exit 
Convert all uses automatically, via these two commands:
git grep -l '\<exit *(1)' \
  | grep -vEf .x-sc_prohibit_magic_number_exit \
  | xargs --no-run-if-empty \
    perl -pi -e 's/\b(exit ?)\(1\)/$1(EXIT_FAILURE)/'
git grep -l '\<exit *(0)' \
  | grep -vEf .x-sc_prohibit_magic_number_exit \
  | xargs --no-run-if-empty \
  perl -pi -e 's/\b(exit ?)\(0\)/$1(EXIT_SUCCESS)/'
* .x-sc_prohibit_magic_number_exit: New file.

Edit (RWMJ): Don't change Java code.
 2009-11-20 12:14:14 +00:00
Matthew Booth
c477e2fb78 build: Fix inter-directory dependencies 
This change adds an explicit dependency on generator.ml for every file it
generates, except java files. Java is left for another time because it's
considerably trickier.

It also adds a build rule for src/libguestfs.la so it can be rebuilt as required
from other directories.

It does this by creating a top level make file, subdir-rules.mk, which can be
included from sub-directories. sub-directories need to define 'generator_built'
to include local files which are built by generator.ml, and they will be updated
automatically.

This fixes parallel make, and will automatically re-create generated files when
make is run from any directory.

It also fixes the problem which efad4f53 was targetting. Specifically,
src/guestfs_protocol.(c|h) had an erroneous dependency on stamp-generator, and
therefore generator.ml, despite not being directly created by it. This caused
them to be recreated every time generator.ml ran rather than only when
src/guestfs_protocol.x was updated, which cascaded into a daemon and therefore
appliance update.

This patch also changes the contents of the distribution tarball by including
files created by rpcgen.
 2009-11-19 16:40:22 +00:00
Richard Jones
ae4589f17b examples: Don't use STREQ etc in the to-xml.c example. 2009-11-10 17:09:54 +00:00
Jim Meyering
9a8889e4d0 use STREQ, not strcmp: part 1 
git grep -l 'strcmp *([^=]*== *0'|xargs \
  perl -pi -e 's/\bstrcmp( *\(.*?\)) *== *0/STREQ$1/g'
 2009-11-09 22:34:16 +01:00
Jim Meyering
3e70b34eed change strncmp() == 0 to STREQLEN() 
git grep -l 'strncmp *([^=]*== *0'|xargs \
  perl -pi -e 's/\bstrncmp( *\(.*?\)) *== *0\b/STREQLEN$1/g'
 2009-11-09 22:34:16 +01:00
Jim Meyering
627f89351d change strncmp(...) != 0 to STRNEQLEN(...) 
git grep -l 'strncmp *([^=]*!= *0'|xargs \
  perl -pi -e 's/\bstrncmp( *\(.*?\)) *!= *0/STRNEQLEN$1/g'
 2009-11-09 22:34:16 +01:00
Richard Jones
00425c073e examples/to-xml.c: Don't depend on Gnulib function. 
Since this program is just an example, it shouldn't require
the Gnulib c-ctype functions.
 2009-11-02 16:37:51 +00:00
Jim Meyering
6a14f1c250 avoid use of all ctype macros 
* cfg.mk (disable_temporarily): Don't disable sc_avoid_ctype_macros.
* fish/tilde.c: Remove unnecessary inclusion of ctype.h.
* bootstrap: Add gnulib's c-ctype module to the list.
* daemon/m4/gnulib-cache.m4: Likewise.
* daemon/ext2.c: Include "c-ctype.h", not <ctype.h>.
Use c_isspace, etc, rather than isspace.
* daemon/guestfsd.c: Likewise.
* daemon/lvm.c: Likewise.
* daemon/proto.c: Likewise.
* fish/fish.c: Likewise.
* fish/tilde.c: Likewise.
* src/generator.ml: Likewise.
* src/guestfs.c: Likewise.
* examples/to-xml.c: Likewise.
* examples/Makefile.am (to_xml_CPPFLAGS): Add -I$(top_srcdir)/gnulib/lib
so inclusion of "c-ctype.h" works.
(to_xml_CPPFLAGS): Rename from to_xml_CFLAGS.
 2009-09-24 11:00:44 +02:00
Richard Jones
8869adf1e8 Remove guestfs_wait_ready (turn it into a no-op). 
This commit changes guestfs_launch so that it both launches
the appliance and waits until it is ready (ie. the daemon communicates
back to us).

Since we removed the pretence that we could implement a low-level
asynchronous API, the need to call launch() followed by wait_ready()
has looked a bit silly.

Now guestfs_wait_ready() is basically a no-op.  It is left in the
API for backwards compatibility.  Any calls to guestfs_wait_ready()
can be removed from client code.
 2009-09-21 12:01:51 +01:00
Jim Meyering
2f1a50d816 Convert all TABs-as-indentation to spaces. 
Do it by running this command:
[exempted files are matched via .x-sc_TAB_in_indentation]

  git ls-files \
    | pcregrep -vf .x-sc_TAB_in_indentation \
    | xargs pcregrep -l '^ *\t' \
    | xargs perl -MText::Tabs -ni -le \
      '$m=/^( *\t[ \t]*)(.*)/; print $m ? expand($1) . $2 : $_'
 2009-08-03 17:17:57 +02:00
Jim Meyering
5fa153b186 Guard #inclusion of config.h in examples. 
* examples/hello.c [HAVE_CONFIG_H]: Include <config.h> conditionally.
* examples/to-xml.c: Likewise.
 2009-08-03 15:21:44 +02:00
Jim Meyering
3572996364 always include <config.h> 
* ocaml/guestfs_c.c: Include <config.h>.
* examples/to-xml.c: Likewise.
* examples/hello.c: Likewise.
 2009-08-03 15:14:30 +02:00
Matthew Booth
349814e9d9 Make it possible to build in a separate directory 
This patch allows you to do:
mkdir build
cd build
../configure ...
make

This will output all generated files to the build directory. Given that
autogen automatically runs configure, you can also do:

BUILDDIR=./build ./autogen.sh

which will do the right thing.

Also:

* Fix a dependency bug which means that guestfs_protocol.h
  isn't automatically rebuilt.
* Re-running autogen.sh with no arguments won't blow away your previous
  configure arguments.
 2009-07-03 16:16:51 +01:00
Richard W.M. Jones
a1e8cdf2a2 Move the appliance and build scripts into new appliance/ subdirectory. 2009-05-28 13:00:31 +01:00
Jim Meyering
41b959fd9b build: don't tell "make clean" to remove my '~' backup files 
Hi Rich,

automake's policy on what to remove via "make clean" is reasonable:
if running build rules creates it, then "make clean" can and should remove it.
However, even if build rules happen
to create backup files, please remove only the specific ones
they can create, not all of the ones in a directory.  Just in case
someone relies on those and expect them to hang around...

>From 1e8be391ac17b4ddcf9671e8413d2660844e6993 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Thu, 30 Apr 2009 15:47:52 +0200
Subject: [PATCH] build: don't tell "make clean" to remove my '~' backup files

* Makefile.am (CLEANFILES): Don't remove '~' backup files.
* daemon/Makefile.am: Ditto.
* examples/Makefile.am: Ditto.
* fish/Makefile.am: Ditto.
* images/Makefile.am: Ditto.
* inspector/Makefile.am: Ditto.
* java/Makefile.am: Ditto.
* ocaml/Makefile.am: Ditto.
* ocaml/examples/Makefile.am: Ditto.
* perl/Makefile.am: Ditto.
* python/Makefile.am: Ditto.
* ruby/Makefile.am: Ditto.
* src/Makefile.am: Ditto.
 2009-04-30 16:13:06 +01:00
Richard Jones
0725678827 Add support for ext4 to examples/to-xml.c 2009-04-24 19:03:18 +01:00
Richard Jones
92c2c33d61 Fix infinite loop encountered when reading Windows disk in example program. 2009-04-22 15:27:42 +01:00
Richard Jones
4905c1ae8b Show byte sizes in example. 2009-04-15 17:58:35 +01:00
Richard Jones
3e9f98d0f7 Display ext2/3 details, and some bug fixes. 2009-04-15 14:19:03 +01:00
Richard Jones
7fe2b338e4 Added to-xml program. 2009-04-15 12:34:18 +01:00
Richard Jones
197f0ceeac Remove 'df' program from examples - didn't ever work. 2009-04-15 10:52:37 +01:00
Richard Jones
d19ceb226c Remove *~ files when doing 'make clean'. 2009-04-09 19:47:22 +01:00
Richard Jones
ff1f39794b Make the partition configurable. 2009-04-03 19:16:27 +01:00
Richard Jones
e83181345f Added README file for examples directory. 2009-04-03 19:13:48 +01:00
Richard Jones
3906e4ff91 No verbose. User can enable by setting LIBGUESTFS_DEBUG=1 if they want. 2009-04-03 19:11:44 +01:00
Richard Jones
40ca9a5782 Daemon and library are mostly talking to each other now. 2009-04-03 17:24:35 +01:00
Richard Jones
56465eb694 Correctly handle the case when select runs out of filehandles. 2009-04-02 20:55:41 +01:00
Richard Jones
88f69eb031 Guest boots, and basic select/callbacks work. 2009-04-02 20:07:21 +01:00
Richard Jones
1a2deb2bcd Moved .cvsignore -> .gitignore. 2009-04-01 12:53:40 +01:00
rjones
b6233d1fff Running qemu as a subprocess. 2009-03-03 15:35:50 +00:00