Files
libguestfs/daemon/luks.c
Richard W.M. Jones 07c496c53c Use less stack.
GCC has two warnings related to large stack frames.  We were already
using the -Wframe-larger-than warning, but this reduces the threshold
from 10000 to 5000 bytes.

However that warning only covers the static part of frames (not
alloca).  So this change also enables -Wstack-usage=10000 which covers
both the static and dynamic usage (alloca and variable length arrays).

Multiple changes are made throughout the code to reduce frames to fit
within these new limits.

Note that stack allocation of large strings can be a security issue.
For example, we had code like:

 size_t len = strlen (fs->windows_systemroot) + 64;
 char software[len];
 snprintf (software, len, "%s/system32/config/software",
           fs->windows_systemroot);

where fs->windows_systemroot is guest controlled.  It's not clear what
the effects might be of allowing the guest to allocate potentially
very large stack frames, but at best it allows the guest to cause
libguestfs to segfault.  It turns out we are very lucky that
fs->windows_systemroot cannot be set arbitrarily large (see checks in
is_systemroot).

This commit changes those to large heap allocations instead.
2016-03-07 17:36:24 +00:00

297 lines
6.5 KiB
C

/* libguestfs - the guestfsd daemon
* Copyright (C) 2010 Red Hat Inc.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
#include <config.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include "daemon.h"
#include "actions.h"
#include "optgroups.h"
#define MAX_ARGS 64
GUESTFSD_EXT_CMD(str_cryptsetup, cryptsetup);
int
optgroup_luks_available (void)
{
return prog_exists (str_cryptsetup);
}
/* Callers must also call remove_temp (tempfile). */
static char *
write_key_to_temp (const char *key)
{
char *tempfile;
int fd;
size_t len;
tempfile = strdup ("/tmp/luksXXXXXX");
if (!tempfile) {
reply_with_perror ("strdup");
return NULL;
}
fd = mkstemp (tempfile);
if (fd == -1) {
reply_with_perror ("mkstemp");
goto error;
}
len = strlen (key);
if (xwrite (fd, key, len) == -1) {
reply_with_perror ("write");
close (fd);
goto error;
}
if (close (fd) == -1) {
reply_with_perror ("close");
goto error;
}
return tempfile;
error:
unlink (tempfile);
free (tempfile);
return NULL;
}
static void
remove_temp (char *tempfile)
{
unlink (tempfile);
free (tempfile);
}
static int
luks_open (const char *device, const char *key, const char *mapname,
int readonly)
{
/* Sanity check: /dev/mapper/mapname must not exist already. Note
* that the device-mapper control device (/dev/mapper/control) is
* always there, so you can't ever have mapname == "control".
*/
CLEANUP_FREE char *devmapper = NULL;
if (asprintf (&devmapper, "/dev/mapper/%s", mapname) == -1) {
reply_with_perror ("asprintf");
return -1;
}
if (access (devmapper, F_OK) == 0) {
reply_with_error ("%s: device already exists", devmapper);
return -1;
}
char *tempfile = write_key_to_temp (key);
if (!tempfile)
return -1;
const char *argv[MAX_ARGS];
size_t i = 0;
ADD_ARG (argv, i, str_cryptsetup);
ADD_ARG (argv, i, "-d");
ADD_ARG (argv, i, tempfile);
if (readonly) ADD_ARG (argv, i, "--readonly");
ADD_ARG (argv, i, "luksOpen");
ADD_ARG (argv, i, device);
ADD_ARG (argv, i, mapname);
ADD_ARG (argv, i, NULL);
CLEANUP_FREE char *err = NULL;
int r = commandv (NULL, &err, (const char * const *) argv);
remove_temp (tempfile);
if (r == -1) {
reply_with_error ("%s", err);
return -1;
}
udev_settle ();
return 0;
}
int
do_luks_open (const char *device, const char *key, const char *mapname)
{
return luks_open (device, key, mapname, 0);
}
int
do_luks_open_ro (const char *device, const char *key, const char *mapname)
{
return luks_open (device, key, mapname, 1);
}
int
do_luks_close (const char *device)
{
/* Must be /dev/mapper/... */
if (! STRPREFIX (device, "/dev/mapper/")) {
reply_with_error ("luks_close: you must call this on the /dev/mapper device created by luks_open");
return -1;
}
const char *mapname = &device[12];
CLEANUP_FREE char *err = NULL;
int r = command (NULL, &err, str_cryptsetup, "luksClose", mapname, NULL);
if (r == -1) {
reply_with_error ("%s", err);
return -1;
}
udev_settle ();
return 0;
}
static int
luks_format (const char *device, const char *key, int keyslot,
const char *cipher)
{
char *tempfile = write_key_to_temp (key);
if (!tempfile)
return -1;
const char *argv[MAX_ARGS];
char keyslot_s[16];
size_t i = 0;
ADD_ARG (argv, i, str_cryptsetup);
ADD_ARG (argv, i, "-q");
if (cipher) {
ADD_ARG (argv, i, "--cipher");
ADD_ARG (argv, i, cipher);
}
ADD_ARG (argv, i, "--key-slot");
snprintf (keyslot_s, sizeof keyslot_s, "%d", keyslot);
ADD_ARG (argv, i, keyslot_s);
ADD_ARG (argv, i, "luksFormat");
ADD_ARG (argv, i, device);
ADD_ARG (argv, i, tempfile);
ADD_ARG (argv, i, NULL);
CLEANUP_FREE char *err = NULL;
int r = commandv (NULL, &err, (const char * const *) argv);
remove_temp (tempfile);
if (r == -1) {
reply_with_error ("%s", err);
return -1;
}
udev_settle ();
return 0;
}
int
do_luks_format (const char *device, const char *key, int keyslot)
{
return luks_format (device, key, keyslot, NULL);
}
int
do_luks_format_cipher (const char *device, const char *key, int keyslot,
const char *cipher)
{
return luks_format (device, key, keyslot, cipher);
}
int
do_luks_add_key (const char *device, const char *key, const char *newkey,
int keyslot)
{
char *keyfile = write_key_to_temp (key);
if (!keyfile)
return -1;
char *newkeyfile = write_key_to_temp (newkey);
if (!newkeyfile) {
remove_temp (keyfile);
return -1;
}
const char *argv[MAX_ARGS];
char keyslot_s[16];
size_t i = 0;
ADD_ARG (argv, i, str_cryptsetup);
ADD_ARG (argv, i, "-q");
ADD_ARG (argv, i, "-d");
ADD_ARG (argv, i, keyfile);
ADD_ARG (argv, i, "--key-slot");
snprintf (keyslot_s, sizeof keyslot_s, "%d", keyslot);
ADD_ARG (argv, i, keyslot_s);
ADD_ARG (argv, i, "luksAddKey");
ADD_ARG (argv, i, device);
ADD_ARG (argv, i, newkeyfile);
ADD_ARG (argv, i, NULL);
CLEANUP_FREE char *err = NULL;
int r = commandv (NULL, &err, (const char * const *) argv);
remove_temp (keyfile);
remove_temp (newkeyfile);
if (r == -1) {
reply_with_error ("%s", err);
return -1;
}
return 0;
}
int
do_luks_kill_slot (const char *device, const char *key, int keyslot)
{
char *tempfile = write_key_to_temp (key);
if (!tempfile)
return -1;
const char *argv[MAX_ARGS];
char keyslot_s[16];
size_t i = 0;
ADD_ARG (argv, i, str_cryptsetup);
ADD_ARG (argv, i, "-q");
ADD_ARG (argv, i, "-d");
ADD_ARG (argv, i, tempfile);
ADD_ARG (argv, i, "luksKillSlot");
ADD_ARG (argv, i, device);
snprintf (keyslot_s, sizeof keyslot_s, "%d", keyslot);
ADD_ARG (argv, i, keyslot_s);
ADD_ARG (argv, i, NULL);
CLEANUP_FREE char *err = NULL;
int r = commandv (NULL, &err, (const char * const *) argv);
remove_temp (tempfile);
if (r == -1) {
reply_with_error ("%s", err);
return -1;
}
return 0;
}