mirrors/libguestfs
1
0
Fork 0
mirror of https://github.com/libguestfs/libguestfs.git synced 2026-03-21 22:53:37 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
4ff4e123dc68bcadec168185b21fef80f3c4cdc5
libguestfs/daemon
History
Laszlo Ersek 7b5e00f036 daemon/listfs: don't call "sgdisk -i" on bogus MBR partition table entry 
The "is_partition_can_hold_filesystem" function calls
"Parted.part_get_gpt_type" on the partition if:
- the partition table type is GPT,
- or the partition table type is MBR, and the partition is primary or
  logical.

The one entry in the fake MBR partition table described in the previous
patch passes the second branch of this check, therefore
"Parted.part_get_gpt_type" is reached, and it invokes "sgdisk -i 1" on the
disk.

Surprisingly (not), while "sgdisk -i" copes fine with valid MBR partition
tables, it chokes on the fake one. The output does not contain the
"Partition GUID code" line, and so "sgdisk_info_extract_field" throws an
exception.

Prevent calling "Parted.part_get_gpt_type" on a bogus MBR partition table,
similarly to the "extended entry in MBR partition table" case; the
difference is that the bogus primary entry, unlike a valid extended entry,
*can* hold a filesystem.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1931821
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Acked-by: Richard W.M. Jones <rjones@redhat.com>
Message-Id: <20211125094954.9713-6-lersek@redhat.com>
2021-12-09 13:54:15 +00:00
..
9p.c
daemon/9p: fix wrong pathname in error message
2021-12-09 13:54:15 +00:00
acl.c
…
augeas.c
appliance: remove custom Shadow augeas lens
2019-05-30 09:12:32 +02:00
available.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
base64.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
blkdiscard.c
…
blkid.c
daemon: Reimplement ‘vfs_type’ API in OCaml.
2017-07-27 22:31:22 +01:00
blkid.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
blockdev.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
btrfs.c
daemon/btrfs.c: Ignore mkfs.btrfs allocstart option.
2021-03-22 14:26:57 +00:00
btrfs.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
callbacks.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
cap.c
…
checksum.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
chroot.ml
daemon: chroot: Fix long-standing possible deadlock.
2021-03-26 16:06:03 +00:00
chroot.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
cleanups.c
daemon: Link guestfsd with libutils.
2017-07-10 17:01:59 +01:00
cmp.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
command.c
build: Remove gnulib.
2021-04-08 11:36:40 +01:00
command.h
daemon: Split out command* functions and CLEANUP_* macros.
2016-01-22 09:12:17 +00:00
compress.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
copy.c
Use 'const' for stack integers where possible.
2016-07-26 10:43:45 +01:00
cpio.c
daemon: remove unused include
2019-11-28 13:09:21 +01:00
cpmv.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
cryptsetup.ml
New APIs: cryptsetup-open and cryptsetup-close.
2020-10-12 10:44:08 +01:00
daemon_config.ml.in
daemon: build also without Hivex.OPEN_UNSAFE (RHBZ#1493048)
2018-02-06 17:27:23 +01:00
daemon_config.mli
daemon: build also without Hivex.OPEN_UNSAFE (RHBZ#1493048)
2018-02-06 17:27:23 +01:00
daemon_utils_tests.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
daemon-c.c
daemon/daemon-c.c: Fix whitespace.
2021-03-16 11:24:37 +00:00
daemon-c.h
generator: daemon: Implement RStringList (RMountable, _) and RHashtable (RPlainString, RMountable, _).
2017-09-16 22:27:16 +01:00
daemon-utils-tests-stubs.c
daemon: tests: Compile tests with compiler warnings.
2018-01-09 12:17:53 +00:00
daemon.h
daemon: Add filter_list utility function.
2020-03-30 10:40:13 +01:00
daemon.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
daemon.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
dd.c
daemon: Refine check for Device and Dev_or_Path parameters (RHBZ#1477623).
2017-08-08 17:50:23 +01:00
debug-bmap.c
…
debug.c
daemon/command.c daemon/debug.c df/main.c: Ignore bogus GCC analyzer warnings
2021-02-22 10:37:49 +00:00
device-name-translation.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
devsparts.c
daemon: Don't return bogus failure from readdir.
2021-03-22 14:56:10 +00:00
devsparts.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
df.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
dir.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
dmesg.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
dropcaches.c
…
du.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
echo-daemon.c
daemon: Link guestfsd with libutils.
2017-07-10 17:01:59 +01:00
ext2.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
f2fs.c
New API: f2fs_expand
2018-04-19 11:30:29 +02:00
fallocate.c
Use 'const' for stack integers where possible.
2016-07-26 10:43:45 +01:00
file.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
file.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
filearch.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
fill.c
Use 'const' for stack integers where possible.
2016-07-26 10:43:45 +01:00
find.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
findfs.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
format.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
fs-min-size.c
Added xfs support to vfs_minimum_size.
2015-10-27 17:25:49 +00:00
fsck.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
fstrim.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
glob.c
daemon: glob: add optarg to control trailing slash for dirs
2016-02-04 11:25:56 +01:00
grep.c
…
grub.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
guestfsd.c
build: Remove gnulib.
2021-04-08 11:36:40 +01:00
guestfsd.pod
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
headtail.c
…
hexdump.c
…
hivex.c
New API: Deprecate hivex_value_utf8 and replace with hivex_value_string.
2017-09-16 22:27:16 +01:00
hotplug.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
htonl.c
…
initrd.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
inotify.c
daemon/inotify.c: Clean up error handling
2021-09-07 14:48:03 +01:00
inspect_fs_unix_fstab.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
inspect_fs_unix_fstab.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
inspect_fs_unix.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
inspect_fs_unix.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
inspect_fs_windows.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
inspect_fs_windows.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
inspect_fs.ml
inspection: More reliable detection of Linux split /usr configurations
2021-04-15 09:41:35 +01:00
inspect_fs.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
inspect_types.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
inspect_types.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
inspect_utils.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
inspect_utils.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
inspect.ml
inspection: More reliable detection of Linux split /usr configurations
2021-04-15 09:41:35 +01:00
internal.c
docs: Add internal documentation for a few daemon functions.
2016-04-12 20:59:40 +01:00
is.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
is.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
isoinfo.ml
daemon: Fix isoinfo on files
2021-05-13 09:19:31 +01:00
journal.c
…
labels.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
ldm.c
Switch from YAJL to Jansson
2018-02-12 11:24:06 +01:00
ldm.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
link.c
daemon/link.c: Fix out of memory error when reading symlinks
2021-05-13 12:04:41 +01:00
link.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
listfs.ml
daemon/listfs: don't call "sgdisk -i" on bogus MBR partition table entry
2021-12-09 13:54:15 +00:00
ls.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
luks.c
daemon/luks.c: Ignore bogus GCC -fanalyzer double-free warning
2021-09-07 14:53:06 +01:00
lvm_dm.ml
daemon: Reimplement list_dm_devices API in OCaml.
2020-10-12 10:44:29 +01:00
lvm_utils.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
lvm_utils.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
lvm-filter.c
Revert "lvm: do not pass --cache to vgscan"
2018-07-26 12:02:59 +01:00
lvm.c
daemon: lvm: Use lvcreate --yes to avoid interactive prompts.
2021-02-22 11:04:15 +00:00
lvm.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
Makefile.am
daemon_utils_tests: generalize ocaml-hivex[-devel] lookup
2021-09-09 14:52:03 +02:00
md.c
daemon: Replace "noalloc" with [@@noalloc]
2021-12-09 13:54:15 +00:00
md.ml
daemon: Replace "noalloc" with [@@noalloc]
2021-12-09 13:54:15 +00:00
mkfs.c
daemon/mkfs: disable creation of fake MBR partition table with "mkfs.fat"
2021-12-09 13:54:15 +00:00
mknod.c
Use AC_HEADER_MAJOR to find definitions of major, minor, makedev.
2017-03-03 11:32:37 +00:00
mktemp.c
…
modprobe.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
mount_utils.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
mount_utils.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
mount.c
daemon: Refine check for Device and Dev_or_Path parameters (RHBZ#1477623).
2017-08-08 17:50:23 +01:00
mount.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
mountable.c
…
mountable.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
mountable.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
ntfs.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
ntfsclone.c
Ignore completely bogus GCC 11 warnings.
2021-01-05 10:31:00 +00:00
parted.c
daemon/parted: simplify print_partition_table() prototype
2021-12-09 13:54:15 +00:00
parted.ml
daemon/parted: work around part table type misreporting by "parted"
2021-12-09 13:54:15 +00:00
pingdaemon.c
…
proto.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
readdir.c
…
realpath.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
rename.c
…
rpm-c.c
inspection: Return RPM epoch.
2021-03-27 09:31:00 +00:00
rpm.ml
inspection: Fix inspection of recent RPM guests using non-BDB.
2021-03-26 16:26:00 +00:00
rsync.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
scrub.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
selinux-relabel.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
selinux.c
daemon, lib: Replace deprecated security_context_t with char *.
2020-07-30 13:58:35 +01:00
sfdisk.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
sh.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
sleep.c
…
sleuthkit.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
squashfs.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
stat.c
daemon: Link guestfsd with libutils.
2017-07-10 17:01:59 +01:00
statvfs.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
strings.c
…
stubs-macros.h
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
swap.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
sync.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
syslinux.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
sysroot-c.c
daemon: Allow parts of the daemon and APIs to be written in OCaml.
2017-07-27 22:31:22 +01:00
sysroot.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
sysroot.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
tar.c
daemon/tar.c: Avoid bogus GCC analyzer warning.
2021-02-22 10:38:19 +00:00
truncate.c
…
tsk.c
macOS: Include <rpc/types.h> before <rpc/xdr.h>.
2018-05-15 11:15:54 +01:00
umask.c
Fix various -Wformat problems.
2015-07-02 16:08:44 +01:00
upload.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
utils-c.c
daemon: Replace "noalloc" with [@@noalloc]
2021-12-09 13:54:15 +00:00
utils.c
daemon/utils.c: Fix potential unbounded stack usage
2021-09-07 15:55:48 +01:00
utils.ml
daemon/parted: work around part table type misreporting by "parted"
2021-12-09 13:54:15 +00:00
utils.mli
daemon/parted: work around part table type misreporting by "parted"
2021-12-09 13:54:15 +00:00
utimens.c
…
utsname.c
…
uuids.c
Fix whitespace.
2015-10-05 14:28:33 +01:00
wc.c
…
xattr.c
daemon/xattr.c: Increase size of temporary buffer for %zu
2021-09-07 15:55:43 +01:00
xfs.c
daemon/xfs.c: Fix error message.
2021-03-30 12:56:58 +01:00
yara.c
daemon/yara: fix undefined behavior due to Yara 4.0 API changes
2021-12-09 13:54:15 +00:00
zero.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
zerofree.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00