mirrors/libguestfs
1
0
Fork 0
mirror of https://github.com/libguestfs/libguestfs.git synced 2026-03-21 22:53:37 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
56da6b36d3cb10711b4c6a24930e1bbc2cd5f38b
libguestfs/daemon
History
Richard W.M. Jones 56da6b36d3 daemon: btrfs: Simplify snapshot code and fix invalid memory access 
The existing code had a bug which you can demonstrate by doing:

  $ guestfish -N fs:btrfs:10G -m /dev/sda1 \
  btrfs-subvolume-create /sub :
  btrfs-subvolume-snapshot /sub /snap1 : \
  btrfs-subvolume-snapshot /sub /snap123 : \
  btrfs-subvolume-snapshot /sub /snap123456 : \
  btrfs-subvolume-show /sub
  ...
  libguestfs: error: appliance closed the connection unexpectedly.
  This usually means the libguestfs appliance crashed.

As the code for parsing the output and creating the comma-separated
list of snapshots was unncessarily complicated in the first place,
simplify it.  This also fixes the bug.

This also adds a regression test.

Thanks: Arye Yurkovsky
Link: https://lists.libguestfs.org/archives/list/guestfs@lists.libguestfs.org/thread/QV5VDHIH7WRUNAE54K6OEOKJMWL6M7EM/
2025-11-24 10:44:44 +00:00
..
9p.c
lib: Remove 9p APIs
2022-03-09 09:28:02 +00:00
acl.c
…
augeas.c
appliance: remove custom Shadow augeas lens
2019-05-30 09:12:32 +02:00
available.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
base64.c
daemon: Remove remaining uses of custom printf %Q and %R
2022-08-16 10:39:01 +01:00
blkdiscard.c
…
blkid.c
daemon: Reimplement ‘vfs_type’ API in OCaml.
2017-07-27 22:31:22 +01:00
blkid.ml
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
blockdev.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
btrfs.c
daemon: btrfs: Simplify snapshot code and fix invalid memory access
2025-11-24 10:44:44 +00:00
btrfs.ml
Update common submodule
2025-05-11 12:37:23 +01:00
callbacks.mli
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
cap.c
…
checksum.c
daemon: modernize program_of_csum() using table lookup
2025-11-20 13:11:47 +00:00
chroot.ml
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
chroot.mli
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
cleanups.c
daemon: Link guestfsd with libutils.
2017-07-10 17:01:59 +01:00
clevis-luks.c
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
cmp.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
command.c
daemon: Remove workaround for -Wanalyzer-mismatching-deallocation
2022-06-17 13:24:19 +01:00
command.h
daemon: Split out command* functions and CLEANUP_* macros.
2016-01-22 09:12:17 +00:00
compress.c
daemon: Remove remaining uses of custom printf %Q and %R
2022-08-16 10:39:01 +01:00
copy.c
Use 'const' for stack integers where possible.
2016-07-26 10:43:45 +01:00
cpio.c
daemon: Remove remaining uses of custom printf %Q and %R
2022-08-16 10:39:01 +01:00
cpmv.c
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
cryptsetup.ml
Update common submodule
2025-05-11 21:29:23 +01:00
daemon_config.ml.in
daemon: build also without Hivex.OPEN_UNSAFE (RHBZ#1493048)
2018-02-06 17:27:23 +01:00
daemon_config.mli
daemon: build also without Hivex.OPEN_UNSAFE (RHBZ#1493048)
2018-02-06 17:27:23 +01:00
daemon_utils_tests.ml
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
daemon-c.c
generator: Implement StringList for OCaml functions
2025-08-13 16:08:28 +01:00
daemon-c.h
generator: Implement StringList for OCaml functions
2025-08-13 16:08:28 +01:00
daemon-utils-tests-stubs.c
daemon: tests: Compile tests with compiler warnings.
2018-01-09 12:17:53 +00:00
daemon.h
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
daemon.ml
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
daemon.mli
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
dd.c
daemon: Refine check for Device and Dev_or_Path parameters (RHBZ#1477623).
2017-08-08 17:50:23 +01:00
debug-bmap.c
Add debug APIs: bmap-file, bmap-device, bmap.
2014-11-26 16:15:47 +00:00
debug.c
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
device-name-translation.c
Fix miscellaneous spelling mistakes
2025-04-29 19:05:07 +01:00
devsparts.c
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
devsparts.ml
Update common submodule
2025-05-11 21:29:23 +01:00
df.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
dir.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
dmesg.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
dropcaches.c
…
du.c
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
echo-daemon.c
daemon: Link guestfsd with libutils.
2017-07-10 17:01:59 +01:00
ext2.c
daemon: Implement e2fsck -n flag (as FORCENO option)
2025-05-20 14:40:58 +01:00
f2fs.c
New API: f2fs_expand
2018-04-19 11:30:29 +02:00
fallocate.c
Use 'const' for stack integers where possible.
2016-07-26 10:43:45 +01:00
file_helper.ml
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
file_helper.mli
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
file.c
Fix miscellaneous spelling mistakes
2025-04-29 19:05:07 +01:00
file.ml
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
filearch.ml
Update common submodule
2025-05-11 12:37:23 +01:00
fill.c
Use 'const' for stack integers where possible.
2016-07-26 10:43:45 +01:00
find.c
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
findfs.ml
Update common submodule
2025-05-11 21:29:23 +01:00
fs-min-size.c
Added xfs support to vfs_minimum_size.
2015-10-27 17:25:49 +00:00
fsck.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
fstrim.c
daemon/fstrim.c: Run the fstrim command twice
2025-04-28 10:07:34 +01:00
gdisk.c
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
glob.c
daemon: glob: add optarg to control trailing slash for dirs
2016-02-04 11:25:56 +01:00
grep.c
…
grub.c
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
guestfsd.c
daemon: Use modern compound literal for SIGPIPE ignore
2025-11-21 18:58:00 +00:00
guestfsd.pod
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
headtail.c
…
hexdump.c
…
hivex.c
New API: Deprecate hivex_value_utf8 and replace with hivex_value_string.
2017-09-16 22:27:16 +01:00
htonl.c
…
initrd.c
daemon: Remove remaining uses of custom printf %Q and %R
2022-08-16 10:39:01 +01:00
inotify.c
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
inspect_fs_unix_fstab.ml
daemon: inspect: check /etc/crypttab for /dev/mapper/*
2025-08-12 17:55:06 +01:00
inspect_fs_unix_fstab.mli
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
inspect_fs_unix.ml
Update common submodule
2025-05-11 21:29:23 +01:00
inspect_fs_unix.mli
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
inspect_fs_windows.ml
daemon: inspect_get_windows_group_policy
2025-11-04 15:56:33 +00:00
inspect_fs_windows.mli
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
inspect_fs.ml
support TencentOS
2025-03-03 14:22:37 +00:00
inspect_fs.mli
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
inspect_types.ml
daemon: inspect_get_windows_group_policy
2025-11-04 15:56:33 +00:00
inspect_types.mli
daemon: inspect_get_windows_group_policy
2025-11-04 15:56:33 +00:00
inspect_utils.ml
Update common submodule
2025-05-11 12:37:23 +01:00
inspect_utils.mli
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
inspect.ml
daemon: inspect_get_windows_group_policy
2025-11-04 15:56:33 +00:00
internal.c
docs: Add internal documentation for a few daemon functions.
2016-04-12 20:59:40 +01:00
is.c
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
is.ml
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
isoinfo.ml
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
journal.c
…
labels.c
daemon: set-label: Convert to table-driven dispatch
2025-11-24 09:47:21 +00:00
ldm.c
daemon/ldm.c: Replace jansson with json-c
2024-10-22 11:02:38 +01:00
ldm.ml
Update common submodule
2025-05-11 21:29:23 +01:00
link.c
daemon/link.c: Fix out of memory error when reading symlinks
2021-05-13 12:04:41 +01:00
link.ml
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
listfs.ml
daemon/listfs.ml: Add more debugging to list_filesystems
2025-05-27 17:01:09 +01:00
ls.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
luks.c
daemon/luks.c: Ignore bogus GCC -fanalyzer double-free warning
2021-09-07 14:53:06 +01:00
lvm_dm.ml
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
lvm_full.ml
daemon: Rewrite {pvs,vgs,lvs}-full APIs in OCaml
2025-04-16 21:12:49 +01:00
lvm_utils.ml
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
lvm_utils.mli
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
lvm-filter.c
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
lvm.c
daemon: Rewrite {pvs,vgs,lvs}-full APIs in OCaml
2025-04-16 21:12:49 +01:00
lvm.ml
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
Makefile.am
daemon: Reimplement guestfs_selinux_relabel in OCaml
2025-08-13 16:08:28 +01:00
md.c
daemon: Replace "noalloc" with [@@noalloc]
2021-11-09 10:20:37 +00:00
md.ml
Update common submodule
2025-05-11 21:29:23 +01:00
mkfs.c
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
mknod.c
Use AC_HEADER_MAJOR to find definitions of major, minor, makedev.
2017-03-03 11:32:37 +00:00
mktemp.c
…
modprobe.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
mount_utils.ml
Update common submodule
2025-05-11 21:29:23 +01:00
mount_utils.mli
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
mount.c
daemon: Refine check for Device and Dev_or_Path parameters (RHBZ#1477623).
2017-08-08 17:50:23 +01:00
mount.ml
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
mountable.c
…
mountable.ml
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
mountable.mli
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
ntfs.c
New API: ntfs_chmod
2025-09-09 16:29:13 +01:00
ntfsclone.c
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
parted.c
parted: Modernize check_parttype() with table-driven mapping
2025-11-21 13:57:26 +00:00
parted.ml
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
pingdaemon.c
…
proto.c
daemon: use compound literal in send_error()
2025-11-20 11:22:56 +00:00
readdir.c
guestfs_readdir(): minimize the number of send_file_write() calls
2022-05-03 10:54:00 +02:00
realpath.ml
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
rename.c
…
rpm-c.c
lib: Add new app2_class field for classifying applications
2025-11-04 15:56:33 +00:00
rpm.ml
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
rsync.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
scrub.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
selinux.c
daemon: Reimplement guestfs_selinux_relabel in OCaml
2025-08-13 16:08:28 +01:00
selinux.ml
daemon, generator: Use power of 2 for initial size of Hashtbl.create
2025-09-12 08:37:58 +01:00
sfdisk.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
sfdisk.ml
Update common submodule
2025-05-11 21:29:23 +01:00
sh.c
daemon: bind_mount: Initialize struct bind_state with compound literal
2025-11-24 09:58:05 +00:00
sleep.c
…
sleuthkit.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
squashfs.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
stat.c
daemon: stat_to_statns: Modernize with designated initializer
2025-11-24 09:58:22 +00:00
statvfs.ml
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
strings.c
…
stubs-macros.h
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
swap.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
sync.c
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
syslinux.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
sysroot-c.c
daemon: sysroot: Avoid copying the path every time we call sysroot ()
2025-08-13 16:08:28 +01:00
sysroot.ml
daemon: sysroot: Avoid copying the path every time we call sysroot ()
2025-08-13 16:08:28 +01:00
sysroot.mli
daemon: sysroot: Avoid double-/ when creating sysroot paths in OCaml
2025-08-13 16:08:28 +01:00
tar.c
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
truncate.c
…
tsk.c
macOS: Include <rpc/types.h> before <rpc/xdr.h>.
2018-05-15 11:15:54 +01:00
umask.c
Fix various -Wformat problems.
2015-07-02 16:08:44 +01:00
upload.c
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
utils-c.c
daemon: Add an OCaml binding for get_random_uuid function
2024-05-10 16:07:20 +01:00
utils.c
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
utils.ml
daemon/inspect_fs_windows.ml: Add debugging for MBR drive mappings
2025-08-14 15:45:59 +01:00
utils.mli
daemon/inspect_fs_windows.ml: Add debugging for MBR drive mappings
2025-08-14 15:45:59 +01:00
utimens.c
…
utsname.c
…
uuids.c
daemon: Convert do_set_uuid_random to table-driven dispatch
2025-11-24 09:49:03 +00:00
wc.c
…
xattr.c
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
xfs.c
daemon/xfs.c: Fix error message.
2021-03-30 12:56:58 +01:00
yara.c
build: Assume __attribute__((cleanup)) always works
2024-10-18 21:55:21 +01:00
zero.c
Update copyright dates for 2025
2025-02-16 17:00:46 +00:00
zerofree.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00