mirror of
https://github.com/libguestfs/libguestfs.git
synced 2026-03-22 07:03:38 +00:00
ccdbbc7fe4
Updating gnulib has caused -Wformat-signedness to be enabled. This has revealed many problems in C format strings. The fixes here fall into the following main categories: - Using %d with an unsigned parameter. - %x and %o expect an unsigned argument. - uid_t and gid_t are unsigned on Linux. The safe way to print these is to cast them to uintmax_t and then print them using the %ju modifier (see http://stackoverflow.com/a/1401581). - Using %d to print an enum. Since enums may be either char or int, I fixed this by casting the enum to int. - strtol_error & lzma_ret are both unsigned types.
This is a test tool, not a comprehensive test, but a "does it basically function" test, which can be packaged and given to end users. It also collects and prints a lot of internal debug information, which is useful in bug reports to track down appliance / qemu boot problems. For more information, please read the man page libguestfs-test-tool(1).