Files
libguestfs/daemon/utils-c.c
Richard W.M. Jones 07ba8b6d6b daemon: Refine check for Device and Dev_or_Path parameters (RHBZ#1477623).
For Device parameters we expect a block device name.  However we were
only testing for "/dev/..." and so chardevs (from the appliance) could
be passed here, resulting in strange effects.  This adds a function
is_device_parameter which tests for a valid block device name.

For Dev_or_Path parameters much the same, except we can also use the
is_device_parameter function elsewhere in the daemon to distinguish if
we were called with a device or path parameter.  Previously we used a
simple test if the path begins with "/dev/...".

Reported by Mathieu Tarral.
2017-08-08 17:50:23 +01:00

83 lines
2.0 KiB
C

/* guestfsd
* Copyright (C) 2017 Red Hat Inc.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
/**
* Bindings for utility functions.
*
* Note that functions called from OCaml code B<must never> call
* any of the C<reply*> functions.
*/
#include <config.h>
#include <stdio.h>
#include <stdlib.h>
#include <caml/alloc.h>
#include <caml/mlvalues.h>
#include <caml/memory.h>
#include <caml/unixsupport.h>
#include "daemon.h"
#pragma GCC diagnostic ignored "-Wmissing-prototypes"
/* NB: This is a "noalloc" call. */
value
guestfs_int_daemon_get_verbose_flag (value unitv)
{
return Val_bool (verbose);
}
/* NB: This is a "noalloc" call. */
value
guestfs_int_daemon_is_device_parameter (value device)
{
return Val_bool (is_device_parameter (String_val (device)));
}
/* NB: This is a "noalloc" call. */
value
guestfs_int_daemon_is_root_device (value device)
{
return Val_bool (is_root_device (String_val (device)));
}
/* NB: This is a "noalloc" call. */
value
guestfs_int_daemon_prog_exists (value prog)
{
return Val_bool (prog_exists (String_val (prog)));
}
/* NB: This is a "noalloc" call. */
value
guestfs_int_daemon_udev_settle (value optfilenamev, value unitv)
{
const char *file;
if (optfilenamev == Val_int (0))
file = NULL;
else
file = String_val (Field (optfilenamev, 0));
udev_settle_file (file);
return Val_unit;
}