mirror of
https://github.com/libguestfs/libguestfs.git
synced 2026-03-22 07:03:38 +00:00
We have traditionally used custom printf formatters %Q and %R, where
%Q replaces the argument with a shell-quoted string, and %R replaces
the argument with a sysroot-prefixed shell-quoted string. They are
actually pretty useful, but unfortunately only supported by glibc.
We only used them in about a dozen places in the daemon (much code
having been replaced by OCaml which does not need them).
In every remaining case we were constructing a command using code like
this:
asprintf_nowarn (&cmd,
"cd %Q && find -print0 | %s -0 -o -H %s --quiet", ...);
We can replace this with:
char *cmd;
size_t cmd_size;
fp = open_memstream (&cmd, &cmd_size);
fprintf (fp, "cd ");
shell_quote (dir, fp);
fprintf (fp, " && find -print0 | %s -0 -o -H %s --quiet", ...);
fclose (fp);
215 lines
5.7 KiB
C
215 lines
5.7 KiB
C
/* libguestfs - the guestfsd daemon
|
|
* Copyright (C) 2011 Red Hat Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <fcntl.h>
|
|
|
|
#include "guestfs_protocol.h"
|
|
#include "daemon.h"
|
|
#include "actions.h"
|
|
|
|
/* Has one FileOut parameter. */
|
|
static int
|
|
do_compressX_out (const char *file, const char *filter, int is_device)
|
|
{
|
|
int r;
|
|
FILE *fp;
|
|
CLEANUP_FREE char *cmd = NULL;
|
|
size_t cmd_size;
|
|
CLEANUP_FREE char *buf = NULL;
|
|
|
|
buf = malloc (GUESTFS_MAX_CHUNK_SIZE);
|
|
if (buf == NULL) {
|
|
reply_with_perror ("malloc");
|
|
return -1;
|
|
}
|
|
|
|
/* The command will look something like:
|
|
* gzip -c /sysroot%s # file
|
|
* or:
|
|
* gzip -c < %s # device
|
|
*
|
|
* We have to quote the file or device name.
|
|
*
|
|
* The unnecessary redirect for devices is there because lzop
|
|
* unhelpfully refuses to compress anything that isn't a regular
|
|
* file.
|
|
*/
|
|
fp = open_memstream (&cmd, &cmd_size);
|
|
if (fp == NULL) {
|
|
cmd_error:
|
|
reply_with_perror ("open_memstream");
|
|
return -1;
|
|
}
|
|
fprintf (fp, "%s ", filter);
|
|
if (!is_device) {
|
|
sysroot_shell_quote (file, fp);
|
|
} else {
|
|
fprintf (fp, "< ");
|
|
shell_quote (file, fp);
|
|
}
|
|
if (fclose (fp) == EOF)
|
|
goto cmd_error;
|
|
|
|
if (verbose)
|
|
fprintf (stderr, "%s\n", cmd);
|
|
|
|
fp = popen (cmd, "r");
|
|
if (fp == NULL) {
|
|
reply_with_perror ("%s", cmd);
|
|
return -1;
|
|
}
|
|
|
|
/* Now we must send the reply message, before the file contents. After
|
|
* this there is no opportunity in the protocol to send any error
|
|
* message back. Instead we can only cancel the transfer.
|
|
*/
|
|
reply (NULL, NULL);
|
|
|
|
while ((r = fread (buf, 1, GUESTFS_MAX_CHUNK_SIZE, fp)) > 0) {
|
|
if (send_file_write (buf, r) < 0) {
|
|
pclose (fp);
|
|
return -1;
|
|
}
|
|
}
|
|
|
|
if (ferror (fp)) {
|
|
fprintf (stderr, "fread: %s: %m\n", file);
|
|
send_file_end (1); /* Cancel. */
|
|
pclose (fp);
|
|
return -1;
|
|
}
|
|
|
|
if (pclose (fp) != 0) {
|
|
fprintf (stderr, "pclose: %s: %m\n", file);
|
|
send_file_end (1); /* Cancel. */
|
|
return -1;
|
|
}
|
|
|
|
if (send_file_end (0)) /* Normal end of file. */
|
|
return -1;
|
|
|
|
return 0;
|
|
}
|
|
|
|
#define CHECK_SUPPORTED(prog) \
|
|
if (!prog_exists (prog)) \
|
|
/* note: substring "not supported" must appear in this error */ \
|
|
NOT_SUPPORTED (-1, "compression type %s is not supported, because external program '%s' is not available in the appliance", prog, prog);
|
|
|
|
static int
|
|
get_filter (const char *ctype, int level, char *ret, size_t n)
|
|
{
|
|
if (STREQ (ctype, "compress")) {
|
|
CHECK_SUPPORTED ("compress");
|
|
if (level != -1) {
|
|
reply_with_error ("compress: cannot use optional level parameter with this compression type");
|
|
return -1;
|
|
}
|
|
snprintf (ret, n, "%s -c", "compress");
|
|
return 0;
|
|
}
|
|
else if (STREQ (ctype, "gzip")) {
|
|
CHECK_SUPPORTED ("gzip");
|
|
if (level == -1)
|
|
snprintf (ret, n, "%s -c", "gzip");
|
|
else if (level >= 1 && level <= 9)
|
|
snprintf (ret, n, "%s -c -%d", "gzip", level);
|
|
else {
|
|
reply_with_error ("gzip: incorrect value for level parameter");
|
|
return -1;
|
|
}
|
|
return 0;
|
|
}
|
|
else if (STREQ (ctype, "bzip2")) {
|
|
CHECK_SUPPORTED ("bzip2");
|
|
if (level == -1)
|
|
snprintf (ret, n, "%s -c", "bzip2");
|
|
else if (level >= 1 && level <= 9)
|
|
snprintf (ret, n, "%s -c -%d", "bzip2", level);
|
|
else {
|
|
reply_with_error ("bzip2: incorrect value for level parameter");
|
|
return -1;
|
|
}
|
|
return 0;
|
|
}
|
|
else if (STREQ (ctype, "xz")) {
|
|
CHECK_SUPPORTED ("xz");
|
|
if (level == -1)
|
|
snprintf (ret, n, "%s -c", "xz");
|
|
else if (level >= 0 && level <= 9)
|
|
snprintf (ret, n, "%s -c -%d", "xz", level);
|
|
else {
|
|
reply_with_error ("xz: incorrect value for level parameter");
|
|
return -1;
|
|
}
|
|
return 0;
|
|
}
|
|
else if (STREQ (ctype, "lzop")) {
|
|
CHECK_SUPPORTED ("lzop");
|
|
if (level == -1)
|
|
snprintf (ret, n, "%s -c", "lzop");
|
|
else if (level >= 1 && level <= 9)
|
|
snprintf (ret, n, "%s -c -%d", "lzop", level);
|
|
else {
|
|
reply_with_error ("lzop: incorrect value for level parameter");
|
|
return -1;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
reply_with_error ("unknown compression type");
|
|
return -1;
|
|
}
|
|
|
|
/* Has one FileOut parameter. */
|
|
/* Takes optional arguments, consult optargs_bitmask. */
|
|
int
|
|
do_compress_out (const char *ctype, const char *file, int level)
|
|
{
|
|
char filter[64];
|
|
|
|
if (!(optargs_bitmask & GUESTFS_COMPRESS_OUT_LEVEL_BITMASK))
|
|
level = -1;
|
|
|
|
if (get_filter (ctype, level, filter, sizeof filter) == -1)
|
|
return -1;
|
|
|
|
return do_compressX_out (file, filter, 0);
|
|
}
|
|
|
|
/* Has one FileOut parameter. */
|
|
/* Takes optional arguments, consult optargs_bitmask. */
|
|
int
|
|
do_compress_device_out (const char *ctype, const char *file, int level)
|
|
{
|
|
char filter[64];
|
|
|
|
if (!(optargs_bitmask & GUESTFS_COMPRESS_DEVICE_OUT_LEVEL_BITMASK))
|
|
level = -1;
|
|
|
|
if (get_filter (ctype, level, filter, sizeof filter) == -1)
|
|
return -1;
|
|
|
|
return do_compressX_out (file, filter, 1);
|
|
}
|