mirrors/libguestfs
1
0
Fork 0
mirror of https://github.com/libguestfs/libguestfs.git synced 2026-03-22 07:03:38 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
8bf4455936322e0fac7606dc4f2b741e70437d24
libguestfs/daemon
History
Richard W.M. Jones 8bf4455936 daemon: Remove remaining uses of custom printf %Q and %R 
We have traditionally used custom printf formatters %Q and %R, where
%Q replaces the argument with a shell-quoted string, and %R replaces
the argument with a sysroot-prefixed shell-quoted string.  They are
actually pretty useful, but unfortunately only supported by glibc.

We only used them in about a dozen places in the daemon (much code
having been replaced by OCaml which does not need them).

In every remaining case we were constructing a command using code like
this:

  asprintf_nowarn (&cmd,
         "cd %Q && find -print0 | %s -0 -o -H %s --quiet", ...);

We can replace this with:

  char *cmd;
  size_t cmd_size;
  fp = open_memstream (&cmd, &cmd_size);
  fprintf (fp, "cd ");
  shell_quote (dir, fp);
  fprintf (fp, " && find -print0 | %s -0 -o -H %s --quiet", ...);
  fclose (fp);

(cherry picked from commit 0b3c6cc0c0)
2022-11-21 18:10:55 +00:00
..
9p.c
lib: Remove 9p APIs
2022-03-09 09:28:02 +00:00
acl.c
…
augeas.c
appliance: remove custom Shadow augeas lens
2019-05-30 09:12:32 +02:00
available.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
base64.c
daemon: Remove remaining uses of custom printf %Q and %R
2022-11-21 18:10:55 +00:00
blkdiscard.c
…
blkid.c
daemon: Reimplement ‘vfs_type’ API in OCaml.
2017-07-27 22:31:22 +01:00
blkid.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
blockdev.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
btrfs.c
daemon/btrfs.c: Ignore mkfs.btrfs allocstart option.
2021-03-22 14:26:57 +00:00
btrfs.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
callbacks.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
cap.c
…
checksum.c
daemon: Remove remaining uses of custom printf %Q and %R
2022-11-21 18:10:55 +00:00
chroot.ml
daemon: chroot: Fix long-standing possible deadlock.
2021-03-26 16:06:03 +00:00
chroot.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
cleanups.c
daemon: Link guestfsd with libutils.
2017-07-10 17:01:59 +01:00
cmp.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
command.c
daemon: Remove workaround for -Wanalyzer-mismatching-deallocation
2022-07-06 13:30:13 +01:00
command.h
…
compress.c
daemon: Remove remaining uses of custom printf %Q and %R
2022-11-21 18:10:55 +00:00
copy.c
…
cpio.c
daemon: Remove remaining uses of custom printf %Q and %R
2022-11-21 18:10:55 +00:00
cpmv.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
cryptsetup.ml
New APIs: cryptsetup-open and cryptsetup-close.
2020-10-12 10:44:08 +01:00
daemon_config.ml.in
daemon: build also without Hivex.OPEN_UNSAFE (RHBZ#1493048)
2018-02-06 17:27:23 +01:00
daemon_config.mli
daemon: build also without Hivex.OPEN_UNSAFE (RHBZ#1493048)
2018-02-06 17:27:23 +01:00
daemon_utils_tests.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
daemon-c.c
daemon/daemon-c.c: Fix whitespace.
2021-03-16 11:24:37 +00:00
daemon-c.h
generator: daemon: Implement RStringList (RMountable, _) and RHashtable (RPlainString, RMountable, _).
2017-09-16 22:27:16 +01:00
daemon-utils-tests-stubs.c
daemon: tests: Compile tests with compiler warnings.
2018-01-09 12:17:53 +00:00
daemon.h
daemon: Remove remaining uses of custom printf %Q and %R
2022-11-21 18:10:55 +00:00
daemon.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
daemon.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
dd.c
daemon: Refine check for Device and Dev_or_Path parameters (RHBZ#1477623).
2017-08-08 17:50:23 +01:00
debug-bmap.c
…
debug.c
daemon: Remove workaround for -Wanalyzer-mismatching-deallocation
2022-07-06 13:30:13 +01:00
device-name-translation.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
devsparts.c
daemon: Don't return bogus failure from readdir.
2021-03-22 14:56:10 +00:00
devsparts.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
df.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
dir.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
dmesg.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
dropcaches.c
…
du.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
echo-daemon.c
daemon: Link guestfsd with libutils.
2017-07-10 17:01:59 +01:00
ext2.c
daemon: Remove remaining uses of custom printf %Q and %R
2022-11-21 18:10:55 +00:00
f2fs.c
New API: f2fs_expand
2018-04-19 11:30:29 +02:00
fallocate.c
…
file.c
daemon: Remove remaining uses of custom printf %Q and %R
2022-11-21 18:10:55 +00:00
file.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
filearch.ml
daemon: Add zstd support to guestfs_file_architecture
2022-11-21 18:10:32 +00:00
fill.c
…
find.c
daemon: Remove remaining uses of custom printf %Q and %R
2022-11-21 18:10:55 +00:00
findfs.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
fs-min-size.c
…
fsck.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
fstrim.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
glob.c
…
grep.c
…
grub.c
daemon: grub: Remove incorrect use of printf specifier %R
2022-11-21 18:10:42 +00:00
guestfsd.c
daemon: Remove remaining uses of custom printf %Q and %R
2022-11-21 18:10:55 +00:00
guestfsd.pod
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
headtail.c
…
hexdump.c
…
hivex.c
New API: Deprecate hivex_value_utf8 and replace with hivex_value_string.
2017-09-16 22:27:16 +01:00
htonl.c
…
initrd.c
daemon: Remove remaining uses of custom printf %Q and %R
2022-11-21 18:10:55 +00:00
inotify.c
daemon/inotify.c: Clean up error handling
2021-09-07 14:48:03 +01:00
inspect_fs_unix_fstab.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
inspect_fs_unix_fstab.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
inspect_fs_unix.ml
daemon: Parse /etc/hostname files containing comments
2022-11-21 18:10:19 +00:00
inspect_fs_unix.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
inspect_fs_windows.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
inspect_fs_windows.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
inspect_fs.ml
Add detection support for Rocky Linux (CentOS/RHEL-like)
2021-12-10 09:09:47 +00:00
inspect_fs.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
inspect_types.ml
Add detection support for Rocky Linux (CentOS/RHEL-like)
2021-12-10 09:09:47 +00:00
inspect_types.mli
Add detection support for Rocky Linux (CentOS/RHEL-like)
2021-12-10 09:09:47 +00:00
inspect_utils.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
inspect_utils.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
inspect.ml
inspection: More reliable detection of Linux split /usr configurations
2021-04-15 09:41:35 +01:00
internal.c
…
is.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
is.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
isoinfo.ml
daemon: Fix isoinfo on files
2021-05-13 09:19:31 +01:00
journal.c
…
labels.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
ldm.c
Switch from YAJL to Jansson
2018-02-12 11:24:06 +01:00
ldm.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
link.c
daemon/link.c: Fix out of memory error when reading symlinks
2021-05-13 12:04:41 +01:00
link.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
listfs.ml
daemon/listfs: don't call "sgdisk -i" on bogus MBR partition table entry
2021-11-26 10:17:54 +01:00
ls.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
luks.c
daemon/luks.c: Ignore bogus GCC -fanalyzer double-free warning
2021-09-07 14:53:06 +01:00
lvm_dm.ml
daemon: Reimplement list_dm_devices API in OCaml.
2020-10-12 10:44:29 +01:00
lvm_utils.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
lvm_utils.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
lvm-filter.c
appliance, daemon: disable lvm2 devicesfile
2022-07-06 13:30:02 +01:00
lvm.c
daemon: lvm: Use lvcreate --yes to avoid interactive prompts.
2021-02-22 11:04:15 +00:00
lvm.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
Makefile.am
daemon: Remove remaining uses of custom printf %Q and %R
2022-11-21 18:10:55 +00:00
md.c
daemon: Replace "noalloc" with [@@noalloc]
2021-11-09 10:20:37 +00:00
md.ml
daemon: Replace "noalloc" with [@@noalloc]
2021-11-09 10:20:37 +00:00
mkfs.c
daemon/mkfs: disable creation of fake MBR partition table with "mkfs.fat"
2021-11-26 10:16:05 +01:00
mknod.c
…
mktemp.c
…
modprobe.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
mount_utils.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
mount_utils.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
mount.c
daemon: Refine check for Device and Dev_or_Path parameters (RHBZ#1477623).
2017-08-08 17:50:23 +01:00
mount.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
mountable.c
…
mountable.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
mountable.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
ntfs.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
ntfsclone.c
Ignore completely bogus GCC 11 warnings.
2021-01-05 10:31:00 +00:00
parted.c
daemon/parted: simplify print_partition_table() prototype
2021-11-26 10:16:06 +01:00
parted.ml
daemon/parted: work around part table type misreporting by "parted"
2021-11-26 10:17:05 +01:00
pingdaemon.c
…
proto.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
readdir.c
…
realpath.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
rename.c
…
rpm-c.c
daemon: rpm: Check return values from librpm calls
2022-05-26 11:20:42 +01:00
rpm.ml
inspection: Fix inspection of recent RPM guests using non-BDB.
2021-03-26 16:26:00 +00:00
rsync.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
scrub.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
selinux-relabel.c
daemon/selinux-relabel: tolerate relabeling errors
2022-05-12 14:48:28 +01:00
selinux.c
daemon, lib: Replace deprecated security_context_t with char *.
2020-07-30 13:58:35 +01:00
sfdisk.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
sh.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
sleep.c
…
sleuthkit.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
squashfs.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
stat.c
daemon: Link guestfsd with libutils.
2017-07-10 17:01:59 +01:00
statvfs.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
strings.c
…
stubs-macros.h
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
swap.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
sync.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
syslinux.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00
sysroot-c.c
daemon: Allow parts of the daemon and APIs to be written in OCaml.
2017-07-27 22:31:22 +01:00
sysroot.ml
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
sysroot.mli
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
tar.c
daemon: Remove remaining uses of custom printf %Q and %R
2022-11-21 18:10:55 +00:00
truncate.c
…
tsk.c
macOS: Include <rpc/types.h> before <rpc/xdr.h>.
2018-05-15 11:15:54 +01:00
umask.c
…
upload.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
utils-c.c
daemon: Replace "noalloc" with [@@noalloc]
2021-11-09 10:20:37 +00:00
utils.c
daemon/utils.c: Fix potential unbounded stack usage
2021-09-07 15:55:48 +01:00
utils.ml
daemon/utils.ml: Replace Bytes.get_uint8 with native call
2022-04-14 11:32:35 +01:00
utils.mli
daemon/parted: work around part table type misreporting by "parted"
2021-11-26 10:17:05 +01:00
utimens.c
…
utsname.c
…
uuids.c
…
wc.c
…
xattr.c
daemon/xattr.c: Increase size of temporary buffer for %zu
2021-09-07 15:55:43 +01:00
xfs.c
daemon/xfs.c: Fix error message.
2021-03-30 12:56:58 +01:00
yara.c
daemon/yara: fix undefined behavior due to Yara 4.0 API changes
2021-10-12 16:48:04 +02:00
zero.c
Update copyright dates to 2020.
2020-03-06 19:32:32 +00:00
zerofree.c
daemon: Remove GUESTFSD_EXT_CMD.
2017-07-27 17:31:41 +01:00