mirrors/libguestfs
1
0
Fork 0
mirror of https://github.com/libguestfs/libguestfs.git synced 2026-03-21 22:53:37 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
a420e535d5549809ca384136d889c2c4d65ea571
libguestfs/daemon/Makefile.am
Pino Toscano a420e535d5 daemon: reorder internal static libs to fix linking 
Move the interal static libraries as the last items in the list of
libraries of guestfsd, to make sure their symbols are used for all the
other libraries.  This is because GCC resolves the symbols looking at
the arguments from the beginning to the end of the command line.
This currently does not cause failures, however it "just works" because
of the tricky situation set up.

The situation is the following:

1) common/utils contains few utility sources: one of them is utils.c,
which contains various functions -- for example
guestfs_int_free_string_list and guestfs_int_drive_name --, it is built
as utils.o, and bundled in the static library libutils.a

2) common/mlutils builds a OCaml library with bindings for some utility
functions in libutils.a, in particular guestfs_int_drive_name (but not
guestfs_int_free_string_list); there are two versions of this library,
one OCaml library (dllmlcutils.so) that links with libutils.a, and one
static library (libmlcutils.a), which cannot specify the libraries it
links to (as it is static)

3) when the daemon is linked, the command line was the following
(simplified):
  $ gcc [...] -o guestfsd guestfsd-9p.o other_daemon_object.o [...] \
      ../common/utils/.libs/libutils.a [...] -lmlcutils [...]
Some of the objects of the daemon itself use
guestfs_int_free_string_list, and thus the compiler opens libutils.a
(it is after the objects in the command line) and picks utils.o, which
contains also guestfs_int_drive_name (not used directly in the daemon);
when linking later on with libmlcutils.a, the symbols for this static
library (like guestfs_int_drive_name) are already resolved, and thus
all the symbols are resolved, and the linking succeeds

This fragile situation can be easily broken by moving e.g.
guestfs_int_drive_name out of common/utils/utils.c to a new source (say
utils2.c) still built as part of libutils.a: since nothing before
-lmlcutils actually needs to pick utils2.o from libutils.a for symbols,
then GCC will not be able to resolve all the symbols in libmlcutils.a.

As solution, move libutils.a (and other internal static libraries) as
last libraries to link guestfsd to: this way, GCC knows where to find
all the symbols needed by all the objects and libraries specified in
the command line.
2019-12-19 13:10:41 +01:00

470 lines
8.8 KiB
Makefile
Raw Blame History

# libguestfs-daemon
# Copyright (C) 2011 Red Hat Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
include $(top_srcdir)/subdir-rules.mk
BUILT_SOURCES = \
actions.h \
caml-stubs.c \
dispatch.c \
names.c \
lvm-tokenization.c \
structs-cleanups.c \
structs-cleanups.h \
stubs-0.c \
stubs-1.c \
stubs-2.c \
stubs-3.c \
stubs-4.c \
stubs-5.c \
stubs-6.c \
stubs.h
generator_built = \
$(BUILT_SOURCES) \
blkid.mli \
btrfs.mli \
callbacks.ml \
devsparts.mli \
file.mli \
filearch.mli \
findfs.mli \
inspect.mli \
is.mli \
ldm.mli \
link.mli \
listfs.mli \
lvm.mli \
md.mli \
mount.mli \
optgroups.ml \
optgroups.mli \
parted.mli \
realpath.mli \
statvfs.mli \
structs.ml \
structs.mli
CONFIGURE_GENERATED_ML = \
daemon_config.ml
EXTRA_DIST = \
$(generator_built) \
$(SOURCES_MLI) \
$(filter-out $(CONFIGURE_GENERATED_ML),$(SOURCES_ML)) \
daemon_utils_tests.ml \
guestfsd.pod
if INSTALL_DAEMON
sbin_PROGRAMS = guestfsd
else
noinst_PROGRAMS = guestfsd
endif
guestfsd_SOURCES = \
../common/errnostring/errnostring.h \
../common/protocol/guestfs_protocol.h \
../common/utils/cleanups.h \
../common/utils/guestfs-utils.h \
9p.c \
acl.c \
actions.h \
available.c \
augeas.c \
base64.c \
blkdiscard.c \
blkid.c \
blockdev.c \
btrfs.c \
caml-stubs.c \
cap.c \
checksum.c \
cleanups.c \
cmp.c \
command.c \
command.h \
compress.c \
copy.c \
cpio.c \
cpmv.c \
daemon-c.c \
daemon-c.h \
daemon.h \
dd.c \
debug.c \
debug-bmap.c \
device-name-translation.c \
devsparts.c \
df.c \
dir.c \
dispatch.c \
dmesg.c \
dropcaches.c \
du.c \
echo-daemon.c \
ext2.c \
f2fs.c \
fallocate.c \
file.c \
fill.c \
find.c \
format.c \
fs-min-size.c \
fsck.c \
fstrim.c \
glob.c \
grep.c \
grub.c \
guestfsd.c \
headtail.c \
hexdump.c \
hotplug.c \
hivex.c \
htonl.c \
initrd.c \
inotify.c \
internal.c \
is.c \
isoinfo.c \
journal.c \
labels.c \
ldm.c \
link.c \
ls.c \
luks.c \
lvm.c \
lvm-filter.c \
lvm-tokenization.c \
md.c \
mkfs.c \
mknod.c \
mktemp.c \
modprobe.c \
mount.c \
mountable.c \
names.c \
ntfs.c \
ntfsclone.c \
optgroups.c \
optgroups.h \
parted.c \
pingdaemon.c \
proto.c \
readdir.c \
rename.c \
rsync.c \
scrub.c \
selinux.c \
selinux-relabel.c \
sfdisk.c \
sh.c \
sleep.c \
sleuthkit.c \
squashfs.c \
stat.c \
strings.c \
structs-cleanups.c \
structs-cleanups.h \
stubs-0.c \
stubs-1.c \
stubs-2.c \
stubs-3.c \
stubs-4.c \
stubs-5.c \
stubs-6.c \
stubs.h \
stubs-macros.h \
swap.c \
sync.c \
syslinux.c \
sysroot-c.c \
tar.c \
tsk.c \
truncate.c \
umask.c \
upload.c \
utils.c \
utils-c.c \
utimens.c \
utsname.c \
uuids.c \
wc.c \
xattr.c \
xfs.c \
yara.c \
zero.c \
zerofree.c
guestfsd_LDFLAGS = \
-L$(shell $(OCAMLC) -where) \
-L$(shell $(OCAMLC) -where)/hivex \
-L../common/mlutils \
-L../common/mlstdutils \
-L../bundled/ocaml-augeas \
-L../common/mlpcre
guestfsd_LDADD = \
camldaemon.o \
$(ACL_LIBS) \
$(CAP_LIBS) \
$(JANSSON_LIBS) \
$(SELINUX_LIBS) \
$(AUGEAS_LIBS) \
$(HIVEX_LIBS) \
$(SD_JOURNAL_LIBS) \
$(top_builddir)/gnulib/lib/.libs/libgnu.a \
$(LIBSOCKET) \
$(LIB_CLOCK_GETTIME) \
$(LIBINTL) \
$(PCRE_LIBS) \
$(TSK_LIBS) \
$(RPC_LIBS) \
$(YARA_LIBS) \
$(OCAML_LIBS) \
../common/errnostring/liberrnostring.la \
../common/protocol/libprotocol.la \
../common/utils/libutils.la
guestfsd_CPPFLAGS = \
-DCAML_NAME_SPACE \
-I$(shell $(OCAMLC) -where) \
-I$(shell $(OCAMLC) -where)/hivex \
-I$(top_srcdir)/gnulib/lib \
-I$(top_builddir)/gnulib/lib \
-I$(top_srcdir)/lib \
-I$(top_builddir)/lib \
-I$(top_srcdir)/common/errnostring \
-I$(top_builddir)/common/errnostring \
-I$(top_srcdir)/common/protocol \
-I$(top_builddir)/common/protocol \
-I$(top_srcdir)/common/utils \
-I$(top_builddir)/common/utils
guestfsd_CFLAGS = \
$(WARN_CFLAGS) $(WERROR_CFLAGS) \
$(RPC_CFLAGS) \
$(AUGEAS_CFLAGS) \
$(HIVEX_CFLAGS) \
$(SD_JOURNAL_CFLAGS) \
$(JANSSON_CFLAGS) \
$(PCRE_CFLAGS)
# Parts of the daemon are written in OCaml. These are linked into a
# library and then linked to the daemon. See
# https://caml.inria.fr/pub/docs/manual-ocaml/intfc.html
SOURCES_MLI = \
blkid.mli \
btrfs.mli \
callbacks.mli \
chroot.mli \
daemon.mli \
daemon_config.mli \
devsparts.mli \
file.mli \
filearch.mli \
findfs.mli \
inspect.mli \
inspect_fs.mli \
inspect_fs_unix.mli \
inspect_fs_unix_fstab.mli \
inspect_fs_windows.mli \
inspect_types.mli \
inspect_utils.mli \
is.mli \
ldm.mli \
link.mli \
listfs.mli \
lvm.mli \
lvm_utils.mli \
md.mli \
mount.mli \
mount_utils.mli \
mountable.mli \
optgroups.mli \
parted.mli \
realpath.mli \
statvfs.mli \
structs.mli \
sysroot.mli \
utils.mli
SOURCES_ML = \
$(CONFIGURE_GENERATED_ML) \
utils.ml \
structs.ml \
optgroups.ml \
sysroot.ml \
mountable.ml \
chroot.ml \
blkid.ml \
btrfs.ml \
devsparts.ml \
file.ml \
filearch.ml \
is.ml \
ldm.ml \
link.ml \
lvm.ml \
lvm_utils.ml \
findfs.ml \
md.ml \
mount.ml \
mount_utils.ml \
parted.ml \
listfs.ml \
realpath.ml \
statvfs.ml \
inspect_types.ml \
inspect_utils.ml \
inspect_fs_unix_fstab.ml \
inspect_fs_unix.ml \
inspect_fs_windows.ml \
inspect_fs.ml \
inspect.ml \
callbacks.ml \
daemon.ml
BOBJECTS = $(SOURCES_ML:.ml=.cmo)
XOBJECTS = $(BOBJECTS:.cmo=.cmx)
OCAMLPACKAGES = \
-package str,unix,hivex \
-I $(top_builddir)/bundled/ocaml-augeas \
-I $(top_builddir)/common/mlstdutils \
-I $(top_builddir)/common/mlutils \
-I $(top_builddir)/common/utils/.libs \
-I $(top_builddir)/common/mlpcre \
-I $(top_builddir)/common/mlpcre/.libs \
-I $(top_builddir)/gnulib/lib/.libs
OCAMLFLAGS = $(OCAML_FLAGS) $(OCAML_WARN_ERROR) -ccopt '$(CFLAGS)'
if !HAVE_OCAMLOPT
OBJECTS = $(BOBJECTS)
else
OBJECTS = $(XOBJECTS)
endif
OCAML_LIBS = \
-lmlpcre \
-lmlcutils \
-lmlstdutils \
-lmlaugeas \
-lmlhivex \
-lcamlstr \
-lunix \
-l$(CAMLRUN) -ldl -lm
CLEANFILES += camldaemon.o
camldaemon.o: $(OBJECTS)
$(OCAMLFIND) $(BEST) -output-obj -o $@ \
$(OCAMLFLAGS) $(OCAMLPACKAGES) \
-linkpkg \
mlaugeas.$(MLARCHIVE) \
mlpcre.$(MLARCHIVE) \
mlstdutils.$(MLARCHIVE) \
mlcutils.$(MLARCHIVE) \
$(OBJECTS)
# OCaml dependencies.
.depend: $(srcdir)/*.mli $(srcdir)/*.ml
$(top_builddir)/ocaml-dep.sh $^
-include .depend
# Tests.
check_PROGRAMS = daemon_utils_tests
TESTS_ENVIRONMENT = $(top_builddir)/run --test
TESTS = \
daemon_utils_tests
check-valgrind:
$(MAKE) VG="@VG@" check
daemon_utils_tests_SOURCES = \
command.c \
daemon-utils-tests-stubs.c \
utils.c \
utils-c.c
daemon_utils_tests_CPPFLAGS = \
-DCAML_NAME_SPACE \
-I. \
-I$(top_builddir) \
-I$(shell $(OCAMLC) -where) \
-I$(top_srcdir)/gnulib/lib \
-I$(top_builddir)/gnulib/lib \
-I$(top_srcdir)/common/errnostring \
-I$(top_builddir)/common/errnostring \
-I$(top_srcdir)/common/protocol \
-I$(top_builddir)/common/protocol \
-I$(top_srcdir)/common/utils \
-I$(top_builddir)/common/utils \
-I$(top_srcdir)/lib \
-I$(top_builddir)/lib
daemon_utils_tests_CFLAGS = \
$(WARN_CFLAGS) $(WERROR_CFLAGS) \
$(RPC_CFLAGS)
daemon_utils_tests_BOBJECTS = \
utils.cmo \
daemon_utils_tests.cmo
daemon_utils_tests_XOBJECTS = $(daemon_utils_tests_BOBJECTS:.cmo=.cmx)
if !HAVE_OCAMLOPT
daemon_utils_tests_THEOBJECTS = $(daemon_utils_tests_BOBJECTS)
else
daemon_utils_tests_THEOBJECTS = $(daemon_utils_tests_XOBJECTS)
endif
OCAMLLINKFLAGS = \
mlpcre.$(MLARCHIVE) \
mlstdutils.$(MLARCHIVE) \
mlcutils.$(MLARCHIVE) \
mlaugeas.$(MLARCHIVE) \
$(LINK_CUSTOM_OCAMLC_ONLY)
daemon_utils_tests_DEPENDENCIES = \
$(daemon_utils_tests_THEOBJECTS) \
$(top_srcdir)/ocaml-link.sh
daemon_utils_tests_LINK = \
$(top_srcdir)/ocaml-link.sh \
-cclib '-lutils -lgnu' \
-- \
$(OCAMLFIND) $(BEST) $(OCAMLFLAGS) $(OCAMLLINKFLAGS) \
$(OCAMLPACKAGES) \
$(daemon_utils_tests_THEOBJECTS) -o $@
# Manual pages and HTML files for the website.
if INSTALL_DAEMON
man_MANS = guestfsd.8
noinst_DATA =
else
# It should be noinst_MANS but that doesn't work.
noinst_DATA = guestfsd.8
endif
noinst_DATA += $(top_builddir)/website/guestfsd.8.html
guestfsd.8 $(top_builddir)/website/guestfsd.8.html: stamp-guestfsd.pod
stamp-guestfsd.pod: guestfsd.pod
$(PODWRAPPER) \
--section 8 \
--man guestfsd.8 \
--html $(top_builddir)/website/guestfsd.8.html \
--license GPLv2+ \
$<
touch $@
.PHONY: force
Reference in New Issue View Git Blame Copy Permalink