mirror of
https://github.com/libguestfs/libguestfs.git
synced 2026-03-22 07:03:38 +00:00
4256737227
This was a feature that allowed you to add drives to the appliance after launching it. It was complicated to implement, and only worked for the libvirt backend (not "direct", which is the default backend). It also turned out to be a bad idea. The original concept was that appliance creation was slow, so to examine multiple guests you should launch the handle once then hot-add the disks from each guest in turn to manipulate them. However this is terrible from a security point of view, especially for multi-tenant, because the drives from one guest might compromise the appliance and thus the filesystems/drives from subsequent guests. It also turns out that hotplugging is very slow. Nowadays appliance creation should be faster than hotplugging. The main use case for this was virt-df, but virt-df no longer uses it after we discovered the problems outlined above.