mirror of
https://github.com/libguestfs/libguestfs.git
synced 2026-03-22 07:03:38 +00:00
6d0ad49d5e
In the case where we have a module.ml without a corresponding
module.mli file, ocamldep generates (correct) dependencies:
module.cmx module.cmi : module.ml
but we had no rule telling make how to generate the module.cmi
file from module.ml.
This didn't matter very much because when make came to build
module.cmx, the module.cmi file is generated as a side-effect.
However for highly parallel builds, the build ordering was still
incorrect. Any other module that depends on module.cmi could be built
in parallel. You would very occasionally see errors like this one:
File "_none_", line 1:
Error: Files index.cmx and utils.cmx
make inconsistent assumptions over interface Utils
Fixing this involves adding a ‘%.cmi: %.ml’ rule. However we have to
be careful that make doesn't run this rule instead of the ‘%.cmi: %.mli’
rule (if module.mli did exist). It turns out that GNU make says we
can depend on rule ordering in the Makefile for this.
I found that this only works correctly if we use "%"-style pattern
rules (not the ‘.ml.cmi:’ old-style rules).
This is *still* not a complete fix. Make still doesn't know that the
rules ‘%.cmo: %.ml’ and ‘%.cmx: %.ml’ also build the .cmi file as a
side-effect, so you can still occasionally see build failures.
However I could not work out how to add the extra information to the
dependencies without causing make itself to go into an infinite loop.
It may be that in the end we will have to get rid of pattern rules
completely and generate the complete OCaml rule set.
118 lines
4.6 KiB
Makefile
118 lines
4.6 KiB
Makefile
# libguestfs
|
|
# Copyright (C) 2009-2017 Red Hat Inc.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
|
|
# subdir-rules.mk should be included in every *subdirectory* Makefile.am.
|
|
|
|
include $(top_srcdir)/common-rules.mk
|
|
|
|
# Individual Makefile.am's should define generator_built if that
|
|
# subdirectory contains any files which are built by the generator.
|
|
# Set generator_built to the list of those files.
|
|
|
|
$(generator_built): $(top_builddir)/generator/stamp-generator
|
|
|
|
$(top_builddir)/generator/stamp-generator: $(top_builddir)/generator/generator
|
|
@if test -f $(top_builddir)/generator/Makefile; then \
|
|
$(MAKE) -C $(top_builddir)/generator stamp-generator; \
|
|
else \
|
|
echo "warning: Run 'make' at the top level to build $(generator_built)"; \
|
|
fi
|
|
|
|
# If this file doesn't exist, just print a warning and continue.
|
|
# During 'make distclean' we can end up deleting this file.
|
|
$(top_builddir)/generator/generator:
|
|
@if test -f $(top_builddir)/generator/Makefile; then \
|
|
$(MAKE) -C $(top_builddir)/generator generator; \
|
|
else \
|
|
echo "warning: Run 'make' at the top level to build $@"; \
|
|
fi
|
|
|
|
LOG_DRIVER = env $(SHELL) $(top_srcdir)/build-aux/guestfs-test-driver
|
|
|
|
# Rules for building OCaml objects.
|
|
# See also:
|
|
# guestfs-hacking(1) section "HOW OCAML PROGRAMS ARE COMPILED AND LINKED"
|
|
|
|
if !HAVE_OCAMLOPT
|
|
MLARCHIVE = cma
|
|
LINK_CUSTOM_OCAMLC_ONLY = -custom
|
|
BEST = c
|
|
else
|
|
MLARCHIVE = cmxa
|
|
BEST = opt
|
|
endif
|
|
|
|
# custom silent rules
|
|
guestfs_am_v_ocamlc = $(guestfs_am_v_ocamlc_@AM_V@)
|
|
guestfs_am_v_ocamlc_ = $(guestfs_am_v_ocamlc_@AM_DEFAULT_V@)
|
|
guestfs_am_v_ocamlc_0 = @echo " OCAMLC " $@;
|
|
guestfs_am_v_ocamlcmi= $(guestfs_am_v_ocamlcmi_@AM_V@)
|
|
guestfs_am_v_ocamlcmi_ = $(guestfs_am_v_ocamlcmi_@AM_DEFAULT_V@)
|
|
guestfs_am_v_ocamlcmi_0 = @echo " OCAMLCMI" $@;
|
|
guestfs_am_v_ocamlopt = $(guestfs_am_v_ocamlopt_@AM_V@)
|
|
guestfs_am_v_ocamlopt_ = $(guestfs_am_v_ocamlopt_@AM_DEFAULT_V@)
|
|
guestfs_am_v_ocamlopt_0 = @echo " OCAMLOPT" $@;
|
|
guestfs_am_v_javac = $(guestfs_am_v_javac_@AM_V@)
|
|
guestfs_am_v_javac_ = $(guestfs_am_v_javac_@AM_DEFAULT_V@)
|
|
guestfs_am_v_javac_0 = @echo " JAVAC " $@;
|
|
guestfs_am_v_erlc = $(guestfs_am_v_erlc_@AM_V@)
|
|
guestfs_am_v_erlc_ = $(guestfs_am_v_erlc_@AM_DEFAULT_V@)
|
|
guestfs_am_v_erlc_0 = @echo " ERLC " $@;
|
|
guestfs_am_v_podwrapper = $(guestfs_am_v_podwrapper_@AM_V@)
|
|
guestfs_am_v_podwrapper_ = $(guestfs_am_v_podwrapper_@AM_DEFAULT_V@)
|
|
guestfs_am_v_podwrapper_0 = @echo " POD " $@;
|
|
guestfs_am_v_jar = $(guestfs_am_v_jar_@AM_V@)
|
|
guestfs_am_v_jar_ = $(guestfs_am_v_jar_@AM_DEFAULT_V@)
|
|
guestfs_am_v_jar_0 = @echo " JAR " $@;
|
|
|
|
# We must always choose the .mli.cmi rule over the .ml.cmi rule if the
|
|
# .mli file exists. The .mli.cmi rule is listed first because:
|
|
# "If more than one pattern rule has the shortest stem, make will
|
|
# choose the first one found in the makefile."
|
|
# (https://www.gnu.org/software/make/manual/make.html#Pattern-Match)
|
|
%.cmi: %.mli
|
|
$(guestfs_am_v_ocamlcmi)$(OCAMLFIND) ocamlc $(OCAMLFLAGS) $(OCAMLPACKAGES) -c $< -o $@
|
|
%.cmi: %.ml
|
|
$(guestfs_am_v_ocamlcmi)$(OCAMLFIND) ocamlc $(OCAMLFLAGS) $(OCAMLPACKAGES) -c $< -o $@
|
|
%.cmo: %.ml
|
|
$(guestfs_am_v_ocamlc)$(OCAMLFIND) ocamlc $(OCAMLFLAGS) $(OCAMLPACKAGES) -c $< -o $@
|
|
if HAVE_OCAMLOPT
|
|
%.cmx: %.ml
|
|
$(guestfs_am_v_ocamlopt)$(OCAMLFIND) ocamlopt $(OCAMLFLAGS) $(OCAMLPACKAGES) -c $< -o $@
|
|
endif
|
|
|
|
# Test shell scripts should use '$TEST_FUNCTIONS' to get a predefined
|
|
# set of helper functions for running tests (see
|
|
# tests/test-functions.sh).
|
|
#
|
|
# Notes:
|
|
#
|
|
# (1) This is in fact a single command all on one line. The variables
|
|
# are evaluated in test-functions.sh.
|
|
#
|
|
# (2) We use absolute paths here and in test-functions.sh so that the
|
|
# test can change directory freely. But we also include the
|
|
# non-absolute values so they can be used by the test script itself.
|
|
export TEST_FUNCTIONS := \
|
|
source $(abs_top_srcdir)/tests/test-functions.sh \
|
|
abs_srcdir="$(abs_srcdir)" \
|
|
abs_builddir="$(abs_builddir)" \
|
|
top_srcdir="$(top_srcdir)" \
|
|
top_builddir="$(top_builddir)" \
|
|
abs_top_srcdir="$(abs_top_srcdir)" \
|
|
abs_top_builddir="$(abs_top_builddir)"
|