Files
libguestfs/customize/Makefile.am
Richard W.M. Jones d6c42a6c58 valgrind: Don't use "nested" run scripts.
When TESTS_ENVIRONMENT already uses 'run', the VG variable
doesn't also need to use 'run'.

The specific problem is that if the command contains newlines
then double invocations of the 'run' script fails (in libtool).
ie the following command failed causing errors in check-valgrind:

  $VG virt-builder phony-fedora \
      -v --no-cache --no-check-signature $no_network \
  ...
      --write '/etc/append4:line1
  ' \
  ...
2016-10-11 18:08:49 +01:00

284 lines
7.1 KiB
Makefile

# virt-customize
# Copyright (C) 2014-2016 Red Hat Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
include $(top_srcdir)/subdir-rules.mk
EXTRA_DIST = \
$(generator_built) \
$(SOURCES_MLI) $(SOURCES_ML) $(SOURCES_C) \
customize_main.ml \
test-firstboot.sh \
test-settings.sh \
test-virt-customize.sh \
test-virt-customize-docs.sh \
virt-customize.pod
generator_built = \
customize_cmdline.mli \
customize_cmdline.ml \
customize-options.pod \
customize-synopsis.pod
SOURCES_MLI = \
append_line.mli \
crypt.mli \
customize_cmdline.mli \
customize_run.mli \
firstboot.mli \
hostname.mli \
password.mli \
perl_edit.mli \
random_seed.mli \
SELinux_relabel.mli \
ssh_key.mli \
subscription_manager.mli \
timezone.mli \
urandom.mli
# This list must be in dependency order.
SOURCES_ML = \
customize_utils.ml \
append_line.ml \
crypt.ml \
firstboot.ml \
hostname.ml \
urandom.ml \
password.ml \
perl_edit.ml \
random_seed.ml \
SELinux_relabel.ml \
ssh_key.ml \
subscription_manager.ml \
timezone.ml \
customize_cmdline.ml \
customize_run.ml
SOURCES_C = \
../fish/file-edit.c \
../fish/file-edit.h \
crypt-c.c \
perl_edit-c.c
if HAVE_OCAML
# Build the virt-customize objects into a library, since these are
# reused by virt-builder and virt-sysprep. We pretend we are building
# a C library. automake handles the compilation of C sources for us.
# At the end we take the C objects and OCaml objects and link them
# into the OCaml library. This C library is never used.
noinst_LIBRARIES = libcustomize.a
if !HAVE_OCAMLOPT
CUSTOMIZE_CMA = customize.cma
else
CUSTOMIZE_CMA = customize.cmxa
endif
noinst_DATA = $(CUSTOMIZE_CMA)
libcustomize_a_SOURCES = $(SOURCES_C)
libcustomize_a_CPPFLAGS = \
-I. \
-I$(top_builddir) \
-I$(top_srcdir)/gnulib/lib -I$(top_builddir)/gnulib/lib \
-I$(shell $(OCAMLC) -where) \
-I$(top_srcdir)/src \
-I$(top_srcdir)/fish
libcustomize_a_CFLAGS = \
$(WARN_CFLAGS) $(WERROR_CFLAGS) \
$(LIBVIRT_CFLAGS) \
$(LIBXML2_CFLAGS) \
-fPIC
BOBJECTS = $(SOURCES_ML:.ml=.cmo)
XOBJECTS = $(BOBJECTS:.cmo=.cmx)
if !HAVE_OCAMLOPT
OBJECTS = $(BOBJECTS)
else
OBJECTS = $(XOBJECTS)
endif
# -I $(top_builddir)/src/.libs is a hack which forces corresponding -L
# option to be passed to gcc, so we don't try linking against an
# installed copy of libguestfs.
OCAMLPACKAGES = \
-package str,unix \
-I $(top_builddir)/src/.libs \
-I $(top_builddir)/gnulib/lib/.libs \
-I $(top_builddir)/ocaml \
-I $(top_builddir)/mllib \
-I $(builddir)
if HAVE_OCAML_PKG_GETTEXT
OCAMLPACKAGES += -package gettext-stub
endif
libcustomize_a_DEPENDENCIES = $(OBJECTS)
$(CUSTOMIZE_CMA): $(OBJECTS) libcustomize.a
$(OCAMLFIND) mklib $(OCAMLPACKAGES) \
$(OBJECTS) $(libcustomize_a_OBJECTS) -o customize
# Build the virt-customize program.
bin_PROGRAMS = virt-customize
virt_customize_SOURCES = dummy.c
CUSTOMIZE_BOBJECTS = customize_main.cmo
CUSTOMIZE_XOBJECTS = $(CUSTOMIZE_BOBJECTS:.cmo=.cmx)
if !HAVE_OCAMLOPT
CUSTOMIZE_THEOBJECTS = $(CUSTOMIZE_BOBJECTS)
else
CUSTOMIZE_THEOBJECTS = $(CUSTOMIZE_XOBJECTS)
endif
OCAMLLINKFLAGS = mlguestfs.$(MLARCHIVE) mllib.$(MLARCHIVE) customize.$(MLARCHIVE) $(LINK_CUSTOM_OCAMLC_ONLY)
OCAMLCLIBS = \
-lutils \
$(LIBTINFO_LIBS) \
$(LIBCRYPT_LIBS) \
$(LIBVIRT_LIBS) \
$(LIBXML2_LIBS) \
$(LIBINTL) \
-lgnu
OCAMLFLAGS = $(OCAML_FLAGS) $(OCAML_WARN_ERROR)
virt_customize_DEPENDENCIES = \
$(top_srcdir)/ocaml-link.sh \
$(CUSTOMIZE_THEOBJECTS) \
$(CUSTOMIZE_CMA) \
../mllib/mllib.$(MLARCHIVE)
virt_customize_LINK = \
$(top_srcdir)/ocaml-link.sh -cclib '$(OCAMLCLIBS)' -- \
$(OCAMLFIND) $(BEST) $(OCAMLFLAGS) $(OCAMLPACKAGES) $(OCAMLLINKFLAGS) \
$(CUSTOMIZE_THEOBJECTS) -o $@
# Manual pages and HTML files for the website.
man_MANS = virt-customize.1
noinst_DATA += $(top_builddir)/website/virt-customize.1.html
virt-customize.1 $(top_builddir)/website/virt-customize.1.html: stamp-virt-customize.pod
stamp-virt-customize.pod: virt-customize.pod $(top_srcdir)/customize/customize-synopsis.pod $(top_srcdir)/customize/customize-options.pod
$(PODWRAPPER) \
--man virt-customize.1 \
--html $(top_builddir)/website/virt-customize.1.html \
--insert $(top_srcdir)/customize/customize-synopsis.pod:__CUSTOMIZE_SYNOPSIS__ \
--insert $(top_srcdir)/customize/customize-options.pod:__CUSTOMIZE_OPTIONS__ \
--license GPLv2+ \
--warning general \
$<
touch $@
# Tests.
TESTS_ENVIRONMENT = $(top_builddir)/run --test
TESTS = \
test-virt-customize-docs.sh
if ENABLE_APPLIANCE
TESTS += \
test-virt-customize.sh \
$(SLOW_TESTS)
endif
check-valgrind:
$(MAKE) VG="@VG@" check
# Slow tests of virt-customize functionality in real guests.
SLOW_TESTS = \
$(firstboot_test_scripts) \
$(settings_test_scripts)
check-slow:
$(MAKE) check TESTS="$(SLOW_TESTS)" SLOW=1
firstboot_test_scripts := \
test-firstboot-rhel-4.9.sh \
test-firstboot-rhel-5.11.sh \
test-firstboot-rhel-6.8.sh \
test-firstboot-rhel-7.2.sh \
test-firstboot-debian-6.sh \
test-firstboot-debian-7.sh \
test-firstboot-debian-8.sh \
test-firstboot-fedora-24.sh \
test-firstboot-ubuntu-10.04.sh \
test-firstboot-ubuntu-12.04.sh \
test-firstboot-ubuntu-14.04.sh \
test-firstboot-ubuntu-16.04.sh
# Firstboot is known-broken on RHEL 3:
# test-firstboot-rhel-3.9.sh
test-firstboot-%.sh:
rm -f $@ $@-t
f=`echo "$@" | $(SED) 's/test-firstboot-\(.*\).sh/\1/'`; \
echo 'exec $$srcdir/test-firstboot.sh' "$$f" > $@-t
chmod 0755 $@-t
mv $@-t $@
settings_test_scripts := \
test-settings-rhel-4.9.sh \
test-settings-rhel-5.11.sh \
test-settings-rhel-6.8.sh \
test-settings-rhel-7.2.sh \
test-settings-debian-6.sh \
test-settings-debian-7.sh \
test-settings-debian-8.sh \
test-settings-fedora-24.sh \
test-settings-ubuntu-10.04.sh \
test-settings-ubuntu-12.04.sh \
test-settings-ubuntu-14.04.sh \
test-settings-ubuntu-16.04.sh
# Since firstboot is broken, we cannot test settings in RHEL 3:
# test-settings-rhel-3.9.sh
test-settings-%.sh:
rm -f $@ $@-t
f=`echo "$@" | $(SED) 's/test-settings-\(.*\).sh/\1/'`; \
echo 'exec $$srcdir/test-settings.sh' "$$f" > $@-t
chmod 0755 $@-t
mv $@-t $@
CLEANFILES += \
$(firstboot_test_scripts) \
$(settings_test_scripts) \
firstboot-*.img \
settings-*.img
# Dependencies.
depend: .depend
.depend: $(wildcard $(abs_srcdir)/*.mli) $(wildcard $(abs_srcdir)/*.ml)
rm -f $@ $@-t
$(OCAMLFIND) ocamldep -I ../ocaml -I $(abs_srcdir) -I $(abs_top_builddir)/mllib $^ | \
$(SED) 's/ *$$//' | \
$(SED) -e :a -e '/ *\\$$/N; s/ *\\\n */ /; ta' | \
$(SED) -e 's,$(abs_srcdir)/,$(builddir)/,g' | \
sort > $@-t
mv $@-t $@
-include .depend
endif
.PHONY: depend docs