mirror of
https://github.com/libguestfs/libguestfs.git
synced 2026-03-21 22:53:37 +00:00
During a FileIn command (eg. upload, tar-in) if both sides
experience errors, then both sides could send cancel messages,
the result being lost synchronization.
The reason for the lost synch was because the daemon was ignoring
this case and sending an error message back which the library side
(which had cancelled) was not expecting.
Fix this by checking in the daemon for the case where the library
also cancels during daemon cancellation, and not sending an error
messages.
This also includes an enhanced regression test which checks for this
case.
This extends the original fix in
commit 5922d7084d.
More details can be found here:
https://bugzilla.redhat.com/show_bug.cgi?id=576879#c5
397 lines
8.2 KiB
C
397 lines
8.2 KiB
C
/* libguestfs - the guestfsd daemon
|
|
* Copyright (C) 2009 Red Hat Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <unistd.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/types.h>
|
|
|
|
#include "daemon.h"
|
|
#include "actions.h"
|
|
|
|
/* You must mount something on "/" first, hence: */
|
|
int root_mounted = 0;
|
|
|
|
/* The "simple mount" call offers no complex options, you can just
|
|
* mount a device on a mountpoint. The variations like mount_ro,
|
|
* mount_options and mount_vfs let you set progressively more things.
|
|
*
|
|
* It's tempting to try a direct mount(2) syscall, but that doesn't
|
|
* do any autodetection, so we are better off calling out to
|
|
* /bin/mount.
|
|
*/
|
|
|
|
int
|
|
do_mount_vfs (const char *options, const char *vfstype,
|
|
const char *device, const char *mountpoint)
|
|
{
|
|
int r, is_root;
|
|
char *mp;
|
|
char *error;
|
|
|
|
ABS_PATH (mountpoint, 0, return -1);
|
|
|
|
is_root = STREQ (mountpoint, "/");
|
|
|
|
if (!root_mounted && !is_root) {
|
|
reply_with_error ("you must mount something on / first");
|
|
return -1;
|
|
}
|
|
|
|
mp = sysroot_path (mountpoint);
|
|
if (!mp) {
|
|
reply_with_perror ("malloc");
|
|
return -1;
|
|
}
|
|
|
|
if (vfstype)
|
|
r = command (NULL, &error,
|
|
"mount", "-o", options, "-t", vfstype, device, mp, NULL);
|
|
else
|
|
r = command (NULL, &error,
|
|
"mount", "-o", options, device, mp, NULL);
|
|
free (mp);
|
|
if (r == -1) {
|
|
reply_with_error ("%s on %s: %s", device, mountpoint, error);
|
|
free (error);
|
|
return -1;
|
|
}
|
|
|
|
if (is_root)
|
|
root_mounted = 1;
|
|
|
|
return 0;
|
|
}
|
|
|
|
int
|
|
do_mount (const char *device, const char *mountpoint)
|
|
{
|
|
return do_mount_vfs ("sync,noatime", NULL, device, mountpoint);
|
|
}
|
|
|
|
int
|
|
do_mount_ro (const char *device, const char *mountpoint)
|
|
{
|
|
return do_mount_vfs ("ro", NULL, device, mountpoint);
|
|
}
|
|
|
|
int
|
|
do_mount_options (const char *options, const char *device,
|
|
const char *mountpoint)
|
|
{
|
|
return do_mount_vfs (options, NULL, device, mountpoint);
|
|
}
|
|
|
|
/* Again, use the external /bin/umount program, so that /etc/mtab
|
|
* is kept updated.
|
|
*/
|
|
int
|
|
do_umount (const char *pathordevice)
|
|
{
|
|
int r;
|
|
char *err;
|
|
char *buf;
|
|
int is_dev;
|
|
|
|
is_dev = STREQLEN (pathordevice, "/dev/", 5);
|
|
buf = is_dev ? strdup (pathordevice)
|
|
: sysroot_path (pathordevice);
|
|
if (buf == NULL) {
|
|
reply_with_perror ("malloc");
|
|
return -1;
|
|
}
|
|
|
|
if (is_dev)
|
|
RESOLVE_DEVICE (buf, 0, { free (buf); return -1; });
|
|
|
|
r = command (NULL, &err, "umount", buf, NULL);
|
|
free (buf);
|
|
|
|
if (r == -1) {
|
|
reply_with_error ("%s: %s", pathordevice, err);
|
|
free (err);
|
|
return -1;
|
|
}
|
|
|
|
free (err);
|
|
|
|
/* update root_mounted? */
|
|
|
|
return 0;
|
|
}
|
|
|
|
static char **
|
|
mounts_or_mountpoints (int mp)
|
|
{
|
|
char *out, *err;
|
|
int r;
|
|
char **ret = NULL;
|
|
int size = 0, alloc = 0;
|
|
char *p, *pend, *p2;
|
|
int len;
|
|
char matching[5 + sysroot_len];
|
|
|
|
r = command (&out, &err, "mount", NULL);
|
|
if (r == -1) {
|
|
reply_with_error ("mount: %s", err);
|
|
free (out);
|
|
free (err);
|
|
return NULL;
|
|
}
|
|
|
|
free (err);
|
|
|
|
/* Lines have the format:
|
|
* /dev/foo on /mountpoint type ...
|
|
*/
|
|
snprintf (matching, 5 + sysroot_len, " on %s", sysroot);
|
|
|
|
p = out;
|
|
while (p) {
|
|
pend = strchr (p, '\n');
|
|
if (pend) {
|
|
*pend = '\0';
|
|
pend++;
|
|
}
|
|
|
|
p2 = strstr (p, matching);
|
|
if (p2 != NULL) {
|
|
*p2 = '\0';
|
|
if (add_string (&ret, &size, &alloc, p) == -1) {
|
|
free (out);
|
|
return NULL;
|
|
}
|
|
if (mp) {
|
|
p2 += 4 + sysroot_len; /* skip " on /sysroot" */
|
|
len = strcspn (p2, " ");
|
|
|
|
if (len == 0) /* .. just /sysroot, so we turn it into "/" */
|
|
p2 = (char *) "/";
|
|
else
|
|
p2[len] = '\0';
|
|
|
|
if (add_string (&ret, &size, &alloc, p2) == -1) {
|
|
free (out);
|
|
return NULL;
|
|
}
|
|
}
|
|
}
|
|
|
|
p = pend;
|
|
}
|
|
|
|
free (out);
|
|
|
|
if (add_string (&ret, &size, &alloc, NULL) == -1)
|
|
return NULL;
|
|
|
|
return ret;
|
|
}
|
|
|
|
char **
|
|
do_mounts (void)
|
|
{
|
|
return mounts_or_mountpoints (0);
|
|
}
|
|
|
|
char **
|
|
do_mountpoints (void)
|
|
{
|
|
return mounts_or_mountpoints (1);
|
|
}
|
|
|
|
/* Unmount everything mounted under /sysroot.
|
|
*
|
|
* We have to unmount in the correct order, so we sort the paths by
|
|
* longest first to ensure that child paths are unmounted by parent
|
|
* paths.
|
|
*
|
|
* This call is more important than it appears at first, because it
|
|
* is widely used by both test and production code in order to
|
|
* get back to a known state (nothing mounted, everything synchronized).
|
|
*/
|
|
static int
|
|
compare_longest_first (const void *vp1, const void *vp2)
|
|
{
|
|
char * const *p1 = (char * const *) vp1;
|
|
char * const *p2 = (char * const *) vp2;
|
|
int n1 = strlen (*p1);
|
|
int n2 = strlen (*p2);
|
|
return n2 - n1;
|
|
}
|
|
|
|
int
|
|
do_umount_all (void)
|
|
{
|
|
char *out, *err;
|
|
int i, r;
|
|
char **mounts = NULL;
|
|
int size = 0, alloc = 0;
|
|
char *p, *p2, *p3, *pend;
|
|
char matching[5 + sysroot_len];
|
|
|
|
r = command (&out, &err, "mount", NULL);
|
|
if (r == -1) {
|
|
reply_with_error ("mount: %s", err);
|
|
free (out);
|
|
free (err);
|
|
return -1;
|
|
}
|
|
|
|
free (err);
|
|
|
|
/* Lines have the format:
|
|
* /dev/foo on /mountpoint type ...
|
|
*/
|
|
snprintf (matching, 5 + sysroot_len, " on %s", sysroot);
|
|
|
|
p = out;
|
|
while (p) {
|
|
pend = strchr (p, '\n');
|
|
if (pend) {
|
|
*pend = '\0';
|
|
pend++;
|
|
}
|
|
|
|
p2 = strstr (p, matching);
|
|
if (p2 != NULL) {
|
|
p2 += 4;
|
|
p3 = p2 + strcspn (p2, " ");
|
|
*p3 = '\0';
|
|
if (add_string (&mounts, &size, &alloc, p2) == -1) {
|
|
free (out);
|
|
return -1;
|
|
}
|
|
}
|
|
|
|
p = pend;
|
|
}
|
|
free (out);
|
|
|
|
qsort (mounts, size, sizeof (char *), compare_longest_first);
|
|
|
|
/* Unmount them. */
|
|
for (i = 0; i < size; ++i) {
|
|
r = command (NULL, &err, "umount", mounts[i], NULL);
|
|
if (r == -1) {
|
|
reply_with_error ("umount: %s: %s", mounts[i], err);
|
|
free (err);
|
|
free_stringslen (mounts, size);
|
|
return -1;
|
|
}
|
|
free (err);
|
|
}
|
|
|
|
free_stringslen (mounts, size);
|
|
|
|
/* We've unmounted root now, so ... */
|
|
root_mounted = 0;
|
|
|
|
return 0;
|
|
}
|
|
|
|
/* Mount using the loopback device. You can't use the generic
|
|
* do_mount call for this because the first parameter isn't a
|
|
* device.
|
|
*/
|
|
int
|
|
do_mount_loop (const char *file, const char *mountpoint)
|
|
{
|
|
int r;
|
|
char *buf, *mp;
|
|
char *error;
|
|
|
|
/* We have to prefix /sysroot on both the filename and the mountpoint. */
|
|
mp = sysroot_path (mountpoint);
|
|
if (!mp) {
|
|
reply_with_perror ("malloc");
|
|
return -1;
|
|
}
|
|
|
|
buf = sysroot_path (file);
|
|
if (!file) {
|
|
reply_with_perror ("malloc");
|
|
free (mp);
|
|
return -1;
|
|
}
|
|
|
|
r = command (NULL, &error, "mount", "-o", "loop", buf, mp, NULL);
|
|
free (mp);
|
|
free (buf);
|
|
if (r == -1) {
|
|
reply_with_error ("%s on %s: %s", file, mountpoint, error);
|
|
free (error);
|
|
return -1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
/* Specialized calls mkmountpoint and rmmountpoint are really
|
|
* variations on mkdir and rmdir which do no checking and (in the
|
|
* mkmountpoint case) set the root_mounted flag.
|
|
*/
|
|
int
|
|
do_mkmountpoint (const char *path)
|
|
{
|
|
int r;
|
|
|
|
/* NEED_ROOT (return -1); - we don't want this test for this call. */
|
|
ABS_PATH (path, 0, return -1);
|
|
|
|
CHROOT_IN;
|
|
r = mkdir (path, 0777);
|
|
CHROOT_OUT;
|
|
|
|
if (r == -1) {
|
|
reply_with_perror ("%s", path);
|
|
return -1;
|
|
}
|
|
|
|
/* Set the flag so that filesystems can be mounted here,
|
|
* not just on /sysroot.
|
|
*/
|
|
root_mounted = 1;
|
|
|
|
return 0;
|
|
}
|
|
|
|
int
|
|
do_rmmountpoint (const char *path)
|
|
{
|
|
int r;
|
|
|
|
/* NEED_ROOT (return -1); - we don't want this test for this call. */
|
|
ABS_PATH (path, 0, return -1);
|
|
|
|
CHROOT_IN;
|
|
r = rmdir (path);
|
|
CHROOT_OUT;
|
|
|
|
if (r == -1) {
|
|
reply_with_perror ("%s", path);
|
|
return -1;
|
|
}
|
|
|
|
return 0;
|
|
}
|