Files
libguestfs/daemon/swap.c
Richard W.M. Jones f23a5c468e Modified API: mkswap now takes optional arguments.
Add optional label and uuid arguments, and deprecate mkswap-L and
mkswap-U.

This also adds a call to udev_settle after creating the swap device.
This is an attempt to workaround the following problem seen in Koji
and Rawhide:

libguestfs: trace: mkswap_L "swapit" "/dev/sda1"
libguestfs: send_to_daemon: 72 bytes: 00 00 00 44 | 20 00 f5 f5 | 00 00 00 04 | 00 00 00 83 | 00 00 00 00 | ...
guestfsd: main_loop: proc 210 (part_disk) took 2.28 seconds
guestfsd: main_loop: new request, len 0x44
mkswap -f -L swapit /dev/sda1
libguestfs: recv_from_daemon: 40 bytes: 20 00 f5 f5 | 00 00 00 04 | 00 00 00 83 | 00 00 00 01 | 00 12 37 cf | ...
libguestfs: trace: mkswap_L = 0
libguestfs: trace: swapon_label "swapit"
libguestfs: send_to_daemon: 56 bytes: 00 00 00 34 | 20 00 f5 f5 | 00 00 00 04 | 00 00 00 ae | 00 00 00 00 | ...
guestfsd: main_loop: proc 131 (mkswap_L) took 0.77 seconds
guestfsd: main_loop: new request, len 0x34
swapon -L swapit
swapon: cannot find the device for swapit
guestfsd: error: swapit: swapon: cannot find the device for swapit
libguestfs: recv_from_daemon: 100 bytes: 20 00 f5 f5 | 00 00 00 04 | 00 00 00 ae | 00 00 00 01 | 00 12 37 d0 | ...
libguestfs: trace: swapon_label = -1 (error)
swapon_label: swapit: swapon: cannot find the device for swapit
test_swapon_label_0 FAILED
2012-08-28 04:44:05 -04:00

254 lines
5.1 KiB
C

/* libguestfs - the guestfsd daemon
* Copyright (C) 2009 Red Hat Inc.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
#include <config.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
#include "guestfs_protocol.h"
#include "daemon.h"
#include "actions.h"
#include "optgroups.h"
#include "ignore-value.h"
/* Confirmed this is true for Linux swap partitions from the Linux sources. */
#define SWAP_LABEL_MAX 16
/* Convenient place to test for the later version of e2fsprogs
* and util-linux which supports -U parameters to specify UUIDs.
* (Not supported in RHEL 5).
*/
int
optgroup_linuxfsuuid_available (void)
{
char *err;
int av;
/* Upstream util-linux have been gradually changing '--help' to go
* from stderr to stdout, and changing the return code from 1 to 0.
* Thus we need to fold stdout and stderr together, and ignore the
* return code.
*/
ignore_value (commandf (NULL, &err, COMMAND_FLAG_FOLD_STDOUT_ON_STDERR,
"mkswap", "--help", NULL));
av = strstr (err, "-U") != NULL;
free (err);
return av;
}
/* Takes optional arguments, consult optargs_bitmask. */
int
do_mkswap (const char *device, const char *label, const char *uuid)
{
const size_t MAX_ARGS = 64;
const char *argv[MAX_ARGS];
size_t i = 0;
int r;
char *err;
ADD_ARG (argv, i, "mkswap");
ADD_ARG (argv, i, "-f");
if (optargs_bitmask & GUESTFS_MKSWAP_LABEL_BITMASK) {
if (strlen (label) > SWAP_LABEL_MAX) {
reply_with_error ("%s: Linux swap labels are limited to %d bytes",
label, SWAP_LABEL_MAX);
return -1;
}
ADD_ARG (argv, i, "-L");
ADD_ARG (argv, i, label);
}
if (optargs_bitmask & GUESTFS_MKSWAP_UUID_BITMASK) {
ADD_ARG (argv, i, "-U");
ADD_ARG (argv, i, uuid);
}
ADD_ARG (argv, i, device);
ADD_ARG (argv, i, NULL);
r = commandv (NULL, &err, argv);
if (r == -1) {
reply_with_error ("%s: %s", device, err);
free (err);
return -1;
}
free (err);
udev_settle ();
return 0;
}
int
do_mkswap_L (const char *label, const char *device)
{
optargs_bitmask = GUESTFS_MKSWAP_LABEL_BITMASK;
return do_mkswap (device, label, NULL);
}
int
do_mkswap_U (const char *uuid, const char *device)
{
optargs_bitmask = GUESTFS_MKSWAP_UUID_BITMASK;
return do_mkswap (device, NULL, uuid);
}
int
do_mkswap_file (const char *path)
{
char *buf;
char *err;
int r;
buf = sysroot_path (path);
if (!buf) {
reply_with_perror ("malloc");
return -1;
}
r = command (NULL, &err, "mkswap", "-f", buf, NULL);
free (buf);
if (r == -1) {
reply_with_error ("%s: %s", path, err);
free (err);
return -1;
}
free (err);
return r;
}
static int
swaponoff (const char *cmd, const char *flag, const char *value)
{
char *err;
int r;
if (!flag)
r = command (NULL, &err, cmd, value, NULL);
else
r = command (NULL, &err, cmd, flag, value, NULL);
if (r == -1) {
reply_with_error ("%s: %s", value, err);
free (err);
return -1;
}
free (err);
/* Possible fix for RHBZ#516096. It probably doesn't hurt to do
* this in any case.
*/
udev_settle ();
return 0;
}
int
do_swapon_device (const char *device)
{
return swaponoff ("swapon", NULL, device);
}
int
do_swapoff_device (const char *device)
{
return swaponoff ("swapoff", NULL, device);
}
int
do_swapon_file (const char *path)
{
char *buf;
int r;
buf = sysroot_path (path);
if (!buf) {
reply_with_perror ("malloc");
return -1;
}
r = swaponoff ("swapon", NULL, buf);
free (buf);
return r;
}
int
do_swapoff_file (const char *path)
{
char *buf;
int r;
buf = sysroot_path (path);
if (!buf) {
reply_with_perror ("malloc");
return -1;
}
r = swaponoff ("swapoff", NULL, buf);
free (buf);
return r;
}
int
do_swapon_label (const char *label)
{
if (strlen (label) > SWAP_LABEL_MAX) {
reply_with_error ("%s: Linux swap labels are limited to %d bytes",
label, SWAP_LABEL_MAX);
return -1;
}
return swaponoff ("swapon", "-L", label);
}
int
do_swapoff_label (const char *label)
{
if (strlen (label) > SWAP_LABEL_MAX) {
reply_with_error ("%s: Linux swap labels are limited to %d bytes",
label, SWAP_LABEL_MAX);
return -1;
}
return swaponoff ("swapoff", "-L", label);
}
int
do_swapon_uuid (const char *uuid)
{
return swaponoff ("swapon", "-U", uuid);
}
int
do_swapoff_uuid (const char *uuid)
{
return swaponoff ("swapoff", "-U", uuid);
}