From fa42781cb9ef07cebc7d4cee7e0618392112d82d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira=20Rolim?=
 <34201958+ericonr@users.noreply.github.com>
Date: Sat, 1 Feb 2020 14:23:25 -0300
Subject: [PATCH] Make the project compilable with clang. (#163)

Clang generates more warning messages, such as pointing out a lack
of newline at end of file and issues with the size of a strncopy.

Moving -Wno-unused-parameter to the end of the flags avoids it being
overwritten by -Wextra.

Removing -Werror avoids compilation errors that may arise from new
compiler warnings that might come from newer versions of compilers.
---
 makefile    | 2 +-
 src/login.c | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/makefile b/makefile
index 00e67d3..57847c1 100644
--- a/makefile
+++ b/makefile
@@ -1,7 +1,7 @@
 NAME = ly
 CC = gcc
 FLAGS = -std=c99 -pedantic -g
-FLAGS+= -Wall -Wno-unused-parameter -Wextra -Werror=vla -Werror
+FLAGS+= -Wall -Wextra -Werror=vla -Wno-unused-parameter
 #FLAGS+= -DDEBUG
 FLAGS+= -DGIT_VERSION_STRING=\"$(shell git describe --long --tags | sed 's/\([^-]*-g\)/r\1/;s/-/./g')\"
 LINK = -lpam -lxcb
diff --git a/src/login.c b/src/login.c
index 11cd938..361df01 100644
--- a/src/login.c
+++ b/src/login.c
@@ -431,7 +431,7 @@ void shell(struct passwd* pwd)
 		pos = pwd->pw_shell;
 	}
 
-	strncpy(args + 1, pos, 1024);
+	strncpy(args + 1, pos, 1023);
 	execl(pwd->pw_shell, args, NULL);
 }
 
@@ -671,4 +671,5 @@ void auth(
 	{
 		pam_diagnose(ok, buf);
 	}
-}
\ No newline at end of file
+}
+