going off the deep end with with generic message type

build.zig.zon

@@ -45,8 +45,8 @@
             .hash = "clap-0.10.0-oBajB434AQBDh-Ei3YtoKIRxZacVPF1iSwp3IX_ZB8f0",
         },
         .gatorcat = .{
-            .url = "git+https://github.com/kj4tmp/gatorcat.git#0a97b666677501db4939e3e8245f88a19e015893",
+            .url = "git+https://github.com/kj4tmp/gatorcat#bb1847f6c95852e7a0ec8c07870a948c171d5f98",
-            .hash = "gatorcat-0.3.4-WcrpTcleBwCta_9TjomuIGb3bdg2Pke_FXI_WkMTEivH",
+            .hash = "gatorcat-0.3.2-WcrpTf1mBwDrmPaIhKCfLJO064v8Sjjn7DBq4CKZSgHH",
         },
     },
     .paths = .{

src/Client.zig

@@ -1,86 +1,28 @@
 const base64Enc = std.base64.Base64Encoder.init(std.base64.standard_alphabet_chars, '=');
 const base64Dec = std.base64.Base64Decoder.init(std.base64.standard_alphabet_chars, '=');
 
-rand: Random,
+var rand: ?Random = null;
-socket: gcat.nic.RawSocket,
 
-const Self = @This();
+pub fn init() !void {
-
-const max_message_size = 2048;
-
-pub fn init(interface_name: [:0]const u8) !Self {
     var prng = Random.DefaultPrng.init(blk: {
         var seed: u64 = undefined;
         try posix.getrandom(mem.asBytes(&seed));
         break :blk seed;
     });
-    const rand = prng.random();
+    rand = prng.random();
-
+    try network.init();
-    const socket: gcat.nic.RawSocket = try .init(interface_name);
-
-    return .{
-        .rand = rand,
-        .socket = socket,
-    };
 }
 
-pub fn deinit(self: *Self) void {
+pub fn deinit() void {
-    self.socket.deinit();
+    network.deinit();
 }
 
-/// Used for relay messages and connection handshake.
+fn broadcastSaprusMessage(msg: *SaprusMessage, udp_port: u16) !void {
-/// Assumes Client .init has been called.
-fn broadcastInitialInterestMessage(self: *Self, msg_bytes: []align(@alignOf(SaprusMessage)) u8) !void {
-    var packet_bytes: [max_message_size]u8 = comptime blk: {
-        var b: [max_message_size]u8 = @splat(0);
-
-        // Destination MAC addr to FF:FF:FF:FF:FF:FF
-        for (0..6) |i| {
-            b[i] = 0xff;
-        }
-
-        // Set Ethernet type to IPv4
-        b[0x0c] = 0x08;
-        b[0x0d] = 0x00;
-
-        // Set IPv4 version to 4
-        b[0x0e] = 0x45;
-
-        // Destination broadcast
-        for (0x1e..0x22) |i| {
-            b[i] = 0xff;
-        }
-
-        // Set TTL
-        b[0x16] = 0x40;
-
-        // Set IPv4 protocol to UDP
-        b[0x17] = 0x11;
-
-        // Set interest filter value to 8888.
-        b[0x24] = 0x22;
-        b[0x25] = 0xb8;
-        break :blk b;
-    };
-    var msg: *SaprusMessage = try .bytesAsValue(msg_bytes);
-    try msg.networkFromNativeEndian();
-    defer msg.nativeFromNetworkEndian() catch unreachable;
-
-    // The byte position within the packet that the saprus message starts at.
-    const saprus_start_byte = 42;
-    @memcpy(packet_bytes[saprus_start_byte .. saprus_start_byte + msg_bytes.len], msg_bytes);
-
-    try self.socket.linkLayer().send(packet_bytes[0 .. saprus_start_byte + msg_bytes.len]);
-}
-
-// fn broadcastSaprusMessage(msg_bytes: []align(@alignOf(SaprusMessage)) u8) !void {}
-
-fn broadcastSaprusMessage(msg_bytes: []align(@alignOf(SaprusMessage)) u8, udp_port: u16) !void {
     if (false) {
         var foo: gcat.nic.RawSocket = try .init("enp7s0"); // /proc/net/dev
         defer foo.deinit();
     }
-    const msg: *SaprusMessage = try .bytesAsValue(msg_bytes);
+    const msg_bytes = msg.asBytes();
     try msg.networkFromNativeEndian();
     defer msg.nativeFromNetworkEndian() catch unreachable;
 
@@ -102,57 +44,52 @@ fn broadcastSaprusMessage(msg_bytes: []align(@alignOf(SaprusMessage)) u8, udp_po
 
     try sock.bind(bind_addr);
 
-    std.debug.print("{x}\n", .{msg_bytes});
-
     _ = try sock.sendTo(dest_addr, msg_bytes);
 }
 
-pub fn sendRelay(self: *Self, payload: []const u8, dest: [4]u8) !void {
+pub fn sendRelay(payload: []const u8, dest: [4]u8, allocator: Allocator) !void {
-    var buf: [max_message_size]u8 align(@alignOf(SaprusMessage)) = undefined;
+    const msg: *SaprusMessageNew(.relay) = try .init(
-    const msg_bytes = buf[0..try SaprusMessage.calcSize(
+        allocator,
-        .relay,
+        @intCast(base64Enc.calcSize(payload.len)),
-        base64Enc.calcSize(payload.len),
+    );
-    )];
+    defer msg.deinit(allocator);
-    const msg: *SaprusMessage = .init(.relay, msg_bytes);
+    msg.dest = dest;
+    _ = base64Enc.encode(msg.getPayload(), payload);
 
-    const relay = (try msg.getSaprusTypePayload()).relay;
+    try broadcastSaprusMessage(try SaprusMessage.bytesAsValue(msg.asBytes()), 8888);
-    relay.dest = dest;
-    _ = base64Enc.encode(relay.getPayload(), payload);
-
-    try self.broadcastInitialInterestMessage(msg_bytes);
 }
 
-fn randomPort(self: Self) u16 {
+fn randomPort() u16 {
-    return self.rand.intRangeAtMost(u16, 1024, 65000);
+    var p: u16 = 0;
+    if (rand) |r| {
+        p = r.intRangeAtMost(u16, 1024, 65000);
+    } else unreachable;
+
+    return p;
 }
 
-pub fn sendInitialConnection(
+pub fn sendInitialConnection(payload: []const u8, initial_port: u16, allocator: Allocator) !*SaprusMessage {
-    self: Self,
+    const dest_port = randomPort();
-    payload: []const u8,
+    const msg: *SaprusMessage = try .init(allocator, .connection, @intCast(payload.len));
-    output_bytes: []align(@alignOf(SaprusMessage)) u8,
+    defer msg.deinit(allocator);
-    initial_port: u16,
-) !*SaprusMessage {
-    const dest_port = self.randomPort();
-    const msg_bytes = output_bytes[0..try SaprusMessage.calcSize(
-        .connection,
-        base64Enc.calcSize(payload.len),
-    )];
-    const msg: *SaprusMessage = .init(.connection, msg_bytes);
-
     const connection = (try msg.getSaprusTypePayload()).connection;
     connection.src_port = initial_port;
     connection.dest_port = dest_port;
-    _ = base64Enc.encode(connection.getPayload(), payload);
+    @memcpy(connection.getPayload(), payload);
 
-    try broadcastSaprusMessage(msg_bytes, 8888);
+    try broadcastSaprusMessage(msg, 8888);
 
     return msg;
 }
 
-pub fn connect(self: Self, payload: []const u8) !?SaprusConnection {
+pub fn connect(payload: []const u8, allocator: Allocator) !?SaprusConnection {
-    const initial_port = self.randomPort();
+    var initial_port: u16 = 0;
+    if (rand) |r| {
+        initial_port = r.intRangeAtMost(u16, 1024, 65000);
+    } else unreachable;
 
-    var initial_conn_res: ?*SaprusMessage = null;
+    var initial_conn_res: ?SaprusMessage = null;
+    errdefer if (initial_conn_res) |*c| c.deinit(allocator);
 
     var sock = try network.Socket.create(.ipv4, .udp);
     defer sock.close();
@@ -167,17 +104,17 @@ pub fn connect(self: Self, payload: []const u8) !?SaprusConnection {
     try sock.setReadTimeout(1 * std.time.us_per_s);
     try sock.bind(bind_addr);
 
-    var sent_msg_bytes: [max_message_size]u8 align(@alignOf(SaprusMessage)) = undefined;
+    const msg = try sendInitialConnection(payload, initial_port, allocator);
-    const msg = try self.sendInitialConnection(payload, &sent_msg_bytes, initial_port);
 
-    var response_buf: [max_message_size]u8 align(@alignOf(SaprusMessage)) = undefined;
+    var response_buf: [4096]u8 align(4) = @splat(0);
     _ = try sock.receive(&response_buf); // Ignore message that I sent.
     const len = try sock.receive(&response_buf);
 
-    initial_conn_res = try .networkBytesAsValue(response_buf[0..len]);
+    std.debug.print("response bytes: {x}\n", .{response_buf});
+    initial_conn_res = (try SaprusMessage.bytesAsValue(response_buf[0..len])).*;
 
     // Complete handshake after awaiting response
-    try broadcastSaprusMessage(msg.asBytes(), self.randomPort());
+    try broadcastSaprusMessage(msg, randomPort());
 
     if (false) {
         return initial_conn_res.?;
@@ -186,6 +123,7 @@ pub fn connect(self: Self, payload: []const u8) !?SaprusConnection {
 }
 
 const SaprusMessage = @import("message.zig").Message;
+const SaprusMessageNew = @import("message.zig").MessageNew;
 const SaprusConnection = @import("Connection.zig");
 
 const std = @import("std");
@@ -195,3 +133,5 @@ const mem = std.mem;
 
 const network = @import("network");
 const gcat = @import("gatorcat");
+
+const Allocator = mem.Allocator;

src/main.zig

@@ -42,23 +42,24 @@ pub fn main() !void {
     };
     defer res.deinit();
 
+    try SaprusClient.init();
+    defer SaprusClient.deinit();
+
     if (res.args.help != 0) {
         return clap.help(std.io.getStdErr().writer(), clap.Help, &params, .{});
     }
 
-    var client = try SaprusClient.init("enp7s0");
-    defer client.deinit();
-
     if (res.args.relay) |r| {
         const dest = parseDest(res.args.dest);
-        try client.sendRelay(
+        try SaprusClient.sendRelay(
             if (r.len > 0) r else "Hello darkness my old friend",
             dest,
+            gpa,
         );
         // std.debug.print("Sent: {s}\n", .{r});
         return;
     } else if (res.args.connect) |c| {
-        _ = client.connect(if (c.len > 0) c else "Hello darkness my old friend") catch |err| switch (err) {
+        _ = SaprusClient.connect(if (c.len > 0) c else "Hello darkness my old friend", gpa) catch |err| switch (err) {
             error.WouldBlock => null,
             else => return err,
         };

src/message.zig

@@ -20,14 +20,130 @@ pub const ConnectionOptions = packed struct(u8) {
     opt8: bool = false,
 };
 
-pub const MessageTypeError = error{
+pub const Error = error{
     NotImplementedSaprusType,
     UnknownSaprusType,
-};
-pub const MessageParseError = MessageTypeError || error{
     InvalidMessage,
 };
 
+pub fn MessageNew(comptime packet_type: PacketType) type {
+    comptime {
+        if (packet_type == .file_transfer)
+            @compileError("File transfer not implemented");
+        if (packet_type != .relay and packet_type != .connection)
+            @compileError("Unkown message type");
+    }
+
+    return packed struct {
+        const Self = @This();
+        const SelfBytes = []align(@alignOf(Self)) u8;
+
+        const Relay = struct {
+            pub fn getPayload(self: *Self) []u8 {
+                return @as([*]align(@alignOf(Self)) u8, @ptrCast(&self.payload))[0 .. self.length - 4];
+            }
+        };
+        const Connection = packed struct {
+            pub fn getPayload(self: Self) []u8 {
+                return @as([*]u8, &self.payload)[0 .. self.length - 4];
+            }
+        };
+
+        type: PacketType = packet_type,
+        length: u16,
+
+        // Relay
+        dest: if (packet_type == .relay) @Vector(4, u8) else void,
+
+        // Connection
+        src_port: if (packet_type == .connection) u16 else void, // random number > 1024
+        dest_port: if (packet_type == .connection) u16 else void, // random number > 1024
+        seq_num: if (packet_type == .connection) u32 else void,
+        msg_id: if (packet_type == .connection) u32 else void,
+        reserved: if (packet_type == .connection) u8 else void,
+        options: if (packet_type == .connection) ConnectionOptions else void = if (packet_type == .connection) .{} else {},
+
+        // Relay or Connection
+        payload: switch (packet_type) {
+            .relay, .connection => void,
+            else => noreturn,
+        },
+
+        pub usingnamespace switch (packet_type) {
+            .relay => Relay,
+            .connection => Connection,
+            .file_transfer => @compileError("File Transfer message type not implemented"),
+            else => @compileError("Unknown message type"),
+        };
+
+        pub fn init(allocator: Allocator, payload_len: u16) !*Self {
+            const size = payload_len + @sizeOf(Self);
+            const bytes = try allocator.alignedAlloc(u8, @alignOf(Self), size);
+            const res: *Self = @ptrCast(bytes.ptr);
+            res.type = packet_type;
+            res.length = payload_len;
+            return res;
+        }
+
+        pub fn deinit(self: *Self, allocator: Allocator) void {
+            allocator.free(self.asBytes());
+        }
+
+        pub fn nativeFromNetworkEndian(self: *Self) void {
+            self.type = @enumFromInt(bigToNative(
+                @typeInfo(@TypeOf(self.type)).@"enum".tag_type,
+                @intFromEnum(self.type),
+            ));
+            self.length = bigToNative(@TypeOf(self.length), self.length);
+
+            if (packet_type == .connection) {
+                self.src_port = bigToNative(@TypeOf(self.src_port), self.src_port);
+                self.dest_port = bigToNative(@TypeOf(self.dest_port), self.dest_port);
+                self.seq_num = bigToNative(@TypeOf(self.seq_num), self.seq_num);
+                self.msg_id = bigToNative(@TypeOf(self.msg_id), self.msg_id);
+            }
+        }
+
+        pub fn networkFromNativeEndian(self: *Self) void {
+            self.type = @enumFromInt(bigToNative(
+                @typeInfo(@TypeOf(self.type)).@"enum".tag_type,
+                @intFromEnum(self.type),
+            ));
+            self.length = bigToNative(@TypeOf(self.length), self.length);
+
+            if (packet_type == .connection) {
+                self.src_port = nativeToBig(@TypeOf(self.src_port), self.src_port);
+                self.dest_port = nativeToBig(@TypeOf(self.dest_port), self.dest_port);
+                self.seq_num = nativeToBig(@TypeOf(self.seq_num), self.seq_num);
+                self.msg_id = nativeToBig(@TypeOf(self.msg_id), self.msg_id);
+            }
+        }
+
+        pub fn asBytes(self: *Self) SelfBytes {
+            const size = @sizeOf(Self) + self.length;
+            return @as([*]align(@alignOf(Self)) u8, @ptrCast(self))[0..size];
+        }
+    };
+}
+
+test MessageNew {
+    comptime for (@typeInfo(MessageNew(.connection)).@"struct".decls) |field| {
+        @compileLog(field);
+    };
+}
+
+// pub fn bytesAsMessage(bytes: []const u8) !*Self {
+//     const res = std.mem.bytesAsValue(Self, bytes);
+//     return switch (res.type) {
+//         .relay, .connection => if (bytes.len == res.length + @sizeOf(Self))
+//             res
+//         else
+//             Error.InvalidMessage,
+//         .file_transfer => Error.NotImplementedSaprusType,
+//         else => Error.UnknownSaprusType,
+//     };
+// }
+
 // ZERO COPY STUFF
 // &payload could be a void value that is treated as a pointer to a [*]u8
 /// All Saprus messages
@@ -38,7 +154,7 @@ pub const Message = packed struct {
 
         pub fn getPayload(self: *align(1) Relay) []u8 {
             const len: *u16 = @ptrFromInt(@intFromPtr(self) - @sizeOf(u16));
-            return @as([*]u8, @ptrCast(&self.payload))[0 .. len.* - @bitSizeOf(Relay) / 8];
+            return @as([*]u8, @ptrCast(&self.payload))[0 .. len.* - @sizeOf(Relay)];
         }
     };
     const Connection = packed struct {
@@ -52,7 +168,7 @@ pub const Message = packed struct {
 
         pub fn getPayload(self: *align(1) Connection) []u8 {
             const len: *u16 = @ptrFromInt(@intFromPtr(self) - @sizeOf(u16));
-            return @as([*]u8, @ptrCast(&self.payload))[0 .. len.* - @bitSizeOf(Connection) / 8];
+            return @as([*]u8, @ptrCast(&self.payload))[0 .. len.* - @sizeOf(Connection)];
         }
 
         fn nativeFromNetworkEndian(self: *align(1) Connection) void {
@@ -77,27 +193,23 @@ pub const Message = packed struct {
     length: u16,
     bytes: void = {},
 
-    /// Takes a byte slice, and returns a Message struct backed by the slice.
+    pub fn init(allocator: Allocator, comptime @"type": PacketType, payload_len: u16) !*Self {
-    /// This properly initializes the top level headers within the slice.
+        const header_size = @sizeOf(switch (@"type") {
-    /// This is used for creating new messages. For reading messages from the network,
+            .relay => Relay,
-    /// see: networkBytesAsValue.
+            .connection => Connection,
-    pub fn init(@"type": PacketType, bytes: []align(@alignOf(Self)) u8) *Self {
+            .file_transfer => return Error.NotImplementedSaprusType,
-        std.debug.assert(bytes.len >= @sizeOf(Self));
+            else => return Error.UnknownSaprusType,
+        });
+        const size = payload_len + @sizeOf(Self) + header_size;
+        const bytes = try allocator.alignedAlloc(u8, @alignOf(Self), size);
         const res: *Self = @ptrCast(bytes.ptr);
         res.type = @"type";
-        res.length = @intCast(bytes.len - @sizeOf(Self));
+        res.length = payload_len + header_size;
         return res;
     }
 
-    /// Compute the number of bytes required to store a given payload size for a given message type.
+    pub fn deinit(self: *Self, allocator: Allocator) void {
-    pub fn calcSize(comptime @"type": PacketType, payload_len: usize) MessageTypeError!u16 {
+        allocator.free(self.asBytes());
-        const header_size = @bitSizeOf(switch (@"type") {
-            .relay => Relay,
-            .connection => Connection,
-            .file_transfer => return MessageTypeError.NotImplementedSaprusType,
-            else => return MessageTypeError.UnknownSaprusType,
-        }) / 8;
-        return @intCast(payload_len + @sizeOf(Self) + header_size);
     }
 
     fn getRelay(self: *Self) *align(1) Relay {
@@ -107,8 +219,7 @@ pub const Message = packed struct {
         return std.mem.bytesAsValue(Connection, &self.bytes);
     }
 
-    /// Access the message Saprus payload.
+    pub fn getSaprusTypePayload(self: *Self) Error!(union(PacketType) {
-    pub fn getSaprusTypePayload(self: *Self) MessageTypeError!(union(PacketType) {
         relay: *align(1) Relay,
         file_transfer: void,
         connection: *align(1) Connection,
@@ -116,13 +227,12 @@ pub const Message = packed struct {
         return switch (self.type) {
             .relay => .{ .relay = self.getRelay() },
             .connection => .{ .connection = self.getConnection() },
-            .file_transfer => MessageTypeError.NotImplementedSaprusType,
+            .file_transfer => Error.NotImplementedSaprusType,
-            else => MessageTypeError.UnknownSaprusType,
+            else => Error.UnknownSaprusType,
         };
     }
 
-    /// Convert the message to native endianness from network endianness in-place.
+    pub fn nativeFromNetworkEndian(self: *Self) Error!void {
-    pub fn nativeFromNetworkEndian(self: *Self) MessageTypeError!void {
         self.type = @enumFromInt(bigToNative(
             @typeInfo(@TypeOf(self.type)).@"enum".tag_type,
             @intFromEnum(self.type),
@@ -145,13 +255,12 @@ pub const Message = packed struct {
         }
     }
 
-    /// Convert the message to network endianness from native endianness in-place.
+    pub fn networkFromNativeEndian(self: *Self) Error!void {
-    pub fn networkFromNativeEndian(self: *Self) MessageTypeError!void {
         try switch (try self.getSaprusTypePayload()) {
             .relay => {},
             .connection => |*con| con.*.networkFromNativeEndian(),
-            .file_transfer => MessageTypeError.NotImplementedSaprusType,
+            .file_transfer => Error.NotImplementedSaprusType,
-            else => MessageTypeError.UnknownSaprusType,
+            else => Error.UnknownSaprusType,
         };
         self.type = @enumFromInt(nativeToBig(
             @typeInfo(@TypeOf(self.type)).@"enum".tag_type,
@@ -160,29 +269,18 @@ pub const Message = packed struct {
         self.length = nativeToBig(@TypeOf(self.length), self.length);
     }
 
-    /// Convert network endian bytes to a native endian value in-place.
+    pub fn bytesAsValue(bytes: SelfBytes) !*Self {
-    pub fn networkBytesAsValue(bytes: SelfBytes) MessageParseError!*Self {
-        const res = std.mem.bytesAsValue(Self, bytes);
-        try res.nativeFromNetworkEndian();
-        return .bytesAsValue(bytes);
-    }
-
-    /// Create a structured view of the bytes without initializing the length or type,
-    /// and without converting the endianness.
-    pub fn bytesAsValue(bytes: SelfBytes) MessageParseError!*Self {
         const res = std.mem.bytesAsValue(Self, bytes);
         return switch (res.type) {
             .relay, .connection => if (bytes.len == res.length + @sizeOf(Self))
                 res
             else
-                MessageParseError.InvalidMessage,
+                Error.InvalidMessage,
-            .file_transfer => MessageParseError.NotImplementedSaprusType,
+            .file_transfer => Error.NotImplementedSaprusType,
-            else => MessageParseError.UnknownSaprusType,
+            else => Error.UnknownSaprusType,
         };
     }
 
-    /// Deprecated.
-    /// If I need the bytes, I should just pass around the slice that is backing this to begin with.
     pub fn asBytes(self: *Self) SelfBytes {
         const size = @sizeOf(Self) + self.length;
         return @as([*]align(@alignOf(Self)) u8, @ptrCast(self))[0..size];
@@ -190,13 +288,12 @@ pub const Message = packed struct {
 };
 
 test "testing variable length zero copy struct" {
-    {
+    const gpa = std.testing.allocator;
-        // Relay test
     const payload = "Hello darkness my old friend";
-        var msg_bytes: [try Message.calcSize(.relay, payload.len)]u8 align(@alignOf(Message)) = undefined;
 
     // Create a view of the byte slice as a Message
-        const msg: *Message = .init(.relay, &msg_bytes);
+    const msg: *Message = try .init(gpa, .relay, payload.len);
+    defer msg.deinit(gpa);
 
     {
         // Set the message values
@@ -211,13 +308,15 @@ test "testing variable length zero copy struct" {
     }
 
     {
+        const bytes = msg.asBytes();
+
         // Print the message as hex using the network byte order
         try msg.networkFromNativeEndian();
         // We know the error from nativeFromNetworkEndian is unreachable because
         // it would have returned an error from networkFromNativeEndian.
         defer msg.nativeFromNetworkEndian() catch unreachable;
-            std.debug.print("relay network bytes: {x}\n", .{msg_bytes});
+        std.debug.print("network bytes: {x}\n", .{bytes});
-            std.debug.print("bytes len: {d}\n", .{msg_bytes.len});
+        std.debug.print("bytes len: {d}\n", .{bytes.len});
     }
 
     if (false) {
@@ -228,38 +327,6 @@ test "testing variable length zero copy struct" {
     try std.testing.expectEqualDeep(msg, try Message.bytesAsValue(msg.asBytes()));
 }
 
-    {
-        // Connection test
-        const payload = "Hello darkness my old friend";
-        var msg_bytes: [try Message.calcSize(.connection, payload.len)]u8 align(@alignOf(Message)) = undefined;
-
-        // Create a view of the byte slice as a Message
-        const msg: *Message = .init(.connection, &msg_bytes);
-
-        {
-            // Initializing connection header values
-            const connection = (try msg.getSaprusTypePayload()).connection;
-            connection.src_port = 1;
-            connection.dest_port = 2;
-            connection.seq_num = 3;
-            connection.msg_id = 4;
-            connection.reserved = 5;
-            connection.options = @bitCast(@as(u8, 6));
-            @memcpy(connection.getPayload(), payload);
-        }
-
-        {
-            // Print the message as hex using the network byte order
-            try msg.networkFromNativeEndian();
-            // We know the error from nativeFromNetworkEndian is unreachable because
-            // it would have returned an error from networkFromNativeEndian.
-            defer msg.nativeFromNetworkEndian() catch unreachable;
-            std.debug.print("connection network bytes: {x}\n", .{msg_bytes});
-            std.debug.print("bytes len: {d}\n", .{msg_bytes.len});
-        }
-    }
-}
-
 const std = @import("std");
 const Allocator = std.mem.Allocator;
 
@@ -267,51 +334,6 @@ const asBytes = std.mem.asBytes;
 const nativeToBig = std.mem.nativeToBig;
 const bigToNative = std.mem.bigToNative;
 
-test "Round trip Relay toBytes and fromBytes" {
-    if (false) {
-        const gpa = std.testing.allocator;
-        const msg = Message{
-            .relay = .{
-                .header = .{ .dest = .{ 255, 255, 255, 255 } },
-                .payload = "Hello darkness my old friend",
-            },
-        };
-
-        const to_bytes = try msg.toBytes(gpa);
-        defer gpa.free(to_bytes);
-
-        const from_bytes = try Message.fromBytes(to_bytes, gpa);
-        defer from_bytes.deinit(gpa);
-
-        try std.testing.expectEqualDeep(msg, from_bytes);
-    }
-    return error.SkipZigTest;
-}
-
-test "Round trip Connection toBytes and fromBytes" {
-    if (false) {
-        const gpa = std.testing.allocator;
-        const msg = Message{
-            .connection = .{
-                .header = .{
-                    .src_port = 0,
-                    .dest_port = 0,
-                },
-                .payload = "Hello darkness my old friend",
-            },
-        };
-
-        const to_bytes = try msg.toBytes(gpa);
-        defer gpa.free(to_bytes);
-
-        const from_bytes = try Message.fromBytes(to_bytes, gpa);
-        defer from_bytes.deinit(gpa);
-
-        try std.testing.expectEqualDeep(msg, from_bytes);
-    }
-    return error.SkipZigTest;
-}
-
 test {
     std.testing.refAllDeclsRecursive(@This());
 }