mirrors/libguestfs
1
0
Fork 0
mirror of https://github.com/libguestfs/libguestfs.git synced 2026-03-22 07:03:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

ocaml/implicit_close test: collect all currently unreachable blocks

Browse Source 
Fixes failing implice_close test on OCaml 5.

RWMJ:

I adjusted this patch so that we continue to call Gc.compact on
exiting the test, to move all of the heap (hopefully revealing flaws
in the bindings).  This only works on OCaml <= 4, but Gc.compact may
be fixed/reimplemented later in the 5.x series.

Please see also the lengthy discussion of this patch upstream:
https://listman.redhat.com/archives/libguestfs/2023-May/thread.html#31639
https://listman.redhat.com/archives/libguestfs/2023-June/thread.html#31709
https://discuss.ocaml.org/t/ocaml-heap-fsck-and-forcing-collection-of-unreachable-objects/12281/1
This commit is contained in:
Jürgen Hötzel
2023-05-27 15:32:36 +02:00
committed by Richard W.M. Jones
parent 7f35e37d75
commit 1274452d22
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ocaml/t/guestfs_065_implicit_close.ml
View File

@@ -30,7 +30,7 @@ let () =
*)
(* This should cause the GC to close the handle. *)
let () = Gc.compact ()
let () = Gc.full_major ()
let () = assert (!close_invoked = 1)