mirrors/libguestfs
1
0
Fork 0
mirror of https://github.com/libguestfs/libguestfs.git synced 2026-03-21 22:53:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

v2v: linux: do not uninstall open-vm-tools w/ ubuntu-server

Browse Source 
ubuntu-server depends on open-vm-tools on Ubuntu, so if v2v tries to
uninstall open-vm-tools then dpkg will (rightfully) fail with a
dependency issue.

Since open-vm-tools is harmless after the conversion anyway (it will
not even run), then do not attempt to uninstall it if ubuntu-server is
installed too.

Followup of commit 2bebacf8bf.

Thanks to: Ming Xie.
This commit is contained in:
Pino Toscano
2019-02-27 17:51:59 +01:00
parent 3ed32996dd
commit 1a4fd822ef
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
v2v/convert_linux.ml
View File

@@ -289,6 +289,18 @@ let convert (g : G.guestfs) inspect source output rcaps =
(* Uninstall VMware Tools. *)
let remove = ref [] and libraries = ref [] in
(* On Ubuntu, the ubuntu-server metapackage depends on
* open-vm-tools, and thus any attempt to remove it will cause
* dependency issues. Hence, special case this situation, and
* leave open-vm-tools installed in this case.
*)
let has_ubuntu_server =
if family = `Debian_family then
List.exists (
fun { G.app2_name = name } ->
name = "ubuntu-server"
) inspect.i_apps
else false in
List.iter (
fun { G.app2_name = name } ->
if String.is_prefix name "vmware-tools-libraries-" then
@@ -301,7 +313,7 @@ let convert (g : G.guestfs) inspect source output rcaps =
List.push_front name remove
else if String.is_prefix name "open-vm-tools-" then
List.push_front name remove
else if name = "open-vm-tools" then
else if name = "open-vm-tools" && not has_ubuntu_server then
List.push_front name remove
) inspect.i_apps;
let libraries = !libraries in