mirrors/libguestfs
1
0
Fork 0
mirror of https://github.com/libguestfs/libguestfs.git synced 2026-03-22 07:03:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

builder: templates: Prevent script from being run as root.

Browse Source 
Or with LIBVIRT_DEFAULT_URI=qemu:///system which is the same
thing.

In either case the images are created as user qemu.qemu and then
aren't readable or modifiable by later parts of the script.
This commit is contained in:
Richard W.M. Jones
2017-07-13 12:07:35 +01:00
parent 9fd2231cb0
commit 2afe62eb60
1 changed files with 20 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
builder/templates/make-template.ml
View File

@@ -24,6 +24,12 @@
* shell scripts located in libguestfs.git/builder/website.
*)
#load "str.cma";;
#load "unix.cma";;
#directory "../../ocaml";; (* use locally built guestfs *)
(*#directory "+guestfs";; (* use globally installed guestfs *) *)
#load "mlguestfs.cma";;
open Printf
let prog = "make-template"
@@ -42,14 +48,23 @@ let () =
eprintf "%s: you must use `../../run ./make-template.ml ...' to run this script\n"
prog;
exit 1
);
(* Check we're not being run as root. *)
if Unix.geteuid () = 0 then (
eprintf "%s: don't run this script as root\n" prog;
exit 1
);
(* ... and that LIBVIRT_DEFAULT_URI=qemu:///system is NOT set,
* which is the same as above.
*)
let s = try Sys.getenv "LIBVIRT_DEFAULT_URI" with Not_found -> "" in
if s = "qemu:///system" then (
eprintf "%s: don't set LIBVIRT_DEFAULT_URI=qemu:///system\n" prog;
exit 1
)
;;
#load "str.cma";;
#load "unix.cma";;
#directory "../../ocaml";;
#load "mlguestfs.cma";;
type os =
| CentOS of int * int (* major, minor *)
| RHEL of int * int