mirrors/libguestfs
1
0
Fork 0
mirror of https://github.com/libguestfs/libguestfs.git synced 2026-03-21 22:53:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

daemon: Remove use of fixed-size stack buffers.

Browse Source 
GCC 7 complains that the fixed size buffers are not large enough
(at least in theory) when using ‘-O3 -mtune=broadwell’.
This commit is contained in:
Richard W.M. Jones
2017-04-19 16:55:16 +01:00
parent 9e0294f88f
commit 2de5e317ad
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
daemon/devsparts.c
View File

@@ -125,13 +125,16 @@ foreach_block_device (block_dev_func_t func, bool return_md)
static int
add_device (const char *device, struct stringsbuf *r)
{
char dev_path[256];
snprintf (dev_path, sizeof dev_path, "/dev/%s", device);
char *dev_path;
if (add_string (r, dev_path) == -1) {
if (asprintf (&dev_path, "/dev/%s", device) == -1) {
reply_with_perror ("asprintf");
return -1;
}
if (add_string_nodup (r, dev_path) == -1)
return -1;
return 0;
}
@@ -153,10 +156,13 @@ do_list_devices (void)
static int
add_partitions (const char *device, struct stringsbuf *r)
{
char devdir[256];
CLEANUP_FREE char *devdir = NULL;
/* Open the device's directory under /sys/block */
snprintf (devdir, sizeof devdir, "/sys/block/%s", device);
if (asprintf (&devdir, "/sys/block/%s", device) == -1) {
reply_with_perror ("asprintf");
return -1;
}
DIR *dir = opendir (devdir);
if (!dir) {