mirrors/libguestfs
1
0
Fork 0
mirror of https://github.com/libguestfs/libguestfs.git synced 2026-03-21 22:53:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

lib/create: explicitly close fd and report close(2) errors

Browse Source 
Signed-off-by: Susant Sahani <ssahani@redhat.com>
This commit is contained in:
Susant Sahani
2025-11-26 18:24:57 +05:30
committed by rwmjones
parent 192e086f66
commit 4349548c83
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/create.c
View File

@@ -104,9 +104,7 @@ guestfs_impl_disk_create (guestfs_h *g, const char *filename,
static int static int
disk_create_raw_block (guestfs_h *g, const char *filename) disk_create_raw_block (guestfs_h *g, const char *filename)
{ {
int fd; int fd = open(filename, O_WRONLY|O_NOCTTY|O_CLOEXEC, 0666);
fd = open (filename, O_WRONLY|O_NOCTTY|O_CLOEXEC, 0666);
if (fd == -1) { if (fd == -1) {
perrorf (g, _("cannot open block device: %s"), filename); perrorf (g, _("cannot open block device: %s"), filename);
return -1; return -1;
@@ -125,7 +123,10 @@ disk_create_raw_block (guestfs_h *g, const char *filename)
} }
#endif #endif
close (fd); if (close (fd) == -1) {
perrorf (g, _("%s: close"), filename);
return -1;
}
return 0; return 0;
} }