mirrors/libguestfs
1
0
Fork 0
mirror of https://github.com/libguestfs/libguestfs.git synced 2026-03-21 22:53:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

valgrind: Update suppression for PCRE2 transition

Browse Source 
OCaml PCRE.compile doesn't free up regexps if they are stored in
globals.  However the valgrind suppression for this matched the old
function name, not the new PCRE2 name.  Valgrind errors looked like:

==1799651== 145 bytes in 1 blocks are possibly lost in loss record 2,927 of 4,168
==1799651==    at 0x484186F: malloc (vg_replace_malloc.c:381)
==1799651==    by 0x4D5F2E5: pcre2_compile_8 (pcre2_compile.c:10250)
==1799651==    by 0x29E077: guestfs_int_pcre_compile (pcre-c.c:196)
==1799651==    by 0x2B725F: camlOVA__entry (OVA.ml:392)
==1799651==    by 0x2859A8: caml_program (in /home/rjones/d/virt-v2v/v2v/virt-v2v)
==1799651==    by 0x40F9D8: caml_start_program (in /home/rjones/d/virt-v2v/v2v/virt-v2v)
==1799651==    by 0x40FD86: caml_startup_common (in /home/rjones/d/virt-v2v/v2v/virt-v2v)
==1799651==    by 0x40FDDC: caml_startup (in /home/rjones/d/virt-v2v/v2v/virt-v2v)
==1799651==    by 0x28523F: main (in /home/rjones/d/virt-v2v/v2v/virt-v2v)

(cherry picked from virt-v2v commit 2949109ff9f7a081b1a4b475b9f7bcbef5b45ee0)

(cherry picked from commit ede3632612)
This commit is contained in:
Richard W.M. Jones
2022-10-12 12:18:18 +01:00
parent 75c30fe750
commit 59ac5ba943
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
valgrind-suppressions
View File

@@ -190,14 +190,14 @@
fun:caml_stop_stack_overflow_detection
}
# The OCaml PCRE.compile function calls pcre_compile2 which allocates
# The OCaml PCRE.compile function calls pcre2_compile_8 which allocates
# memory. If these regexps are stored in a global variable then they
# can never be freed. This is not really a bug, so ignore it.
{
ocaml_pcre_globals
Memcheck:Leak
fun:malloc
fun:pcre_compile2
fun:pcre2_compile_8
...
}