Rename icat command in download_inode

The "icat" name comes from the employed command line tool which might be
replaced at any time with a different implementation.

The command name is a bit confusing because it's similar to "cat" but
act as "download".

download_inode is more clear and descriptive.

Signed-off-by: Matteo Cafasso <noxdafox@gmail.com>

daemon/sleuthkit.c

@@ -40,7 +40,7 @@ optgroup_sleuthkit_available (void)
 }
 
 int
-do_icat (const mountable_t *mountable, int64_t inode)
+do_download_inode (const mountable_t *mountable, int64_t inode)
 {
   CLEANUP_FREE char *cmd = NULL;
 

generator/actions.ml

@@ -12946,7 +12946,7 @@ The filesystem from which to extract the file must be unmounted,
 otherwise the call will fail." };
 
   { defaults with
-    name = "icat"; added = (1, 33, 14);
+    name = "download_inode"; added = (1, 33, 14);
     style = RErr, [Mountable "device"; Int64 "inode"; FileOut "filename"], [];
     proc_nr = Some 464;
     optional = Some "sleuthkit";

tests/tsk/Makefile.am

@@ -18,7 +18,7 @@
 include $(top_srcdir)/subdir-rules.mk
 
 TESTS = \
-	test-icat.sh
+	test-download-inode.sh
 
 TESTS_ENVIRONMENT = $(top_builddir)/run --test
 

tests/tsk/test-download-inode.sh

@@ -16,11 +16,11 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
-# Test the icat command.
+# Test the download_inode command.
 
 set -e
 
-if [ -n "$SKIP_TEST_ICAT_SH" ]; then
+if [ -n "$SKIP_TEST_DOWNLOAD_INODE_SH" ]; then
     echo "$0: test skipped because environment variable is set."
     exit 77
 fi
@@ -41,7 +41,7 @@ fi
 # download Master File Table ($MFT).
 guestfish --ro -a ../../test-data/phony-guests/windows.img <<EOF
 run
-icat /dev/sda2 0 test-mft.bin
+download-inode /dev/sda2 0 test-mft.bin
 EOF
 
 # test extracted file is the Master File Table