mirrors/libguestfs
1
0
Fork 0
mirror of https://github.com/libguestfs/libguestfs.git synced 2026-03-22 07:03:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

lua: Don't leak memory for returned objects (found by Coverity).

Browse Source
This commit is contained in:
Richard W.M. Jones
2012-12-08 15:27:12 +00:00
parent 9733665bc6
commit 855f023d2e
1 changed files with 26 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
generator/lua.ml
View File

@@ -92,6 +92,8 @@ static uint64_t get_event (lua_State *L, int index);
static uint64_t get_event_bitmask (lua_State *L, int index);
static void push_event (lua_State *L, uint64_t event);
static void free_strings (char **r);
";
List.iter (
@@ -587,19 +589,26 @@ guestfs_lua_delete_event_callback (lua_State *L)
| RInt64 _ ->
pr " push_int64 (L, r);\n"
| RConstString _
| RConstOptString _
| RString _ ->
| RConstOptString _ ->
pr " lua_pushstring (L, r);\n"
| RString _ ->
pr " lua_pushstring (L, r);\n";
pr " free (r);\n"
| RStringList _ ->
pr " push_string_list (L, r);\n"
pr " push_string_list (L, r);\n";
pr " free_strings (r);\n"
| RHashtable _ ->
pr " push_table (L, r);\n"
pr " push_table (L, r);\n";
pr " free_strings (r);\n"
| RStruct (_, typ) ->
pr " push_%s (L, r);\n" typ
pr " push_%s (L, r);\n" typ;
pr " guestfs_free_%s (r);\n" typ
| RStructList (_, typ) ->
pr " push_%s_list (L, r);\n" typ
pr " push_%s_list (L, r);\n" typ;
pr " guestfs_free_%s_list (r);\n" typ
| RBufferOut _ ->
pr " lua_pushlstring (L, r, size);\n"
pr " lua_pushlstring (L, r, size);\n";
pr " free (r);\n"
);
if ret = RErr then
@@ -848,6 +857,16 @@ push_event (lua_State *L, uint64_t event)
) (rstructs_used_by all_functions);
pr "\
void
free_strings (char **r)
{
size_t i;
for (i = 0; r[i] != NULL; ++i)
free (r[i]);
free (r);
}
/* Metamethods.
* See: http://article.gmane.org/gmane.comp.lang.lua.general/95065
*/