daemon/selinux-relabel: don't exclude "/selinux" if it's non-existent

Since RHBZ#726528, filesystem.rpm doesn't include /selinux.  setfiles
then gives us the warning: "Can't stat exclude path "/sysroot/selinux",
No such file or directory - ignoring."

Though the warning is harmless, let's get rid of it by checking the
existence of /selinux directory.

Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Richard W.M. Jones <rjones@redhat.com>
This commit is contained in:
Andrey Drobyshev
2023-04-26 15:59:44 +03:00
committed by Richard W.M. Jones
parent 7674d603e9
commit 9ced5fac8c

View File

@@ -21,6 +21,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sys/stat.h>
#include "guestfs_protocol.h"
#include "daemon.h"
@@ -37,6 +38,17 @@ optgroup_selinuxrelabel_available (void)
return prog_exists ("setfiles");
}
static int
dir_exists (const char *dir)
{
struct stat statbuf;
if (stat (dir, &statbuf) == 0 && S_ISDIR (statbuf.st_mode))
return 1;
else
return 0;
}
static int
setfiles_has_option (int *flag, char opt_char)
{
@@ -99,8 +111,10 @@ do_selinux_relabel (const char *specfile, const char *path,
*/
ADD_ARG (argv, i, "-e"); ADD_ARG (argv, i, s_dev);
ADD_ARG (argv, i, "-e"); ADD_ARG (argv, i, s_proc);
ADD_ARG (argv, i, "-e"); ADD_ARG (argv, i, s_selinux);
ADD_ARG (argv, i, "-e"); ADD_ARG (argv, i, s_sys);
if (dir_exists (s_selinux)) {
ADD_ARG (argv, i, "-e"); ADD_ARG (argv, i, s_selinux);
}
/* You have to use the -m option (where available) otherwise
* setfiles puts all the mountpoints on the excludes list for no