Enhance BUGS script.

Since RHBZ was updated, the old python-bugzilla program broke.  When
it was fixed, I found the (undocumented) ordering of the results from
the old tool was no longer true.

This commit adds a small Perl script to sort the output predictably.
Now bugs are sorted by both bug state and bug number, so the output
should be more stable than before.

Re-enable creation of the BUGS file in 'make dist'
(this reverts commit 91f3456244).

Also the BUGS file has been updated.
(cherry picked from commit f90c01a5dc)
This commit is contained in:
Richard W.M. Jones
2012-06-07 09:18:12 +01:00
parent 9f8e3f00bc
commit a4a9643a9f
3 changed files with 198 additions and 173 deletions

338
BUGS
View File

@@ -1,5 +1,5 @@
NOTE: This file is automatically generated from "update-bugs.sh".
Last updated: 2012-05-17
Last updated: 2012-06-07
This contains a local list of the bugs that are open against
libguestfs. Bugs are tracked in the Red Hat Bugzilla database
@@ -20,132 +20,21 @@ When reporting a new bug, please check:
--------------------------------------------------
Bugs in NEW or ASSIGNED state are open and waiting for someone to fix.
676020 NEW https://bugzilla.redhat.com/show_bug.cgi?id=676020
After using virt-resize with an ntfs partition windows is not booting
684486 NEW https://bugzilla.redhat.com/show_bug.cgi?id=684486
Guest fails to boot after virt-resize
693064 NEW https://bugzilla.redhat.com/show_bug.cgi?id=693064
Symbolic links on ntfs-3g are not followed correctly by some commands
709326 NEW https://bugzilla.redhat.com/show_bug.cgi?id=709326
virt-inspector cannot detect ReactOS
728224 NEW https://bugzilla.redhat.com/show_bug.cgi?id=728224
configure can't find qemu on PPC
737261 NEW https://bugzilla.redhat.com/show_bug.cgi?id=737261
libguestfs grub-install API needs grub1
745576 NEW https://bugzilla.redhat.com/show_bug.cgi?id=745576
libguestfs (or qemu?) hangs if sparse file runs out of disk space
761565 NEW https://bugzilla.redhat.com/show_bug.cgi?id=761565
Missing deps on netpbm-progs and icoutils
770075 NEW https://bugzilla.redhat.com/show_bug.cgi?id=770075
FEBOOTSTRAP_MODULES fails if modules directory is not under /lib
770076 NEW https://bugzilla.redhat.com/show_bug.cgi?id=770076
FEBOOTSTRAP_KERNEL causes appliance build to fail
782167 NEW https://bugzilla.redhat.com/show_bug.cgi?id=782167
libguestfs doesn't recognize Windows Dynamic disks in some configurations, eg. spanned
785603 NEW https://bugzilla.redhat.com/show_bug.cgi?id=785603
copy-out can't find root directory
790837 NEW https://bugzilla.redhat.com/show_bug.cgi?id=790837
Use of atexit to clean up handles is wrong in multithreaded programs
798979 NEW https://bugzilla.redhat.com/show_bug.cgi?id=798979
Ubuntu install CDs from oneiric onwards are not recognized: "multi-boot operating systems are not supported"
801117 NEW https://bugzilla.redhat.com/show_bug.cgi?id=801117
libguestfs cannot get icon for Windows 8 preview
808193 NEW https://bugzilla.redhat.com/show_bug.cgi?id=808193
g.launch() crashes on RHEL 5
811265 NEW https://bugzilla.redhat.com/show_bug.cgi?id=811265
the list-filesystems can detect the reiserFS,but can not mount it.and minix filesystem too.
811395 NEW https://bugzilla.redhat.com/show_bug.cgi?id=811395
virt-inspector to detect ia64 Windows 2k3 install media
811398 NEW https://bugzilla.redhat.com/show_bug.cgi?id=811398
virt-inspector fails to detect Win2k, Win2k8, Win2k8r2, WinVista, Win7 install media
812970 NEW https://bugzilla.redhat.com/show_bug.cgi?id=812970
virt-rescue cannot set ><rescue> prompt, on Ubuntu 12.04
813271 NEW https://bugzilla.redhat.com/show_bug.cgi?id=813271
intermittent appliance boot failures (divide_error)
813290 NEW https://bugzilla.redhat.com/show_bug.cgi?id=813290
mdadm (md-detail) test occasionally fails with 'md device /dev/md125 does not appear to be active.'
815149 NEW https://bugzilla.redhat.com/show_bug.cgi?id=815149
virt-alignment-scan gives error "part_list: could not parse row from output of parted print command: /dev/vda:4194304B:virtblk:512:512:msdos:Virtio Block Device"
819086 NEW https://bugzilla.redhat.com/show_bug.cgi?id=819086
look for qemu-kvm on /usr/libexec
822538 NEW https://bugzilla.redhat.com/show_bug.cgi?id=822538
libguestfs tools hang on qcow2 encrypted disks
822626 NEW https://bugzilla.redhat.com/show_bug.cgi?id=822626
virt-ls error: "libguestfs: error: checksum: path: parameter cannot be NULL"
563450 NEW https://bugzilla.redhat.com/show_bug.cgi?id=563450
list-devices returns devices of different types out of order
696445 NEW https://bugzilla.redhat.com/show_bug.cgi?id=696445
Backport virt-inspector for virt-v2v
806176 NEW https://bugzilla.redhat.com/show_bug.cgi?id=806176
libguestfs doesn't use the external tools (wrestool ...) to get icon even these tools are installed
507278 NEW https://bugzilla.redhat.com/show_bug.cgi?id=507278
libguestfs fails to build on Fedora sparc64
547488 NEW https://bugzilla.redhat.com/show_bug.cgi?id=547488
guestfish cannot tab complete filenames that contain spaces
672485 NEW https://bugzilla.redhat.com/show_bug.cgi?id=672485
[RFE] virt-edit/tar/inspector do not support encrypted system
745282 NEW https://bugzilla.redhat.com/show_bug.cgi?id=745282
[RFE] Support to use virt-filesystems with remote libvirt systems
801640 NEW https://bugzilla.redhat.com/show_bug.cgi?id=801640
[RFE] the error reported by resize2fs-M need to be more clear
803643 NEW https://bugzilla.redhat.com/show_bug.cgi?id=803643
inspect-is-multipart return false when inspection results should be true
803650 NEW https://bugzilla.redhat.com/show_bug.cgi?id=803650
inspect-is-live return false when inspection results should be true
803657 NEW https://bugzilla.redhat.com/show_bug.cgi?id=803657
[RFE] inspect-is-netinst : support more distributions
805417 NEW https://bugzilla.redhat.com/show_bug.cgi?id=805417
RFE: support inspection of installation ISOs of WinVista, Win7, Win2008 & Win2008r2
806179 NEW https://bugzilla.redhat.com/show_bug.cgi?id=806179
RFE: support inspection of icon for more Windows guests
816839 NEW https://bugzilla.redhat.com/show_bug.cgi?id=816839
data overflow error when debug progress -1
507278 NEW https://bugzilla.redhat.com/show_bug.cgi?id=507278
libguestfs fails to build on Fedora sparc64
554829 NEW https://bugzilla.redhat.com/show_bug.cgi?id=554829
SELinux handling could be done better.
555803 NEW https://bugzilla.redhat.com/show_bug.cgi?id=555803
guestfs_tgz_out does not detect failure of tar command
563450 NEW https://bugzilla.redhat.com/show_bug.cgi?id=563450
list-devices returns devices of different types out of order
572337 NEW https://bugzilla.redhat.com/show_bug.cgi?id=572337
libguestfs should support gptsync
@@ -173,12 +62,21 @@ Bugs in NEW or ASSIGNED state are open and waiting for someone to fix.
637251 NEW https://bugzilla.redhat.com/show_bug.cgi?id=637251
virt-inspector fails to recognize data-only NTFS disk image
646036 NEW https://bugzilla.redhat.com/show_bug.cgi?id=646036
libguestfs fails to launch
660687 NEW https://bugzilla.redhat.com/show_bug.cgi?id=660687
guestmount: "touch" command fails: touch: setting times of `timestamp': Invalid argument
672485 NEW https://bugzilla.redhat.com/show_bug.cgi?id=672485
[RFE] virt-edit/tar/inspector do not support encrypted system
676020 NEW https://bugzilla.redhat.com/show_bug.cgi?id=676020
After using virt-resize with an ntfs partition windows is not booting
693064 NEW https://bugzilla.redhat.com/show_bug.cgi?id=693064
Symbolic links on ntfs-3g are not followed correctly by some commands
696445 NEW https://bugzilla.redhat.com/show_bug.cgi?id=696445
Backport virt-inspector for virt-v2v
696451 NEW https://bugzilla.redhat.com/show_bug.cgi?id=696451
libguestfs: unknown filesystem label SWAP-sda2
@@ -188,30 +86,132 @@ Bugs in NEW or ASSIGNED state are open and waiting for someone to fix.
700342 NEW https://bugzilla.redhat.com/show_bug.cgi?id=700342
virt-inspector resports unknown filesystem UUID
709326 NEW https://bugzilla.redhat.com/show_bug.cgi?id=709326
virt-inspector cannot detect ReactOS
728224 NEW https://bugzilla.redhat.com/show_bug.cgi?id=728224
configure can't find qemu on PPC
737261 NEW https://bugzilla.redhat.com/show_bug.cgi?id=737261
libguestfs grub-install API needs grub1
745282 NEW https://bugzilla.redhat.com/show_bug.cgi?id=745282
[RFE] Support to use virt-filesystems with remote libvirt systems
745576 NEW https://bugzilla.redhat.com/show_bug.cgi?id=745576
libguestfs (or qemu?) hangs if sparse file runs out of disk space
761565 NEW https://bugzilla.redhat.com/show_bug.cgi?id=761565
Missing deps on netpbm-progs and icoutils
770075 NEW https://bugzilla.redhat.com/show_bug.cgi?id=770075
FEBOOTSTRAP_MODULES fails if modules directory is not under /lib
770076 NEW https://bugzilla.redhat.com/show_bug.cgi?id=770076
FEBOOTSTRAP_KERNEL causes appliance build to fail
782167 NEW https://bugzilla.redhat.com/show_bug.cgi?id=782167
libguestfs doesn't recognize Windows Dynamic disks in some configurations, eg. spanned
785603 NEW https://bugzilla.redhat.com/show_bug.cgi?id=785603
copy-out can't find root directory
790837 NEW https://bugzilla.redhat.com/show_bug.cgi?id=790837
Use of atexit to clean up handles is wrong in multithreaded programs
798979 NEW https://bugzilla.redhat.com/show_bug.cgi?id=798979
Ubuntu install CDs from oneiric onwards are not recognized: "multi-boot operating systems are not supported"
801117 NEW https://bugzilla.redhat.com/show_bug.cgi?id=801117
libguestfs cannot get icon for Windows 8 preview
801640 NEW https://bugzilla.redhat.com/show_bug.cgi?id=801640
[RFE] the error reported by resize2fs-M need to be more clear
802389 NEW https://bugzilla.redhat.com/show_bug.cgi?id=802389
event handlers for 'close' event doesn't work in remote mode
691389 ASSIGNED https://bugzilla.redhat.com/show_bug.cgi?id=691389
Extended attributes don't work over guestmount (FUSE)
803643 NEW https://bugzilla.redhat.com/show_bug.cgi?id=803643
inspect-is-multipart return false when inspection results should be true
713678 ASSIGNED https://bugzilla.redhat.com/show_bug.cgi?id=713678
Not all febootstrap messages are redirected to log callbacks
803650 NEW https://bugzilla.redhat.com/show_bug.cgi?id=803650
inspect-is-live return false when inspection results should be true
721160 ASSIGNED https://bugzilla.redhat.com/show_bug.cgi?id=721160
Missing btrfs support
803657 NEW https://bugzilla.redhat.com/show_bug.cgi?id=803657
[RFE] inspect-is-netinst : support more distributions
539746 ASSIGNED https://bugzilla.redhat.com/show_bug.cgi?id=539746
launch fails when run inside a Xen guest, when no non-PV kernels are installed
805417 NEW https://bugzilla.redhat.com/show_bug.cgi?id=805417
RFE: support inspection of installation ISOs of WinVista, Win7, Win2008 & Win2008r2
806176 NEW https://bugzilla.redhat.com/show_bug.cgi?id=806176
libguestfs doesn't use the external tools (wrestool ...) to get icon even these tools are installed
806179 NEW https://bugzilla.redhat.com/show_bug.cgi?id=806179
RFE: support inspection of icon for more Windows guests
808193 NEW https://bugzilla.redhat.com/show_bug.cgi?id=808193
g.launch() crashes on RHEL 5
811265 NEW https://bugzilla.redhat.com/show_bug.cgi?id=811265
the list-filesystems can detect the reiserFS,but can not mount it.and minix filesystem too.
811395 NEW https://bugzilla.redhat.com/show_bug.cgi?id=811395
virt-inspector to detect ia64 Windows 2k3 install media
811398 NEW https://bugzilla.redhat.com/show_bug.cgi?id=811398
virt-inspector fails to detect Win2k, Win2k8, Win2k8r2, WinVista, Win7 install media
812970 NEW https://bugzilla.redhat.com/show_bug.cgi?id=812970
virt-rescue cannot set ><rescue> prompt, on Ubuntu 12.04
813271 NEW https://bugzilla.redhat.com/show_bug.cgi?id=813271
intermittent appliance boot failures (divide_error)
813290 NEW https://bugzilla.redhat.com/show_bug.cgi?id=813290
mdadm (md-detail) test occasionally fails with 'md device /dev/md125 does not appear to be active.'
815149 NEW https://bugzilla.redhat.com/show_bug.cgi?id=815149
virt-alignment-scan gives error "part_list: could not parse row from output of parted print command: /dev/vda:4194304B:virtblk:512:512:msdos:Virtio Block Device"
816839 NEW https://bugzilla.redhat.com/show_bug.cgi?id=816839
data overflow error when debug progress -1
819086 NEW https://bugzilla.redhat.com/show_bug.cgi?id=819086
look for qemu-kvm on /usr/libexec
822538 NEW https://bugzilla.redhat.com/show_bug.cgi?id=822538
libguestfs tools hang on qcow2 encrypted disks
822626 NEW https://bugzilla.redhat.com/show_bug.cgi?id=822626
virt-ls error: "libguestfs: error: checksum: path: parameter cannot be NULL"
824021 NEW https://bugzilla.redhat.com/show_bug.cgi?id=824021
inspection cannot recognize guest which uses btrfs subvolumes for root
824782 NEW https://bugzilla.redhat.com/show_bug.cgi?id=824782
virt-resize cannot resize PowerPC guests
825034 NEW https://bugzilla.redhat.com/show_bug.cgi?id=825034
libguestfs has bad depndency on /lib/libusb-1.0.so.0
503134 ASSIGNED https://bugzilla.redhat.com/show_bug.cgi?id=503134
guestfish's list splitting does not recognize internal quoting
539746 ASSIGNED https://bugzilla.redhat.com/show_bug.cgi?id=539746
launch fails when run inside a Xen guest, when no non-PV kernels are installed
541618 ASSIGNED https://bugzilla.redhat.com/show_bug.cgi?id=541618
guestfish not able to mount freebsd ufs2 partitions automatically
619334 ASSIGNED https://bugzilla.redhat.com/show_bug.cgi?id=619334
RFE: Enable coredump capture in the appliance
691389 ASSIGNED https://bugzilla.redhat.com/show_bug.cgi?id=691389
Extended attributes don't work over guestmount (FUSE)
713678 ASSIGNED https://bugzilla.redhat.com/show_bug.cgi?id=713678
Not all febootstrap messages are redirected to log callbacks
(64 bugs)
--------------------------------------------------
@@ -221,23 +221,32 @@ You can help by testing the fixes.
657499 MODIFIED https://bugzilla.redhat.com/show_bug.cgi?id=657499
checksum: wrong check sum type causes umount to fail
719879 ON_QA https://bugzilla.redhat.com/show_bug.cgi?id=719879
Rebase libguestfs in RHEL 6.3
749828 ON_QA https://bugzilla.redhat.com/show_bug.cgi?id=749828
p2v does not support raid devices
(3 bugs)
(2 bugs)
--------------------------------------------------
These bugs are in the VERIFIED state.
647174 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=647174
RHEL6: virt-clone should remove old udev rules when changing MAC address
679737 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=679737
libguestfs: improve error message when zerofree is not available in the appliance
719879 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=719879
Rebase libguestfs in RHEL 6.3
729076 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=729076
libguestfs confuses Hp_recovery partition with Windows root filesystem
731742 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=731742
libguestfs should escape special/non-printing characters in debug output
741183 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=741183
[RFE] Write a tool to align the partition(s) in a Windows XP image to a multiple of 8 sectors
760221 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=760221
RFE: Support inspection of cciss devices
@@ -247,12 +256,24 @@ These bugs are in the VERIFIED state.
785305 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=785305
ocaml (bytecode) bindings segfault in 'add_drive_opts'
785668 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=785668
aug-defnode: daemon crash
788642 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=788642
virt-edit doesn't preserve file permissions
789960 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=789960
guestfsd crash when try to mount non-exist disk
790958 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=790958
multiprovider build error: RuntimeError: link: /tmp/.guestfs-0/kernel /tmp/.guestfs-0/kernel.10139: File exists
795322 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=795322
add_ro should return error if not running in a config state
796520 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=796520
[RFE] Prevent user from running some appliance configure commands after appliance boot up
797760 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=797760
virt-resize on Windows XP in sysprep state causes "UNMOUNTABLE_BOOT_VOLUME" BSOD
@@ -265,63 +286,42 @@ These bugs are in the VERIFIED state.
799695 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=799695
guestfs.h fails to compile with c++ compiler
799798 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=799798
set_autosync: this function can only be called in the config state at /usr/share/perl5/vendor_perl/Sys/VirtConvert/GuestfsHandle.pm line 107
801273 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=801273
Document for set-pgroup need to be updated
801788 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=801788
libguestfs holds open file descriptors when handle is launched
803699 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=803699
libguestfs inspection fails on Windows XP: libguestfs: error: hivex: could not locate HKLMSYSTEMMountedDevices
809401 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=809401
inspection doesn't recognize Fedora 17+ (because of grub2 and UsrMove)
811673 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=811673
guestfs_last_error not set when qemu fails early during launch
812092 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=812092
libguestfs cannot open disk images which are symlinks to files that contain ':' (colon) character
647174 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=647174
RHEL6: virt-clone should remove old udev rules when changing MAC address
789960 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=789960
guestfsd crash when try to mount non-exist disk
799798 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=799798
set_autosync: this function can only be called in the config state at /usr/share/perl5/vendor_perl/Sys/VirtConvert/GuestfsHandle.pm line 107
807557 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=807557
virt-sysprep: wrong params are passed to virt-inspector
807905 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=807905
mkfs blocksize option breaks when creating btrfs
809401 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=809401
inspection doesn't recognize Fedora 17+ (because of grub2 and UsrMove)
811112 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=811112
[RFE][virt-sysprep] hostname can not be changed on rhel system
811117 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=811117
[RFE][virt-sysprep] net-hwaddr not removed from "ifcfg-*" files on rhel
811673 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=811673
guestfs_last_error not set when qemu fails early during launch
812092 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=812092
libguestfs cannot open disk images which are symlinks to files that contain ':' (colon) character
813329 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=813329
virt-p2v can not convert physical host on MD device
679737 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=679737
libguestfs: improve error message when zerofree is not available in the appliance
785668 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=785668
aug-defnode: daemon crash
795322 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=795322
add_ro should return error if not running in a config state
796520 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=796520
[RFE] Prevent user from running some appliance configure commands after appliance boot up
801273 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=801273
Document for set-pgroup need to be updated
741183 VERIFIED https://bugzilla.redhat.com/show_bug.cgi?id=741183
[RFE] Write a tool to align the partition(s) in a Windows XP image to a multiple of 8 sectors
(30 bugs)
(31 bugs)
End of BUGS file.

View File

@@ -204,8 +204,8 @@ website: $(HTMLFILES) $(TEXTFILES)
dist-hook:
$(top_srcdir)/build-aux/gitlog-to-changelog > ChangeLog
cp ChangeLog $(distdir)/ChangeLog
# $(top_srcdir)/update-bugs.sh > BUGS-t
# mv BUGS-t BUGS
$(top_srcdir)/update-bugs.sh > BUGS-t
mv BUGS-t BUGS
cp BUGS $(distdir)/BUGS
git log --pretty="format:%an <%ae>" | sort -u | uniq -w 10 | \
grep -v rjones | \

View File

@@ -23,7 +23,32 @@
# eg. if there is no net access or no 'bugzilla' program, but if that
# happens just exit and leave the BUGS file alone.
bugzilla query -c libguestfs --outputformat='%{bug_id} %{bug_status} %{short_desc}' > .bugs.tmp || exit 0
bugzilla query -c libguestfs \
--outputformat='%{bug_id} %{bug_status} %{short_desc}' |
perl -e '
sub bugclass {
local $_ = shift;
return 1 if /NEW/;
return 2 if /ASSIGNED/;
return 3 if /ON_DEV/;
return 4 if /POST/;
return 5 if /MODIFIED/;
return 6 if /ON_QA/;
return 7 if /VERIFIED/;
return 8 if /RELEASE_PENDING/;
return 9 #if /CLOSED/;
}
sub compare {
$a->[0] <=> $b->[0] || $a->[1] <=> $b->[1]
}
while (<>) {
/^(\d+) (\w+) (.*)/; push @bugs, [bugclass($2), $1, $2, $3];
}
foreach (sort compare @bugs) {
print $_->[1], " ", $_->[2], " ", $_->[3], "\n";
}
' \
> .bugs.tmp || exit 0
# Any errors from now on are fatal.
set -e
@@ -63,7 +88,7 @@ while read bugno status summary; do
*) bugclass=$status ;;
esac
# 'bugzilla' command returns the bugs sorted by status, NEW, ASSIGNED,
# perl sort returns the bugs sorted by status, NEW, ASSIGNED,
# MODIFIED, ..., CLOSED. Therefore start a new section when the
# status field changes.
if [ "$bugclass" != "$lastclass" ]; then