golang: tests: Call or defer g.Close().

This commit is contained in:
Richard W.M. Jones
2013-07-04 14:42:45 +01:00
parent 58b51f5921
commit bb09c4a448
7 changed files with 10 additions and 7 deletions

View File

@@ -810,6 +810,7 @@ and generate_golang_bindtests () =
pr " if errno != nil {\n";
pr " panic (fmt.Sprintf (\"could not create handle: %%s\", errno))\n";
pr " }\n";
pr " defer g.Close ()\n";
pr "\n";
generate_lang_bindtests (

View File

@@ -21,8 +21,9 @@ package guestfs
import "testing"
func Test020Create (t *testing.T) {
_, err := Create ()
g, err := Create ()
if err != nil {
t.Errorf ("could not create handle: %s", err)
}
g.Close ()
}

View File

@@ -25,10 +25,12 @@ func Test030CreateFlags (t *testing.T) {
if err != nil {
t.Errorf ("could not create handle: %s", err)
}
g.Close ()
g, err = Create_flags (CREATE_NO_ENVIRONMENT)
if err != nil {
t.Errorf ("could not create handle: %s", err)
}
defer g.Close ()
if err := g.Parse_environment (); err != nil {
t.Errorf ("could not parse environment: %s", err)
}

View File

@@ -25,6 +25,7 @@ func Test050HandleProperties (t *testing.T) {
if errno != nil {
t.Errorf ("could not create handle: %s", errno)
}
defer g.Close ()
v, err := g.Get_verbose ()
if err != nil {

View File

@@ -25,6 +25,7 @@ func Test070Optargs (t *testing.T) {
if errno != nil {
t.Errorf ("could not create handle: %s", errno)
}
defer g.Close ()
err := g.Add_drive ("/dev/null", nil)
if err != nil {
t.Errorf ("%s", err)

View File

@@ -29,11 +29,13 @@ func Test100Launch (t *testing.T) {
if errno != nil {
t.Errorf ("could not create handle: %s", errno)
}
defer g.Close ()
f, ferr := os.Create ("test.img")
if ferr != nil {
t.Errorf ("could not create file: %s", ferr)
}
defer os.Remove ("test.img")
if ferr := f.Truncate (500 * 1024 * 1024); ferr != nil {
t.Errorf ("could not truncate file: %s", ferr)
}
@@ -105,12 +107,6 @@ func Test100Launch (t *testing.T) {
if err != nil {
t.Errorf ("%s", err)
}
err = g.Close ()
if err != nil {
t.Errorf ("%s", err)
}
os.Remove ("test.img")
}
/* - declared in guestfs_900_rstringlist_test.go

View File

@@ -27,6 +27,7 @@ func Test900RStringLits (t *testing.T) {
if errno != nil {
t.Errorf ("could not create handle: %s", errno)
}
defer g.Close ()
actual, err := g.Internal_test_rstringlist ("16")
if err != nil {