mirrors/libguestfs
1
0
Fork 0
mirror of https://github.com/libguestfs/libguestfs.git synced 2026-03-21 22:53:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

perl: Give error instead of crashing if optarg is not an array reference.

Browse Source 
$g->add_drive ("", server => 1);

would segfault.  Now it gives a nice error instead:

  array reference expected for 'server' argument at [line]
This commit is contained in:
Richard W.M. Jones
2013-11-14 15:45:23 +00:00
parent 6a1061663f
commit c032130226
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
generator/perl.ml
View File

@@ -464,10 +464,13 @@ PREINIT:
| OStringList _ ->
pr " size_t i, len;\n";
pr " char **r;\n";
pr " SV *arg;\n";
pr " AV *av;\n";
pr " SV **svp;\n";
pr "\n";
pr " /* XXX More checking required here. */\n";
pr " arg = ST (items_i+1);\n";
pr " if (!SvROK (arg) || SvTYPE (SvRV (arg)) != SVt_PVAV)\n";
pr " croak (\"array reference expected for '%%s' argument\", \"%s\");\n" n;
pr " av = (AV *) SvRV (ST (items_i+1));\n";
pr "\n";
pr " /* Note av_len returns index of final element. */\n";