mirrors/libguestfs
1
0
Fork 0
mirror of https://github.com/libguestfs/libguestfs.git synced 2026-03-21 22:53:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

lib: Add automatic file descriptor cleanup using CLEANUP_CLOSE attrib

Browse Source 
Signed-off-by: Susant Sahani <ssahani@redhat.com>
This commit is contained in:
Susant Sahani
2025-11-26 19:16:21 +05:30
committed by Richard W.M. Jones
parent 40e549294e
commit cf6ac9aeba
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/create.c
View File

@@ -134,8 +134,8 @@ static int
disk_create_raw (guestfs_h *g, const char *filename, int64_t size,
const struct guestfs_disk_create_argv *optargs)
{
CLEANUP_CLOSE int fd = -1;
int allocated = 0;
int fd;
struct stat statbuf;
/* backingfile parameter not present checked above */
@@ -185,7 +185,6 @@ disk_create_raw (guestfs_h *g, const char *filename, int64_t size,
if (!allocated) { /* Sparse file. */
if (ftruncate (fd, size) == -1) {
perrorf (g, _("%s: truncate"), filename);
close (fd);
unlink (filename);
return -1;
}
@@ -198,7 +197,6 @@ disk_create_raw (guestfs_h *g, const char *filename, int64_t size,
if (err != 0) {
errno = err;
perrorf (g, _("%s: fallocate"), filename);
close (fd);
unlink (filename);
return -1;
}
@@ -216,7 +214,6 @@ disk_create_raw (guestfs_h *g, const char *filename, int64_t size,
r = write (fd, buffer, n);
if (r == -1) {
perrorf (g, _("%s: write"), filename);
close (fd);
unlink (filename);
return -1;
}
@@ -226,10 +223,12 @@ disk_create_raw (guestfs_h *g, const char *filename, int64_t size,
}
if (close (fd) == -1) {
fd = -1;
perrorf (g, _("%s: close"), filename);
unlink (filename);
return -1;
}
fd = -1;
return 0;
}