mirror of
https://github.com/libguestfs/libguestfs.git
synced 2026-03-22 07:03:38 +00:00
Fix code which looked for leaked FDs between each command.
This code was not checking the return value from system() so it failed if uncommented. Add ignore_value() around the call to system. However, leave the code still disabled.
This commit is contained in:
@@ -15,12 +15,13 @@
|
||||
|
||||
|
||||
# Specification in the form of a command-line invocation:
|
||||
# gnulib-tool --import --dir=. --lib=libgnu --source-base=lib --m4-base=m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux --with-tests --no-libtool --macro-prefix=gl hash manywarnings warnings
|
||||
# gnulib-tool --import --dir=. --lib=libgnu --source-base=lib --m4-base=m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux --with-tests --no-libtool --macro-prefix=gl hash ignore-value manywarnings warnings
|
||||
|
||||
# Specification in the form of a few gnulib-tool.m4 macro invocations:
|
||||
gl_LOCAL_DIR([])
|
||||
gl_MODULES([
|
||||
hash
|
||||
ignore-value
|
||||
manywarnings
|
||||
warnings
|
||||
])
|
||||
|
||||
@@ -29,6 +29,8 @@
|
||||
#include <rpc/types.h>
|
||||
#include <rpc/xdr.h>
|
||||
|
||||
#include "ignore-value.h"
|
||||
|
||||
#include "daemon.h"
|
||||
#include "../src/guestfs_protocol.h"
|
||||
|
||||
@@ -53,13 +55,11 @@ main_loop (int _sock)
|
||||
sock = _sock;
|
||||
|
||||
for (;;) {
|
||||
#if 0
|
||||
/* Most common errors are leaked memory and leaked file descriptors,
|
||||
* so run this between each command:
|
||||
*/
|
||||
if (verbose)
|
||||
system ("ls -l /proc/self/fd");
|
||||
#endif
|
||||
if (verbose && 0)
|
||||
ignore_value (system ("ls -l /proc/self/fd"));
|
||||
|
||||
/* Read the length word. */
|
||||
if (xread (sock, lenbuf, 4) == -1)
|
||||
|
||||
Reference in New Issue
Block a user