Fix code which looked for leaked FDs between each command.

This code was not checking the return value from system()
so it failed if uncommented.  Add ignore_value() around the
call to system.  However, leave the code still disabled.
This commit is contained in:
Richard Jones
2009-09-17 16:44:20 +01:00
parent da0a4f8d1f
commit d5fad33b4e
2 changed files with 6 additions and 5 deletions

View File

@@ -15,12 +15,13 @@
# Specification in the form of a command-line invocation:
# gnulib-tool --import --dir=. --lib=libgnu --source-base=lib --m4-base=m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux --with-tests --no-libtool --macro-prefix=gl hash manywarnings warnings
# gnulib-tool --import --dir=. --lib=libgnu --source-base=lib --m4-base=m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux --with-tests --no-libtool --macro-prefix=gl hash ignore-value manywarnings warnings
# Specification in the form of a few gnulib-tool.m4 macro invocations:
gl_LOCAL_DIR([])
gl_MODULES([
hash
ignore-value
manywarnings
warnings
])

View File

@@ -29,6 +29,8 @@
#include <rpc/types.h>
#include <rpc/xdr.h>
#include "ignore-value.h"
#include "daemon.h"
#include "../src/guestfs_protocol.h"
@@ -53,13 +55,11 @@ main_loop (int _sock)
sock = _sock;
for (;;) {
#if 0
/* Most common errors are leaked memory and leaked file descriptors,
* so run this between each command:
*/
if (verbose)
system ("ls -l /proc/self/fd");
#endif
if (verbose && 0)
ignore_value (system ("ls -l /proc/self/fd"));
/* Read the length word. */
if (xread (sock, lenbuf, 4) == -1)