Files
libguestfs/lib/tmpdirs.c
shivanayak 2bc54b40f7 lib: fix realpath memory leak on error paths in set_abs_path (#317)
When realpath() succeeds but subsequent operations fail, the
allocated path is leaked. Add free(ret) before returning -1
on both error paths.

Co-authored-by: Claude <norep@anthropic.com>
2026-03-11 09:37:00 +00:00

386 lines
10 KiB
C
Raw Permalink Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
/* libguestfs
* Copyright (C) 2012 Red Hat Inc.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/
/**
* Handle temporary directories.
*/
#include <config.h>
#include <stdio.h>
#include <stdlib.h>
#include <errno.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <libintl.h>
#include <unistd.h>
#include "ignore-value.h"
#include "guestfs.h"
#include "guestfs-internal.h"
#include "guestfs-internal-actions.h"
/**
* We need to make all tmpdir paths absolute because lots of places in
* the code assume this. Do it at the time we set the path or read
* the environment variable (L<https://bugzilla.redhat.com/882417>).
*
* The C<ctxstr> parameter is a string displayed in error messages
* giving the context of the operation (eg. name of environment
* variable being used, or API function being called).
*/
static int
set_abs_path (guestfs_h *g, const char *ctxstr,
const char *tmpdir, char **tmpdir_ret)
{
char *ret;
struct stat statbuf;
/* Free the old path, and set it to NULL so that if we fail below
* we don't end up with a pointer to freed memory.
*/
free (*tmpdir_ret);
*tmpdir_ret = NULL;
if (tmpdir == NULL)
return 0;
ret = realpath (tmpdir, NULL);
if (ret == NULL) {
perrorf (g, _("converting path to absolute path: %s: %s: realpath"),
ctxstr, tmpdir);
return -1;
}
if (stat (ret, &statbuf) == -1) {
perrorf (g, "%s: %s: %s: stat",
_("setting temporary directory"), ctxstr, tmpdir);
free (ret);
return -1;
}
if (!S_ISDIR (statbuf.st_mode)) {
error (g, _("%s: %s: %s is not a directory"),
_("setting temporary directory"), ctxstr, tmpdir);
free (ret);
return -1;
}
*tmpdir_ret = ret;
return 0;
}
int
guestfs_int_set_env_tmpdir (guestfs_h *g, const char *envname,
const char *tmpdir)
{
return set_abs_path (g, envname, tmpdir, &g->env_tmpdir);
}
int
guestfs_int_set_env_runtimedir (guestfs_h *g, const char *envname,
const char *runtimedir)
{
return set_abs_path (g, envname, runtimedir, &g->env_runtimedir);
}
int
guestfs_impl_set_tmpdir (guestfs_h *g, const char *tmpdir)
{
return set_abs_path (g, "set_tmpdir", tmpdir, &g->int_tmpdir);
}
/**
* Implements the C<guestfs_get_tmpdir> API.
*
* Note this actually calculates the tmpdir, so it never returns
* C<NULL>.
*/
char *
guestfs_impl_get_tmpdir (guestfs_h *g)
{
const char *str;
if (g->int_tmpdir)
str = g->int_tmpdir;
else if (g->env_tmpdir)
str = g->env_tmpdir;
else
str = "/tmp";
return safe_strdup (g, str);
}
int
guestfs_impl_set_cachedir (guestfs_h *g, const char *cachedir)
{
return set_abs_path (g, "set_cachedir", cachedir, &g->int_cachedir);
}
/**
* Implements the C<guestfs_get_cachedir> API.
*
* Note this actually calculates the cachedir, so it never returns C<NULL>.
*/
char *
guestfs_impl_get_cachedir (guestfs_h *g)
{
const char *str;
if (g->int_cachedir)
str = g->int_cachedir;
else if (g->env_tmpdir)
str = g->env_tmpdir;
else
str = "/var/tmp";
return safe_strdup (g, str);
}
/**
* Implements the C<guestfs_get_sockdir> API.
*
* Note this actually calculates the sockdir, so it never returns
* C<NULL>.
*/
char *
guestfs_impl_get_sockdir (guestfs_h *g)
{
const char *str;
uid_t euid = geteuid ();
if (euid == 0) {
/* Use /tmp exclusively for root, as otherwise qemu (running as
* qemu.qemu when launched by libvirt) will not be able to access
* the directory.
*/
str = "/tmp";
} else {
if (g->env_runtimedir)
str = g->env_runtimedir;
else
str = "/tmp";
}
return safe_strdup (g, str);
}
static int
lazy_make_tmpdir (guestfs_h *g,
char *(*getdir) (guestfs_h *g), int is_runtime_dir,
char **dest)
{
if (!*dest) {
CLEANUP_FREE char *tmpdir = getdir (g);
char *tmppath = safe_asprintf (g, "%s/libguestfsXXXXXX", tmpdir);
if (mkdtemp (tmppath) == NULL) {
int bad_runtime_dir = is_runtime_dir && errno == EACCES &&
STRPREFIX (tmpdir, "/run/user/");
if (!bad_runtime_dir)
perrorf (g, _("%s: cannot create temporary directory"), tmppath);
else
error (g, _("%s: cannot create temporary directory. It may be that $XDG_RUNTIME_DIR is pointing to a directory which we cannot write to, for example if you used su [user] to change to this user account (see https://bugzilla.redhat.com/967509). You can correct this by adjusting XDG_RUNTIME_DIR and possibly creating /run/user/%d with the right ownership."),
tmppath, (int) geteuid ());
free (tmppath);
return -1;
}
/* Allow qemu (which may be running as qemu.qemu) to read in this
* temporary directory; we are storing either sockets, or temporary
* disks which qemu needs to access to. (RHBZ#610880).
* We do this only for root, as for normal users qemu will be run
* under the same user.
*/
if (geteuid () == 0 && chmod (tmppath, 0755) == -1) {
perrorf (g, "chmod: %s", tmppath);
free (tmppath);
return -1;
}
*dest = tmppath;
}
return 0;
}
/**
* The C<g-E<gt>tmpdir> (per-handle temporary directory) is not
* created when the handle is created. Instead we create it lazily
* before the first time it is used, or during launch.
*/
int
guestfs_int_lazy_make_tmpdir (guestfs_h *g)
{
return lazy_make_tmpdir (g, guestfs_get_tmpdir, 0, &g->tmpdir);
}
int
guestfs_int_lazy_make_sockdir (guestfs_h *g)
{
return lazy_make_tmpdir (g, guestfs_get_sockdir, 1, &g->sockdir);
}
/**
* Generate unique temporary paths for temporary files.
*
* Returns a unique path or NULL on error.
*/
char *
guestfs_int_make_temp_path (guestfs_h *g,
const char *name, const char *extension)
{
int ret = 0;
ret = guestfs_int_lazy_make_tmpdir (g);
if (ret < 0)
return NULL;
return safe_asprintf (g, "%s/%s%d%s%s",
g->tmpdir, name, ++g->unique,
extension ? "." : "",
extension ? extension : "");
}
/**
* Create the path for a socket with the selected filename in the
* sockdir.
*/
int
guestfs_int_create_socketname (guestfs_h *g, const char *filename,
char (*sockpath)[UNIX_PATH_MAX])
{
int r;
if (guestfs_int_lazy_make_sockdir (g) == -1)
return -1;
r = snprintf (*sockpath, UNIX_PATH_MAX, "%s/%s", g->sockdir, filename);
if (r >= UNIX_PATH_MAX) {
error (g, _("socket path too long: %s/%s"), g->sockdir, filename);
return -1;
}
if (r < 0) {
perrorf (g, _("%s"), g->sockdir);
return -1;
}
return 0;
}
/**
* Generate unique paths for PID files.
*
* Returns a unique path or NULL on error. On success, the pathname points
* under sockdir and not tmpdir; daemons that write PID files after dropping
* privileges may not have access to tmpdir.
*/
char *
guestfs_int_make_pid_path (guestfs_h *g, const char *name)
{
if (guestfs_int_lazy_make_sockdir (g) < 0)
return NULL;
return safe_asprintf (g, "%s/%s%d.pid", g->sockdir, name, ++g->unique);
}
/**
* Create the supermin appliance directory under cachedir, if it does
* not exist.
*
* Sanity-check that the permissions on the cachedir are safe, in case
* it has been pre-created maliciously or tampered with.
*
* Returns the directory name which the caller must free.
*/
char *
guestfs_int_lazy_make_supermin_appliance_dir (guestfs_h *g)
{
CLEANUP_FREE char *tmpdir = guestfs_get_cachedir (g);
char *ret = NULL;
struct stat statbuf;
uid_t uid = geteuid ();
ret = safe_asprintf (g, "%s/.guestfs-%ju", tmpdir, (uintmax_t) uid);
ignore_value (mkdir (ret, 0755));
ignore_value (chmod (ret, 0755)); /* RHBZ#921292 */
/* See if the cache directory exists and passes some simple checks
* to make sure it has not been tampered with.
*/
if (lstat (ret, &statbuf) == -1) {
perrorf (g, _("stat: %s"), ret);
free (ret);
return NULL;
}
if (statbuf.st_uid != uid) {
error (g, _("security: cached appliance %s is not owned by UID %ju"),
ret, (uintmax_t) uid);
free (ret);
return NULL;
}
if (!S_ISDIR (statbuf.st_mode)) {
error (g, _("security: cached appliance %s is not a directory (mode %o)"),
ret, statbuf.st_mode);
free (ret);
return NULL;
}
if ((statbuf.st_mode & 0022) != 0) {
error (g, _("security: cached appliance %s is writable by group or other (mode %o)"),
ret, statbuf.st_mode);
free (ret);
return NULL;
}
/* "Touch" the directory. */
ignore_value (utimes (ret, NULL));
return ret;
}
/**
* Recursively remove a temporary directory. If removal fails, just
* return (it's a temporary directory so it'll eventually be cleaned
* up by a temp cleaner).
*
* This is implemented using C<rm -rf> because that's simpler and
* safer.
*/
void
guestfs_int_recursive_remove_dir (guestfs_h *g, const char *dir)
{
CLEANUP_CMD_CLOSE struct command *cmd = guestfs_int_new_command (g);
guestfs_int_cmd_add_arg (cmd, "rm");
guestfs_int_cmd_add_arg (cmd, "-rf");
guestfs_int_cmd_add_arg (cmd, dir);
ignore_value (guestfs_int_cmd_run (cmd));
}
void
guestfs_int_remove_tmpdir (guestfs_h *g)
{
if (g->tmpdir)
guestfs_int_recursive_remove_dir (g, g->tmpdir);
}
void
guestfs_int_remove_sockdir (guestfs_h *g)
{
if (g->sockdir)
guestfs_int_recursive_remove_dir (g, g->sockdir);
}