mirrors/libguestfs
1
0
Fork 0
mirror of https://github.com/libguestfs/libguestfs.git synced 2026-03-21 22:53:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

lib: libvirt: Stop recommending LIBGUESTFS_BACKEND=direct

Browse Source 
After many, many years, although libvirt does still often fail to
work, it's generally more secure to stick with libvirt than to try
running qemu directly.  The main issue here is that people have
cargo-culted LIBGUESTFS_BACKEND=direct everywhere (even when it's not
necessary).
This commit is contained in:
Richard W.M. Jones
2024-05-22 11:22:31 +01:00
parent 219845d5d0
commit 12da1de0a8
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/launch-libvirt.c
View File

@@ -625,12 +625,8 @@ launch_libvirt (guestfs_h *g, void *datav, const char *libvirt_uri)
dom = virDomainCreateXML (conn, (char *) xml, VIR_DOMAIN_START_AUTODESTROY);
if (!dom) {
libvirt_error (g, _(
"could not create appliance through libvirt.\n"
"\n"
"Try running qemu directly without libvirt using this environment variable:\n"
"export LIBGUESTFS_BACKEND=direct\n"
"\n"
"Original error from libvirt"));
"could not create appliance through libvirt. "
"Original error from libvirt"));
goto cleanup;
}