mirror of
https://github.com/libguestfs/libguestfs.git
synced 2026-03-21 22:53:37 +00:00
7e0b5f4221
Since RHEL 7.4, the noop scheduler is no longer a thing. Trying to set it results in the error: + echo noop /init: line 108: echo: write error: Invalid argument The current recommendation (https://access.redhat.com/solutions/5427) is to use mq-deadline, but that's also the default so we don't have to do anything. A bigger reason to remove these lines is that kernel 6.11.0 has introduced a hang where -- rarely -- the ext4 filesystem hangs if you try to change the scheduler while handing a page fault, even if you're setting a scheduler that doesn't exist. I couldn't get much detail except for a couple of stack traces from different VMs: crash> set 234 PID: 234 COMMAND: "modprobe" TASK: ffff9f5ec3a22f40 [THREAD_INFO: ffff9f5ec3a22f40] CPU: 0 STATE: TASK_UNINTERRUPTIBLE crash> bt PID: 234 TASK: ffff9f5ec3a22f40 CPU: 0 COMMAND: "modprobe" #0 [ffffb21e002e7840] __schedule at ffffffffa718f6d0 #1 [ffffb21e002e78f8] schedule at ffffffffa7190a27 #2 [ffffb21e002e7908] __bio_queue_enter at ffffffffa67e121c #3 [ffffb21e002e7968] blk_mq_submit_bio at ffffffffa67f358c #4 [ffffb21e002e79f0] __submit_bio at ffffffffa67e1e3c #5 [ffffb21e002e7a58] submit_bio_noacct_nocheck at ffffffffa67e2326 #6 [ffffb21e002e7ac0] ext4_mpage_readpages at ffffffffa65ceafc #7 [ffffb21e002e7be0] read_pages at ffffffffa6381d17 #8 [ffffb21e002e7c40] page_cache_ra_unbounded at ffffffffa6381ff5 #9 [ffffb21e002e7ca8] filemap_fault at ffffffffa63761b5 #10 [ffffb21e002e7d48] __do_fault at ffffffffa63d1892 #11 [ffffb21e002e7d70] do_fault at ffffffffa63d2425 #12 [ffffb21e002e7da0] __handle_mm_fault at ffffffffa63d8c6b #13 [ffffb21e002e7e88] handle_mm_fault at ffffffffa63d95c2 #14 [ffffb21e002e7ec8] do_user_addr_fault at ffffffffa60b34ea #15 [ffffb21e002e7f28] exc_page_fault at ffffffffa7186e4e #16 [ffffb21e002e7f50] asm_exc_page_fault at ffffffffa72012a6 RIP: 000055d16159f8d8 RSP: 00007ffdd4c1f340 RFLAGS: 00010206 RAX: 00000000000bec82 RBX: 00007ff2fd00dc82 RCX: 000055d1615b492a RDX: 00007ffdd4c216b0 RSI: 00000000200bec82 RDI: 000055d185725960 RBP: 00007ffdd4c1f5a0 R8: 0000000000000000 R9: 0000000000000000 R10: 0000000000000000 R11: 0000000000000202 R12: 00000000200bec82 R13: 000055d185725960 R14: 00007ffdd4c216b0 R15: 000055d1615b9708 ORIG_RAX: ffffffffffffffff CS: 0033 SS: 002b crash> set 230 PID: 230 COMMAND: "modprobe" TASK: ffff98ce03ca3040 [THREAD_INFO: ffff98ce03ca3040] CPU: 0 STATE: TASK_UNINTERRUPTIBLE crash> bt PID: 230 TASK: ffff98ce03ca3040 CPU: 0 COMMAND: "modprobe" #0 [ffffaf9940307840] __schedule at ffffffff9618f6d0 #1 [ffffaf99403078f8] schedule at ffffffff96190a27 #2 [ffffaf9940307908] __bio_queue_enter at ffffffff957e121c #3 [ffffaf9940307968] blk_mq_submit_bio at ffffffff957f358c #4 [ffffaf99403079f0] __submit_bio at ffffffff957e1e3c #5 [ffffaf9940307a58] submit_bio_noacct_nocheck at ffffffff957e2326 #6 [ffffaf9940307ac0] ext4_mpage_readpages at ffffffff955ceafc #7 [ffffaf9940307be0] read_pages at ffffffff95381d1a #8 [ffffaf9940307c40] page_cache_ra_unbounded at ffffffff95381ff5 #9 [ffffaf9940307ca8] filemap_fault at ffffffff953761b5 #10 [ffffaf9940307d48] __do_fault at ffffffff953d1895 #11 [ffffaf9940307d70] do_fault at ffffffff953d2425 #12 [ffffaf9940307da0] __handle_mm_fault at ffffffff953d8c6b #13 [ffffaf9940307e88] handle_mm_fault at ffffffff953d95c2 #14 [ffffaf9940307ec8] do_user_addr_fault at ffffffff950b34ea #15 [ffffaf9940307f28] exc_page_fault at ffffffff96186e4e #16 [ffffaf9940307f50] asm_exc_page_fault at ffffffff962012a6 RIP: 0000556b7a7468d8 RSP: 00007ffde2ffb560 RFLAGS: 00000206 RAX: 00000000000bec82 RBX: 00007f5331a0dc82 RCX: 0000556b7a75b92a RDX: 00007ffde2ffd8d0 RSI: 00000000200bec82 RDI: 0000556ba8edf960 RBP: 00007ffde2ffb7c0 R8: 0000000000000000 R9: 0000000000000000 R10: 0000000000000000 R11: 0000000000000202 R12: 00000000200bec82 R13: 0000556ba8edf960 R14: 00007ffde2ffd8d0 R15: 0000556b7a760708 ORIG_RAX: ffffffffffffffff CS: 0033 SS: 002b Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2303267 (cherry picked from commitb2d682a473) (cherry picked from commit7a81df902a)
Libguestfs is tools and a library for accessing and modifying guest disk images. For more information see the home page: http://libguestfs.org/ For discussion, development, patches, etc. please use the mailing list: http://www.redhat.com/mailman/listinfo/libguestfs To find out how to build libguestfs from source, read: docs/guestfs-building.pod http://libguestfs.org/guestfs-building.1.html man docs/guestfs-building.1 Copyright (C) 2009-2023 Red Hat Inc. The library is distributed under the LGPLv2+. The programs are distributed under the GPLv2+. Please see the files COPYING and COPYING.LIB for full license information. The examples are under a very liberal license.